[CP] Fix Flutter doctor crash on Windows caused by bad UTF8 from vswhere.exe #104654
Description
issue_link
Commit Hash
Target
stable
Impacted Users
Windows developers using the latest version of Visual Studio
Impact Description
Flutter doctor crashes on Windows on the latest version of Visual Studio for certain locales. See: #102451
Workaround
Yes, workarounds include
- Downgrade Visual Studio to an unaffected version
- Switch your locale to English
- Patch your Visual Studio installation and replace
vswhere.exewith a pre-release build: https://github.com/microsoft/vswhere/releases
Risk
low
Test Coverage
yes
Validation Steps
There are three commits to cherry pick:
- 928bb12 from PR [tool] Consistent FakeProcessManager.run/runSync #103947 - This commit made it possible to unit test the fix
- 52e19ef from PR Refactor vswhere.exe integration #104133 - This commit refactors vswhere.exe integration
- c29a7a2 from PR Ignore replacement characters from vswhere.exe output #104284 - This commit ignores replacement characters from vswhere.exe output
All of these commits contain unit tests. Manual testing that can be ensuring flutter doctor does not crash on Windows with the latest Visual Studio installation.