Skip to content

Incorrect InkSparkle colors #104312

New issue
New issue
Closed
#110552
Closed
Incorrect InkSparkle colors#104312
#110552
Assignees
clocksmith
Labels
f: material designflutter/packages/flutter/material repository.found in release: 3.0Found to occur in 3.0found in release: 3.1Found to occur in 3.1frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer version
@jlahd

Description

@jlahd
jlahd
opened on May 21, 2022

Steps to Reproduce

  1. Make an InkWell. Specify Colors.blue as splashColor.
  2. Witness a green splash (incorrect).
  3. Change the color to Colors.green.
  4. Witness a blue splash (incorrect).
  5. Change the color to Colors.red.
  6. Witness a red splash (correct).

This is due to a bug in ink_sparkle.dart that has the blue and green components reversed in the _colorToVector4 function. I am submitting a PR with a fix as well.

Metadata

Metadata

Assignees

Labels

f: material designflutter/packages/flutter/material repository.found in release: 3.0Found to occur in 3.0found in release: 3.1Found to occur in 3.1frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions