Skip to content

Some tests of VersionFreshnessValidator are incorrect #104065

New issue
New issue
Closed
#191593
Closed
Some tests of VersionFreshnessValidator are incorrect#104065
#191593
Labels
P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

Description

@royarg02
royarg02
opened on May 18, 2022

Tests for checking whether VersionFreshnessValidator.run() is pinging the server or not (see this and these tests), have a bug. The line

expect(cache.setVersionStamp, true);

which is used to check whether there has been a write to the cache, only possible when the tool tries to ping the server, actually satisfy because of these lines:

flutter/packages/flutter_tools/lib/src/version.dart

Lines 976 to 982 in ec02990

await Future.wait<void>(<Future<void>>[
stamp.store(
newTimeWarningWasPrinted: now,
cache: cache,
),
Future<void>.delayed(pauseTime),
]);

VersionFreshnessValidator does not involve in pinging the server in anyway, instead it is handled by _getLatestAvailableFlutterDate.

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    a: tests"flutter test", flutter_test, or one of our tests
    toolAffects the "flutter" command-line tool. See also t: labels.
    and removed
    in triagePresently being triaged by the triage team
    on May 18, 2022
  2. christopherfujino
    added
    P2Important issues not at the top of the work list
    on May 31, 2022
  3. flutter-triage-bot
    added
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    on Jul 8, 2023
  4. matanlurey
    added
    tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.
    on Jul 11, 2025
  5. auto-submit
    closed this as completedin #191593on Sep 8, 2026
  6. pull
    added a commit that references this issue on Sep 8, 2026

    [flutter_tools] Fix test separation between `VersionFreshnessValidato…

    e3efd66

  7. github-actions commented on Sep 22, 2026

    @github-actions
    github-actionsBot
    on Sep 22, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our teststeam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions