-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Discovered while working on #103496 and then moved into #103667
We don't pass --flutter-assets-dir to the flutter tester, so it cannot resolve files in the asset bundle.
We'd like to make asset loading (images, shaders) work via the regular means, since we already go through all the effort to build the bundle and configure a work around in the framework: https://github.com/flutter/flutter/blob/master/packages/flutter_test/lib/src/_binding_io.dart#L34
However, with this change we'll also load bundled fonts correctly. This will cause all Scuba tests in google3 currently using ahem to opt into real fonts, as well as breaking contrast checker tests that rely on ahem. This is a no-go, obviously.
Current Plan of Action:
- Allow asset loading through normal means, and deprecate and remove the binding work around.
- Configure the tester to only support ahem font unless a user explicitly called a loadFont API in the framework.
- Delete any binding registration code in google3
Long term, we could perhaps think of a smarter way to handle loading fonts. @goderbauer