Skip to content

fml::WriteAtomically is not atomic on windows #102838

@jonahwilliams

Description

@jonahwilliams

For more context see: flutter/engine#33003 (comment)

This function did not work, hence the disabled test. To make impellerc usable, we're going to add a workaround so it can at least output the file correctly. We should go back and make sure it is actually atomic, by fixing the sharing violation thrown when using the copy from temp file approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions