-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/plugins
#5376Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packageAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
Currently the mega-PR that is the first stage of a multi-package federated plugin change fails the analyze task in the pathified_analyze step because:
Rewriting references to: image_picker_platform_interface...
Plugins with dependency overrides are not currently supported.
Exit status: 4
That makes it harder to see if there are actual analyzer issues (and contradicts the instructions that the PR should pass everything but publishable and federated_safety).
We should look for our comment marker that goes with temporary dependency_override changes, and if it's there just skip the package under the assumption that it's already rewritten.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packageAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.