Skip to content

Implemented M3 Typography letterSpacing for bodyLarge does not match M3 Guide Spec. #102121

@rydmike

Description

@rydmike

Discrepancy: M3 Guide Typescale versus Flutter Typography Implementation

In this #89853 (comment), I made an observation that the spec in supplied image did not match the M3 Web guide concerning the Typescale / Typography for TextStyle bodyLarge and its used letterSpacing.

The image in (#89853) has bodyLarge and its used letterSpacing defined as 0.5
The guide at 0.15

In this PR https://github.com/flutter/flutter/pull/97829/files#diff-a91306c958d84cfa7a9287e538e2c8f22bd7765d59ec1dadb2382bda832332adR751 it was implemented as 0.5, and was merged into master as such:

bodyLarge: TextStyle(debugLabel: 'englishLike bodyLarge 2021', inherit: false, fontSize: 16.0, fontWeight: FontWeight.w400, letterSpacing: 0.5, height: 1.50, textBaseline: TextBaseline.alphabetic, leadingDistribution: TextLeadingDistribution.even),

Question:

Is the M3 guide spec wrong?
Or is it an oversight that the correction observation did not make it into the Flutter implementation?

One or the other needs to be corrected, they can't both be right.

In issue https://github.com/flutter/flutter/issues/89853 @rami-a concluded that the image was wrong and the web M3 spec correct.

Which of course means that the current Flutter implementation is incorrect.

cc: @darrenaustin @TahaTesser

Metadata

Metadata

Assignees

Labels

a: typographyText rendering, possibly libtxtf: material designflutter/packages/flutter/material repository.found in release: 2.13Found to occur in 2.13frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions