-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Avoid a linker error when Flutter plugins as CocoaPods are built as arm7v in add-to-app hosts, which will happen when that architecture slice is removed from Flutter.xcframework in #97342.
#97341 handled plugins not building for arm7v in normal Flutter app plugins by setting EXCLUDED_ARCHS in the podhelper:
| build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphoneos*]'] = '$(inherited) armv7' |
Figure out how to do the same for add-to-app plugins linking against Flutter when they are built into the host app. This is particularly tricky since there's no post_install Flutter script hook in the add-to-app version of this script:
Note the xcframeworks generated from flutter build ios-framework are already correct and those plugins do not build for arm7v--this issue is only tracking Option A
flutter/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
Lines 290 to 291 in fe5dadd
| 'connectivity.xcframework', | |
| 'ios-arm64', |