-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
While debugging #101379, I noticed that with Track Widget Builds enabled (debugProfileBuildsEnabled), a large amount of data is getting sent in the trace event args for the 'BUILD' timeline event:
flutter/packages/flutter/lib/src/widgets/framework.dart
Lines 2568 to 2575 in 35b18ba
| if (debugProfileBuildsEnabled) { | |
| debugTimelineArguments = <String, String>{ | |
| ...debugTimelineArguments, | |
| 'dirty count': '${_dirtyElements.length}', | |
| 'dirty list': '$_dirtyElements', | |
| 'lock level': '$_debugStateLockLevel', | |
| 'scope context': '$context', | |
| }; |
These additional debugging args were added in #93086. These events make the trace very heavy and will make the performance impact of Track Widget Builds even worse than it already is. We should create another flag to hide these args behind instead of reusing debugProfileBuildsEnabled.
This may apply to other debugTimelineArguments added in https://github.com/flutter/flutter/pull/93086/files#diff-134bc36bd7c045a92ffff29f7efdaa7d375384911475a40343814c76c87b17cb as well.