Skip to content

Xcode build failures are not printed when codesigning is off #100723

New issue
New issue
Closed
#101993
#100787
Closed
Xcode build failures are not printed when codesigning is off#100723
#101993
#100787
Labels
P1High-priority issues at the top of the work listt: xcode"xcodebuild" on iOS and general Xcode project managementtoolAffects the "flutter" command-line tool. See also t: labels.
@jmagman

Description

@jmagman
jmagman
opened on Mar 24, 2022

#94747 parsed the xcresult bundle and printed the errors from Xcode when the build fails. However, that output is not printed when there are other issues detected.

For example, this test has a build failure, but it's not printing the Xcode error because it's falling through here:

flutter/packages/flutter_tools/lib/src/ios/mac.dart

Lines 611 to 614 in b53ed9b

logger.printError("Try replacing 'com.example' with your signing id in Xcode:");
logger.printError(' open ios/Runner.xcworkspace');
return;
}

Instead, the xcresult errors should be moved to the top of diagnoseXcodeBuildFailure so it's always printed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listt: xcode"xcodebuild" on iOS and general Xcode project managementtoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions