-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.e: engine-toolEngine-specific tooling (i.e. `tools/engine_tool`).Engine-specific tooling (i.e. `tools/engine_tool`).engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
Just a list of small code clean-ups we should do in the web engine:
- Move test_embedding.dart from
lib/totest/. - Rename initialization.dart to
web_only_api.dartfor clarity.- This file should be removed entirely: [web] Deprecate and remove all public web-only APIs from
dart:ui#127395
- This file should be removed entirely: [web] Deprecate and remove all public web-only APIs from
- Compile web engine tests with sound null safety.
- Move
toMatrix32frominitialization.darttovector_math.dart. -
webOnlyAssetManagershould return a public type (engine.AssetManageris private). Alternatively, we could try removing it, but that's a bigger project. -
felt testshould throw an error when asked to test a file without_test.dartsuffix. Otherwise, locally you can dofelt test test/something.dartand it will pass, but the test won't run on LUCI. - Convert
lineLookupto something with an explicit initialization API, such asinitializeLineLookup()+lineLookuppair, like other APIs. Calling a getter for its side-effect is not idiomatic, and it also does not support deinitialization, which we aim to add in the future. - Don't use
syncas variable name infuturizeand_futurize. - Replace the word "scuba" with "golden" in web tests.
- Re-evaluate how tests initialize the engine. Currently, most call
webOnlyInitializePlatform, some callinitializeEngine. We also havetest_embedding.dart. It's kind of messy. -
canvas_mask_filter_golden_test.dartgoldens are broken on iOS Safari (they are blank).
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.e: engine-toolEngine-specific tooling (i.e. `tools/engine_tool`).Engine-specific tooling (i.e. `tools/engine_tool`).engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team