-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed as not planned
Closed as not planned
Copy link
Labels
team-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
In the PR #99092, integration tests were added that download sample apps for test from CIPD. The tests also specify ad-hoc downloading of the CIPD tool. Discussion on the PR is here.
This is problematic because:
- It introduces a new, undocumented method that our CI builds install depot_tools
- It introduces a new, undocumented method that our CI builds download CIPD packages (test shards can already declare CIPD dependencies via .ci.yaml.
- If there are network flakes either cloning depot_tools or downloading the cipd packages, they will show as test failures, rather than infrastructure failures if they occurred during a setup step.
I believe we should address this with one of:
- Move the test apps directly into the flutter/flutter repo (per Gary's comment here, this may not be feasible)
- Move the tests that depend on these test apps a new shard and declare the CIPD dependencies in the .ci.yaml (preferred)
- Move the test apps to another repository, possibly https://github.com/flutter/assets-for-api-docs. However, this doesn't solve the issues of network flakes causing the tests to fail. In this case they should probably be moved to a new shard as well, so that all the assets can be cloned once in a setup.
Metadata
Metadata
Assignees
Labels
team-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.