Skip to content

[flutter_tools] Move test repos downloaded from CIPD to another repo #100254

@christopherfujino

Description

@christopherfujino

In the PR #99092, integration tests were added that download sample apps for test from CIPD. The tests also specify ad-hoc downloading of the CIPD tool. Discussion on the PR is here.

This is problematic because:

  1. It introduces a new, undocumented method that our CI builds install depot_tools
  2. It introduces a new, undocumented method that our CI builds download CIPD packages (test shards can already declare CIPD dependencies via .ci.yaml.
  3. If there are network flakes either cloning depot_tools or downloading the cipd packages, they will show as test failures, rather than infrastructure failures if they occurred during a setup step.

I believe we should address this with one of:

  1. Move the test apps directly into the flutter/flutter repo (per Gary's comment here, this may not be feasible)
  2. Move the tests that depend on these test apps a new shard and declare the CIPD dependencies in the .ci.yaml (preferred)
  3. Move the test apps to another repository, possibly https://github.com/flutter/assets-for-api-docs. However, this doesn't solve the issues of network flakes causing the tests to fail. In this case they should probably be moved to a new shard as well, so that all the assets can be cloned once in a setup.

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions