Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: da676f7
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7c28e8e
Choose a head ref
  • 20 commits
  • 23 files changed
  • 7 contributors

Commits on Sep 8, 2023

  1. Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) (#… 

    …134310)

flutter/engine@6d6b448...47a7930

2023-09-08 [email protected] Roll Skia from c5e67d222f46 to 5b1e40fc0548 (5 revisions) (flutter/engine#45578)
2023-09-08 [email protected] Roll ANGLE from 65ec697f4183 to 83030fed595b (1 revision) (flutter/engine#45577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d73e1b6 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) (#… 

    …134313)

flutter/engine@47a7930...b2cb1d2

2023-09-08 [email protected] Roll Skia from 5181fcf6184e to 948959b6b53e (4 revisions) (flutter/engine#45583)
2023-09-08 [email protected] Remove usage of the Jazzy document formatter for Objective C, in favor of Doxygen. (flutter/engine#45561)
2023-09-08 [email protected] Roll ANGLE from 83030fed595b to a507f31285b8 (1 revision) (flutter/engine#45582)
2023-09-08 [email protected] Roll Skia from 5b1e40fc0548 to 5181fcf6184e (2 revisions) (flutter/engine#45580)
2023-09-08 [email protected] Document and provide small cleanups to `CommandPoolVk`. (flutter/engine#45558)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2f66f25 View commit details
    Browse the repository at this point in the history

  3. Add ios analyzer command for universal links (#134155) 

    ios version of https://github.com/flutter/flutter/pull/131009/files
    @chunhtai
    chunhtai authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f851e7f View commit details
    Browse the repository at this point in the history

  4. Update chip docs to clarify how to specify a shape with no border & e… 

    …xplain default values for Material 3 (#134298)

fixes [Update chip docs for Material 3 defaults.](#134296)

Addresses a [comment](#133856 (comment)) from @HansMuller as well
    @TahaTesser
    TahaTesser authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    90c524d View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) (#… 

    …134314)

flutter/engine@b2cb1d2...2da727e

2023-09-08 [email protected] Roll Skia from 948959b6b53e to 244c9ba5d0d7 (2 revisions) (flutter/engine#45584)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fa9c301 View commit details
    Browse the repository at this point in the history

  6. InputDecoration.error should activate error state (#134001) 

    When passed an `error` widget, `InputDecoration` should activate its error state. Before this change the `errorBorder` would only activate if an `errorText` was provided. This change solves this issue by accounting for a provided `error` widget.
    @Renzo-Olivares
    Renzo-Olivares authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    97cdc0e View commit details
    Browse the repository at this point in the history

  7. Remove TextPainter migration flag from the framework (#134274) 

    The migration flag in `ParagraphBuilder` will be removed next.
    @LongCatIsLooong
    LongCatIsLooong authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    621ad98 View commit details
    Browse the repository at this point in the history

  8. RestorationManager should dispatch creation in constructor. (#133911)

    @polina-c
    polina-c authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    834f5dc View commit details
    Browse the repository at this point in the history

  9. Fix memory leak in _DraggableScrollableSheetState (#134212)

    @ksokolovskyi
    ksokolovskyi authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5d5da38 View commit details
    Browse the repository at this point in the history

  10. Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) (#… 

    …134316)

flutter/engine@2da727e...8d28922

2023-09-08 [email protected] Roll Skia from 244c9ba5d0d7 to 4996cc1ef9ba (2 revisions) (flutter/engine#45586)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9dde216 View commit details
    Browse the repository at this point in the history

  11. Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) (#… 

    …134321)

flutter/engine@8d28922...66bec85

2023-09-08 [email protected] Roll ANGLE from 765bca2f810a to 98b0855b9a71 (1 revision) (flutter/engine#45589)
2023-09-08 [email protected] Roll Skia from 4996cc1ef9ba to 1012ef8349ba (1 revision) (flutter/engine#45588)
2023-09-08 [email protected] Roll ANGLE from a507f31285b8 to 765bca2f810a (1 revision) (flutter/engine#45587)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9c21023 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) (#… 

    …134324)

flutter/engine@66bec85...d6aa2d9

2023-09-08 [email protected] Roll Skia from 1012ef8349ba to 7f1d86d81d41 (1 revision) (flutter/engine#45594)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    996eb11 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) (#… 

    …134327)

flutter/engine@d6aa2d9...3a5f3ad

2023-09-09 [email protected] Roll Fuchsia Linux SDK from KvtLknmg3f23uqWVm... to jYqYNRum5gWGFyoHR... (flutter/engine#45599)
2023-09-09 [email protected] Roll Skia from 7f1d86d81d41 to e5987e341cfd (1 revision) (flutter/engine#45597)
2023-09-08 [email protected] Roll ANGLE from 98b0855b9a71 to fce1e57401bf (3 revisions) (flutter/engine#45596)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from KvtLknmg3f23 to jYqYNRum5gWG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    0c2f1af View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) (#… 

    …134328)

flutter/engine@3a5f3ad...1f2da3d

2023-09-09 [email protected] Makes Skia's vkQueueSubmit threadsafe. (flutter/engine#45459)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    e5d919c View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) (#… 

    …134332)

flutter/engine@1f2da3d...7af8a5d

2023-09-09 [email protected] Roll Fuchsia Mac SDK from h_bQLstuirD8blCZW... to RbgNQ_B-mcwvmNSq3... (flutter/engine#45603)
2023-09-09 [email protected] Roll ANGLE from fce1e57401bf to 48e2c605adcd (2 revisions) (flutter/engine#45602)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from h_bQLstuirD8 to RbgNQ_B-mcwv

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    12ce42b View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) (#… 

    …134336)

flutter/engine@7af8a5d...00ef109

2023-09-09 [email protected] Roll Skia from e5987e341cfd to 3dfd4316b80d (1 revision) (flutter/engine#45607)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2b64282 View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) (#… 

    …134349)

flutter/engine@00ef109...348e3a3

2023-09-09 [email protected] Roll Fuchsia Linux SDK from jYqYNRum5gWGFyoHR... to i9IPFS-XpkPjlH235... (flutter/engine#45609)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from jYqYNRum5gWG to i9IPFS-XpkPj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    3f4ee3f View commit details
    Browse the repository at this point in the history

  7. Day picker should dispose created MaterialStatesController's. (#133884) 

    Fixes #133862
    @polina-c
    polina-c authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    5555836 View commit details
    Browse the repository at this point in the history

  8. Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (#… 

    …134353)

flutter/engine@348e3a3...4e3231a

2023-09-09 [email protected] Roll Skia from 3dfd4316b80d to 58e39bd84ab2 (1 revision) (flutter/engine#45610)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    6660cc9 View commit details
    Browse the repository at this point in the history

  9. Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (#… 

    …134355)

flutter/engine@4e3231a...d1913cb

2023-09-09 [email protected] Roll Fuchsia Mac SDK from RbgNQ_B-mcwvmNSq3... to 51fG0shrG6fW64BtN... (flutter/engine#45612)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from RbgNQ_B-mcwv to 51fG0shrG6fW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    7c28e8e View commit details
    Browse the repository at this point in the history
Loading