Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bae1ac2
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 61fd11d
Choose a head ref
  • 7 commits
  • 6 files changed
  • 4 contributors

Commits on Jul 26, 2023

  1. Revert "ImageDecoration.lerp" (#131347) 

    Reverts #130533

Tree breakage.
    @Hixie
    Hixie authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    27e9123 View commit details
    Browse the repository at this point in the history

  2. Revert "Run benchmarks with --omit-type-checks" (#131353) 

    Reverts #131102 as it closed the tree due to `Linux web_benchmarks_skwasm` failures. The test seems to be timing out without completing.

Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/1/overview
    @loic-sharma
    loic-sharma authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    81b0e9f View commit details
    Browse the repository at this point in the history

  3. Update Unit Tests for M2/M3 (#131292) 

    Updated golden tests in 

* ink_sparkle_test.dart
* material_test.dart
* page_test.dart
* progress_indicator_test.dart

to have M2 and M3 versions.

More info in #127064
    @QuncCccccc
    QuncCccccc authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5d76d1a View commit details
    Browse the repository at this point in the history

  4. Revert "Update Unit Tests for M2/M3" (#131368) 

    Reverts #131292

This PR is affected by https://g-issues.skia.org/issues/40045533.

See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076):

> The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
    @loic-sharma
    loic-sharma authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f359d9e View commit details
    Browse the repository at this point in the history

  5. Minor adjustments on 2D APIs (#131358) 

    These tweaks came from flutter/packages#4536

- The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0
- The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate

I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
    @Piinks
    Piinks authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    bb0c317 View commit details
    Browse the repository at this point in the history

  6. ImageDecoration.lerp (#130533) (#131349) 

    This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes #12452

This was first landed in #130533 and reverted in #131347.
    @Hixie
    Hixie authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    33e9fd8 View commit details
    Browse the repository at this point in the history

  7. Add the 'a: desktop' label to labeler.yml (#130933) 

    The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
    @loic-sharma
    loic-sharma authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    61fd11d View commit details
    Browse the repository at this point in the history
Loading