Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9f455d2
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: adc9010
Choose a head ref
  • 4 commits
  • 8 files changed
  • 2 contributors

Commits on Oct 21, 2025

  1. [CP-stable][Android] Refactor ImageReaderSurfaceProducer restoratio… 

    …n after app resumes (#177112)

> [!NOTE]  
> To release engineer: this can definitely wait to be included in a hotfix beta release. I also want to CP this to 3.38 beta as part of a hotfix release: #177121

This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

#173770

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Mitigates a memory leak that occurs on Android, when `Activities` are not kept upon exit and an Activity is exited and re-entered.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Memory leak that will occur in production app but does not impact development.

### Workaround:
Is there a workaround for this issue?

Not that I know of.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Follow the steps in the [issue description](#173770 (comment)), roughly:

 1. Create a Flutter project.
2. Enter the developer options, set not to keep activities, (destroy each activity as soon as the user leaves it)
3. Entering the activity, clicking the home button, exiting the activity, and then entering the activity again will trigger the destruction and reconstruction of the activity.
4. Check memory leaks through profiler and find memory leaks.
    @flutteractionsbot
    flutteractionsbot authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    0353165 View commit details
    Browse the repository at this point in the history

  2. [CP-stable]fix: remove final class modifier on MenuController (#176725) 

    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

#174082

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

The `MenuController` class is marked `final` and breaks apps that extend this class.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Apps that used to rely on extended `MenuController`s won't build.

### Workaround:
Is there a workaround for this issue?

The app will have to modify their local Flutter repository. Otherwise, if the app really rely on extending the `MenuController` class to do custom logic, I can think of no ways for them to continue this customization under this restriction.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

The following snippet builds.
```
import 'package:flutter/material.dart';

class ExtendedMenuController extends MenuController {
  ExtendedMenuController();
}
```
    @flutteractionsbot
    flutteractionsbot authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    284ec68 View commit details
    Browse the repository at this point in the history

  3. Create changelog entry for flutter 3.35.7 (#177334) 

    Changelog entry onlyl
    @reidbaker
    reidbaker authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    8784a0b View commit details
    Browse the repository at this point in the history

  4. Update engine version for 3.35.7 (#177335) 

    Update the engine version by checking out flutter-3.35-candidate.0 and running `bin/internal/last_engine_commit.sh > bin/internal/engine.version`
    @reidbaker
    reidbaker authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    adc9010 View commit details
    Browse the repository at this point in the history
Loading