Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9c9e061
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ab721f9
Choose a head ref
  • 16 commits
  • 26 files changed
  • 6 contributors

Commits on Nov 20, 2023

  1. Reland update bottom navigation bar test for m3 (#137998)

    This is a reland of #136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation.
    
    Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness.
    One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`.
    
    This PR has two commits:
    - the first one is the original PR (#136624).
    - the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.
    bleroux authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1a9e866 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c9d966 View commit details
    Browse the repository at this point in the history
  3. [Reland] Introduce AnimationStyle (#138721)

    This PR introduces `AnimationStyle`, it is used to override default
    animation curves and durations in several widgets.
    
    fixes [Add the ability to customize MaterialApp theme animation
    duration](#78372)
    fixes [Allow customization of showMenu transition animation curves and
    duration](#135638)
    fixes [`AnimationStyle.noAnimation` needs to replace `AnimatedTheme`
    with just `Theme` in the
    `MaterialApp`](#138618)
    
    Here is an example where popup menu curve and transition duration is
    overridden:
    
    ```dart
              popUpAnimationStyle: AnimationStyle(
                curve: Easing.emphasizedAccelerate,
                duration: Durations.medium4,
              ),
    ```
    
    Set `AnimationStyle.noAnimation` to disable animation.
    ```dart
        return MaterialApp(
          themeAnimationStyle: AnimationStyle.noAnimation,
    ```
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    TahaTesser authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fc917c7 View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 7a31543b4630 to 6e8e55ef1a7f (4 revisions) (#…

    …138761)
    
    flutter/engine@7a31543...6e8e55e
    
    2023-11-20 [email protected] Silence a lint in `common/settings.h` in order to turn on `clang_tidy`. (flutter/engine#48239)
    2023-11-20 [email protected] Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244)
    2023-11-20 [email protected] Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243)
    2023-11-20 [email protected] Make `vulkan/...` compatible with `.clang_tidy`. (flutter/engine#48240)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from LnToEykA8o68 to Q3HcTitDF90Z
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e002b2d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5350da6 View commit details
    Browse the repository at this point in the history
  6. Added Features requested in #137530 (#137532)

    This PR will add new parameters to `ExpansionTile` widget to manage `dense`, `visualDensity` and `enableFeedback` of the main ListTile.
    
    Solves #137530 
    
    It is not a breaking change.
    mhbdev authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1dafa40 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    2e78cbc View commit details
    Browse the repository at this point in the history
  2. Add dartdoc warnings (#138766)

    Follow-up to #138760.
    goderbauer authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    24b99e5 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 39fb4581cff2 to f3e9b38a2588 (3 revisions) (#…

    …138770)
    
    flutter/engine@39fb458...f3e9b38
    
    2023-11-21 [email protected] Roll Dart SDK from ee7aaca9adcc to f1fd14505782 (1 revision) (flutter/engine#48250)
    2023-11-21 [email protected] Roll Skia from 3876e576a38e to f8daeeb7f092 (1 revision) (flutter/engine#48249)
    2023-11-20 [email protected] Roll Skia from c9943f14039f to 3876e576a38e (3 revisions) (flutter/engine#48246)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    889c083 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a216e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b6ef78e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a8eedf View commit details
    Browse the repository at this point in the history
  7. Fix Chips with Tooltip throw an assertion when enabling or disabling (#…

    …138799)
    
    fixes [Enabling or disabling a `Chip`/`RawChip` with a tooltip throws an exception](#138287) 
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        bool isEnabled = true;
    
        return MaterialApp(
          home: Material(
            child: Center(
              child: StatefulBuilder(
                  builder: (BuildContext context, StateSetter setState) {
                return Column(
                  mainAxisSize: MainAxisSize.min,
                  children: [
                    RawChip(
                      tooltip: 'This is a tooltip',
                      isEnabled: isEnabled,
                      label: const Text('RawChip'),
                      onPressed: isEnabled ? () {} : null,
                    ),
                    const SizedBox(height: 20),
                    ElevatedButton(
                      onPressed: () {
                        setState(() {
                          isEnabled = !isEnabled;
                        });
                      },
                      child: Text('${isEnabled ? 'Disable' : 'Enable'} Chip'),
                    )
                  ],
                );
              }),
            ),
          ),
        );
      }
    }
    ```
    
    </details>
    TahaTesser authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e6d43ac View commit details
    Browse the repository at this point in the history
  8. Manual roll Flutter Engine from 70b1c7341255 to 6da31e1bff67 (10 revi…

    …sions) (#138817)
    
    Manual roll requested by [email protected]
    
    flutter/engine@70b1c73...6da31e1
    
    2023-11-21 [email protected] Revert Dart SDK to 3.3.0-152.0.dev (flutter/engine#48272)
    2023-11-21 [email protected] [web] Add add/removeView JS methods. (flutter/engine#48106)
    2023-11-21 [email protected] Roll Skia from c244996e79d6 to c6d971f87d12 (1 revision) (flutter/engine#48268)
    2023-11-21 [email protected] Roll Skia from 516357c42907 to c244996e79d6 (1 revision) (flutter/engine#48266)
    2023-11-21 [email protected] Roll Dart SDK from 99d9cf9bd05a to 5e7b22caba8a (1 revision) (flutter/engine#48264)
    2023-11-21 [email protected] Roll Dart SDK from 64cbfa6c51e6 to 99d9cf9bd05a (1 revision) (flutter/engine#48261)
    2023-11-21 [email protected] Roll Skia from 88a9e6328f93 to 516357c42907 (1 revision) (flutter/engine#48260)
    2023-11-21 [email protected] Roll Skia from a26e5a5771c8 to 88a9e6328f93 (1 revision) (flutter/engine#48259)
    2023-11-21 [email protected] Roll Skia from f8daeeb7f092 to a26e5a5771c8 (2 revisions) (flutter/engine#48258)
    2023-11-21 [email protected] Roll Dart SDK from f1fd14505782 to 64cbfa6c51e6 (1 revision) (flutter/engine#48257)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3cd723b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5ae1bae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ab721f9 View commit details
    Browse the repository at this point in the history
Loading