Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 828a040
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: db6074a
Choose a head ref
  • 12 commits
  • 99 files changed
  • 3 contributors

Commits on May 1, 2023

  1. Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (#…

    …125833)
    
    flutter/engine@687f4c7...58cc541
    
    2023-05-01 [email protected] Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641)
    2023-05-01 [email protected] Add the verify exported symbols to linux builds. (flutter/engine#41635)
    2023-05-01 [email protected] [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998)
    2023-05-01 [email protected] [Impeller] Remove duplicate component in path.h (flutter/engine#41639)
    2023-05-01 [email protected] Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634)
    2023-05-01 [email protected] Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 1, 2023
    Configuration menu
    Copy the full SHA
    050e4ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    635337c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Migrate Xcode projects last version checks to Xcode 14.3 (#125827)

    1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
    2. Update iOS and macOS templates to same.
    3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested.  I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
    4. Run all example/integration test project to see migrator work.
    5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.
    
    Fixes #125817
    See #90304 for Xcode 13 example.
    jmagman authored May 2, 2023
    Configuration menu
    Copy the full SHA
    1861ac4 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (#…

    …125845)
    
    flutter/engine@3fa6084...7d87410
    
    2023-05-01 [email protected] Update xcode to 14e222b (flutter/engine#41640)
    2023-05-01 [email protected] Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646)
    2023-05-01 [email protected] Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645)
    2023-05-01 [email protected] Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 2, 2023
    Configuration menu
    Copy the full SHA
    d304545 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (#…

    …125858)
    
    flutter/engine@7d87410...024bf94
    
    2023-05-02 [email protected] Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655)
    2023-05-02 [email protected] Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654)
    2023-05-01 [email protected] [Impeller] take advantage of DisplayList culling (flutter/engine#41606)
    2023-05-01 [email protected] Use os_dimension in framework tests. (flutter/engine#41649)
    2023-05-01 [email protected] Turn @staticInterop tear-off into closure (flutter/engine#41643)
    2023-05-01 [email protected] Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 2, 2023
    Configuration menu
    Copy the full SHA
    7907f93 View commit details
    Browse the repository at this point in the history
  4. Make future and stream required arguments in their respective bui…

    …lder widgets (#125838)
    
    cc'ing existing conversation participants: @domesticmouse @srawlins
    cc'ing to request review: @goderbauer 
    
    This PR makes the following constructor arguments required:
    1. `FutureBuilder.future`
    2. `StreamBuilderBase.stream`
    3. `StreamBuilder.stream`
    
    This fixes:
    #83081
    #125188 (dupe of 83081)
    
    This obviates:
    https://github.com/dart-lang/linter/issues/4309
    (I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
    #83101 
    (The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)
    
    See above issues for a deeper dive, but here is a summary:
    It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
    As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.
    
    This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
    The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    caseycrogers authored May 2, 2023
    Configuration menu
    Copy the full SHA
    4d86f5d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5965313 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    55061e4 View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from c0d68c36c376 to d0ed35b7bf67 (1 revision) (#…

    …125870)
    
    flutter/engine@c0d68c3...d0ed35b
    
    2023-05-02 [email protected] Roll Fuchsia Mac SDK from u7iIoiSX4y8WV6Of1... to moQlKaNgpc0WD3sjC... (flutter/engine#41661)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from u7iIoiSX4y8W to moQlKaNgpc0W
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 2, 2023
    Configuration menu
    Copy the full SHA
    d82e697 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    005ad93 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    61c8291 View commit details
    Browse the repository at this point in the history
  10. Roll Flutter Engine from 46d5ce4784b8 to 44376e8cd3de (1 revision) (#…

    …125876)
    
    flutter/engine@46d5ce4...44376e8
    
    2023-05-02 [email protected] Roll Fuchsia Linux SDK from ur2ymZJCZSj64s6Q2... to g_6rn9e-GBQGQGwgt... (flutter/engine#41663)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from ur2ymZJCZSj6 to g_6rn9e-GBQG
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 2, 2023
    Configuration menu
    Copy the full SHA
    db6074a View commit details
    Browse the repository at this point in the history
Loading