Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 761747b
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b0850be
Choose a head ref
  • 6 commits
  • 11 files changed
  • 5 contributors

Commits on Jul 1, 2024

  1. [CP] Point kotlin message in gradle_errors.dart towards new place (#…

    …149881)
    
    Cherry pick request of #145936 to stable
    
    Update Flutter Fix log on how to update Kotlin Gradle Plugin that was introduced in Flutter 3.19.x
    
    Closes #149856
    brainwo authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    855aab9 View commit details
    Browse the repository at this point in the history
  2. [CP-stable][CLI tool] in flutter test, consider --flavor when val…

    …idating the cached asset bundle (#150617)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    #150296
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.
    
    Fixed bug in `flutter test` where `--flavor` wasn't considered when validating cached [assets](https://docs.flutter.dev/ui/assets/assets-and-images), causing the [flavor-conditional asset bundling](https://docs.flutter.dev/deployment/flavors#conditionally-bundling-assets-based-on-flavor) feature to not work as expected.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    For users of flavor-conditional asset bundling that used `--flavor` in `flutter test`, this could result in tests incorrectly passing or failing depending on which `--flavor` value they used since their last `flutter clean`.
    
    ### Workaround:
    Is there a workaround for this issue?
    
    `flutter clean` between `flutter test` runs (if `--flavor` is being used and any tests depend on the flavor-conditional asset bundling feature).
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    Attempt to repro with [these steps](#150296 (comment)) provided by the original issue reporter.
    flutteractionsbot authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    37c6548 View commit details
    Browse the repository at this point in the history
  3. [CP] Fix Linux numpad shortcuts on web (#150723)

    Cherry pick request of #148988 to stable.
    
    Fixes an issue on Web+Linux that prevents users from inputting data using the numpad.
    m3c-fnicola authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0054d43 View commit details
    Browse the repository at this point in the history
  4. [CP-stable][tool] make ErrorHandlingFileSystem.deleteIfExists catch…

    … error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (#150787)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    #150736
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
    
    Fixes some CLI tool crashes due to trying to delete a file that no longer exists.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    When running certain commands, such as `flutter run` or `flutter build`, users get a lengthy crash message including the full contents of a FileSystemException. 
    
    ### Workaround:
    Is there a workaround for this issue?
    
    Attempt to run the command again, or try again after running `flutter clean`.
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    N/A. This issue is due to races within the user's file system (a file getting deleted or quarantined after being confirmed to exist but before the tool could delete it.
    flutteractionsbot authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    3e81a1d View commit details
    Browse the repository at this point in the history
  5. [CP-stable] Upgrade dependency on package:unified_analytics from 5.8.…

    …8+1 to 5.8.8+2 (#151046)
    
    Resolves #150137 (the issue is already resolved in master with the use of package:unified_analytics:6.1.2).
    
    Patches the fixes from [unified_analytics:5.8.8+2](dart-lang/tools#280) to stable.
    andrewkolos authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    754bbba View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    b0850be View commit details
    Browse the repository at this point in the history
Loading