-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 761747b
head repository: flutter/flutter
compare: b0850be
- 6 commits
- 11 files changed
- 5 contributors
Commits on Jul 1, 2024
-
[CP] Point kotlin message in
gradle_errors.darttowards new place (#…Configuration menu - View commit details
-
Copy full SHA for 855aab9 - Browse repository at this point
Copy the full SHA 855aab9View commit details -
[CP-stable][CLI tool] in
flutter test, consider--flavorwhen val……idating the cached asset bundle (#150617) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #150296 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. Fixed bug in `flutter test` where `--flavor` wasn't considered when validating cached [assets](https://docs.flutter.dev/ui/assets/assets-and-images), causing the [flavor-conditional asset bundling](https://docs.flutter.dev/deployment/flavors#conditionally-bundling-assets-based-on-flavor) feature to not work as expected. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) For users of flavor-conditional asset bundling that used `--flavor` in `flutter test`, this could result in tests incorrectly passing or failing depending on which `--flavor` value they used since their last `flutter clean`. ### Workaround: Is there a workaround for this issue? `flutter clean` between `flutter test` runs (if `--flavor` is being used and any tests depend on the flavor-conditional asset bundling feature). ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Attempt to repro with [these steps](#150296 (comment)) provided by the original issue reporter.
Configuration menu - View commit details
-
Copy full SHA for 37c6548 - Browse repository at this point
Copy the full SHA 37c6548View commit details -
[CP] Fix Linux numpad shortcuts on web (#150723)
Cherry pick request of #148988 to stable. Fixes an issue on Web+Linux that prevents users from inputting data using the numpad.
Configuration menu - View commit details
-
Copy full SHA for 0054d43 - Browse repository at this point
Copy the full SHA 0054d43View commit details -
[CP-stable][tool] make
ErrorHandlingFileSystem.deleteIfExistscatch…… error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (#150787) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #150736 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes some CLI tool crashes due to trying to delete a file that no longer exists. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) When running certain commands, such as `flutter run` or `flutter build`, users get a lengthy crash message including the full contents of a FileSystemException. ### Workaround: Is there a workaround for this issue? Attempt to run the command again, or try again after running `flutter clean`. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A. This issue is due to races within the user's file system (a file getting deleted or quarantined after being confirmed to exist but before the tool could delete it.
Configuration menu - View commit details
-
Copy full SHA for 3e81a1d - Browse repository at this point
Copy the full SHA 3e81a1dView commit details -
[CP-stable] Upgrade dependency on package:unified_analytics from 5.8.…
…8+1 to 5.8.8+2 (#151046) Resolves #150137 (the issue is already resolved in master with the use of package:unified_analytics:6.1.2). Patches the fixes from [unified_analytics:5.8.8+2](dart-lang/tools#280) to stable.
Configuration menu - View commit details
-
Copy full SHA for 754bbba - Browse repository at this point
Copy the full SHA 754bbbaView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b0850be - Browse repository at this point
Copy the full SHA b0850beView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 761747b...b0850be