Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4336d5c
Choose a base ref
...
head repository: chrisbobbe/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 01553db
Choose a head ref
  • 8 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    2317eba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67fe798 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54c2a96 View commit details
    Browse the repository at this point in the history
  4. autocomplete [nfc]: Add get/set for RawAutocompleteController.options

    Currently trivial, but we'll add more here soon.
    chrisbobbe committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d3e1695 View commit details
    Browse the repository at this point in the history
  5. autocomplete [nfc]: Add get/set for highlightedOptionIndex

    And keep a [highlightedOptionIndexNotifier], since a caller needs
    that value.
    chrisbobbe committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ab28fda View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e24bec2 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. autocomplete [nfc]: Make RawAutocompleteController a ChangeNotifier

    Currently it doesn't have any listeners, but it will soon.
    chrisbobbe committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4be6bf4 View commit details
    Browse the repository at this point in the history
  2. wip RawAutocomplete: Let caller control options directly

    This isn't nearly ready for merge; it's just to demonstrate a
    direction that might be helpful for zulip/zulip-flutte#226, and
    perhaps also for:
      #123377 (comment)
    
    The idea (for zulip/zulip-flutte#226) is to move to a new class
    RawAutocompleteController the state value for the current list of
    autocomplete options. Then, to let RawAutocomplete's caller pass an
    instance of that class, giving the caller control over when that
    state gets updated. For us, that's better than accepting
    RawAutocomplete's old behavior, where a change in the
    TextEditingController was the only trigger for an update. (We want
    to trigger updates when our MentionAutocompleteView changes.)
    
    Ideally, we could add this capability to RawAutocomplete without
    removing any of its current API: maybe we could make the
    `controller` param optional, and I guess add asserts to try to
    prevent buggy mixtures of the old and this new opt-in behavior.
    Anyway, that that was way too tricky for this demo, so here I've
    just ripped out all the parts where RawAutocomplete did anything
    with the TextEditingController.
    
    I think our zulip/zulip-flutter#226 doesn't create a need to control
    the "selection" state, but that state is also moved to the
    RawAutocompleteController class anyway. Why?
    - Well, with RawAutocomplete being unaware of the text-input value,
      as mentioned in the previous paragraph, it can't listen for
      changes in that value, which it was doing before, to null out the
      selection state when the text changed. So, now we do that.
    - Also, I think there's a proposal for class like this
      RawAutocompleteController to contain the selection state:
        #123377 (comment)
      That comment would also have it include the highlighted state, I
      think (which the auther calls the "hovered" state). Since those
      are closely related to the options-list state, might as well
      put them there along with it.
    
    For this demo, I hacked down the Material `Autocomplete` widget so
    that zulip-flutter would build, and I haven't touched any of the
    Flutter framework tests.
    chrisbobbe committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    01553db View commit details
    Browse the repository at this point in the history
Loading