Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0fe6153
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f86b777
Choose a head ref
  • 16 commits
  • 37 files changed
  • 9 contributors

Commits on Oct 31, 2024

  1. Fix showSnackBar can't access useMaterial3 from the theme (#157707)

    ## Description
    
    This PR makes it possible for the `MaterialApp` built in `ScaffoldMessenger` state to access the ambient theme.
    
    Before this PR, the built in messenger was above the theme.
    After this PR, the build in messenger is below the theme.
    
    ## Related Issue
    
    Fixes [Can't access useMaterial3 from the theme in the showSnackBar method](#115924)
    
    ## Tests
    
    Adds 1 test.
    bleroux authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5f65bd0 View commit details
    Browse the repository at this point in the history
  2. Made insetPadding configurable for Date Picker Dialog (#155651)

    This PR adds following properties to the **DatePickerDialog**:
    - `insetPadding`
    sarbagyastha authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    19d8fbc View commit details
    Browse the repository at this point in the history
  3. [flutter_driver] use mostly public screenshot API. (#157888)

    Instead of completely private. This has been broken for Impeller for years, which shows how much this method is getting used.
    
    Fixes #130461
    Jonah Williams authored Oct 31, 2024
    1 Configuration menu
    Copy the full SHA
    1050959 View commit details
    Browse the repository at this point in the history
  4. Renames injectBuildTimePluginFilesForWebPlatform and removes unused…

    … named parameter. (#157944)
    
    Closes #157943.
    
    ---------
    
    Co-authored-by: Andrew Kolos <[email protected]>
    matanlurey and andrewkolos authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8d7513e View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) (#…

    …157960)
    
    flutter/engine@f2154ef...bb77cf8
    
    2024-10-31 [email protected] iOS: migrate Metal testing types to ARC (flutter/engine#56156)
    2024-10-31 [email protected] iOS,macOS: migrate shell/gpu to ARC (flutter/engine#56157)
    2024-10-31 [email protected] Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (flutter/engine#56272)
    2024-10-31 [email protected] [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56221)
    2024-10-31 [email protected] Add `timeout` to `local_engine`. (flutter/engine#56271)
    2024-10-31 [email protected] Refactor `ArgParser.usage` tests for `BuildPlan` to reduce duplication. (flutter/engine#56254)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    088e357 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Add a warning/additional handlers for parsingsynthetic-package. (#1…

    …57934)
    
    Closes #157928.
    Closes #157929.
    
    | Condition | Expectation |
    | --------- | ------------ |
    | `synthetic-packages: true` && `--implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
    | `<no synthetic-packages key>` && `--implicit-pubspec-resolution` | Generates `flutter_gen` with warning.
    | `synthetic-packages: false` && `--implicit-pubpsec-resolution` | Does not generate `flutter_gen`.
    | `synthetic-packages: true` && `--no-implicit-pubpsec-resolution` | Error.
    | `<no synthetic-packages key>` && `--no-implicit-pubspec-resolution` | Does not generate `flutter_gen`.
    | `synthetic-packages: false` && `--no-implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
    matanlurey authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d77d7c3 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) (#…

    …157972)
    
    flutter/engine@bb77cf8...cd46383
    
    2024-10-31 [email protected] reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286)
    2024-10-31 [email protected] Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283)
    2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224)" (flutter/engine#56285)
    2024-10-31 [email protected] macOS: migrate third_party/accessibility to ARC (flutter/engine#56281)
    2024-10-31 [email protected] Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224)
    2024-10-31 [email protected] [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247)
    2024-10-31 [email protected] [Impeller] make desktop GL render. (flutter/engine#56274)
    2024-10-31 [email protected] Vastly rewrite and expand `et/README.md` (flutter/engine#56250)
    2024-10-31 [email protected] Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280)
    2024-10-31 [email protected] Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278)
    2024-10-31 [email protected] Embedder: migrate Metal surfaces to ARC (flutter/engine#56279)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b18d34c View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) (#…

    …157978)
    
    flutter/engine@cd46383...d7e9289
    
    2024-11-01 [email protected] Further de-duplicate and refactor `build_plan_test`. (flutter/engine#56284)
    2024-11-01 [email protected] Roll Dart SDK from bd93105c4fb6 to 32bebf22c765 (2 revisions) (flutter/engine#56290)
    2024-11-01 [email protected] Remove the quiet flag from invocations of run_tests.py on macOS CI builders (flutter/engine#56288)
    2024-11-01 [email protected] [Impeller] Fix handling of destination opacity in advanced blends (flutter/engine#56251)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cadac6b View commit details
    Browse the repository at this point in the history
  4. performance: Override .elementAt in CachingIterable (#152477)

    Add a more efficient override of `Iterable.elementAt` in `CachingIterable`.
    
    Closes #152476
    plammens authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d836ca5 View commit details
    Browse the repository at this point in the history
  5. Add test for notification.0.dart (#157909)

    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/notification_listener/notification.0.dart`
    ValentinVignal authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    43bb618 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4f8ab5b View commit details
    Browse the repository at this point in the history
  7. Add test for interactive_viewer.transformation_controller.0.dart (#…

    …157986)
    
    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/interactive_viewer/interactive_viewer.transformation_controller.0.dart`
    ValentinVignal authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fd25971 View commit details
    Browse the repository at this point in the history
  8. Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) (#…

    …157991)
    
    flutter/engine@bacc5e1...0a0d5c9
    
    2024-11-01 [email protected] Roll Skia from 6035cb5a879c to 3b50199d27bb (1 revision) (flutter/engine#56300)
    2024-11-01 [email protected] Roll Skia from 696528fe7d07 to 6035cb5a879c (1 revision) (flutter/engine#56299)
    2024-11-01 [email protected] Roll Dart SDK from 32bebf22c765 to 09c8281e66cc (1 revision) (flutter/engine#56298)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3eb000c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2da2332 View commit details
    Browse the repository at this point in the history
  10. Marks Linux_pixel_7pro service_extensions_test to be flaky (#157853)

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Linux_pixel_7pro service_extensions_test"
    }
    -->
    Issue link: #157852
    fluttergithubbot authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f159136 View commit details
    Browse the repository at this point in the history
  11. Roll Packages from 7cc1caa to 796afa3 (15 revisions) (#158003)

    flutter/packages@7cc1caa...796afa3
    
    2024-11-01 [email protected] [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990)
    2024-11-01 [email protected] [various] Minor cleanup in recently imported packages (flutter/packages#7995)
    2024-11-01 [email protected] [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997)
    2024-10-31 [email protected] Manual roll Flutter from fe71cad to 0fe6153 (18 revisions) (flutter/packages#7989)
    2024-10-31 [email protected] [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991)
    2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986)
    2024-10-31 [email protected] [flutter_svg] Initial import (flutter/packages#7944)
    2024-10-31 [email protected] [vector_graphics] Initial import (flutter/packages#7941)
    2024-10-30 [email protected] [ci] Ensure repo tool is autoformatted (flutter/packages#7963)
    2024-10-30 [email protected] Updates path_parsing README.md with a note about Dan (flutter/packages#7949)
    2024-10-30 [email protected] [tool] Support third_party for --current-package (flutter/packages#7967)
    2024-10-30 [email protected] [tool] Fix third_party dependency overrides (flutter/packages#7966)
    2024-10-30 [email protected] Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822)
    2024-10-30 [email protected] [palette_generator] Remove unmanaged code snippet (flutter/packages#7962)
    2024-10-30 [email protected] Roll Flutter from 42132e8 to fe71cad (12 revisions) (flutter/packages#7961)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f86b777 View commit details
    Browse the repository at this point in the history
Loading