Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 08e26a3
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e64ee5d
Choose a head ref
  • 20 commits
  • 41 files changed
  • 14 contributors

Commits on Nov 28, 2024

  1. Roll Packages from e6932b7 to bc0c22d (2 revisions) (#159592)

    flutter/packages@e6932b7...bc0c22d
    
    2024-11-27 [email protected]
    [image_picker_android] Refactor interactions with ContentProvider
    provided filenames (flutter/packages#8188)
    2024-11-27 [email protected]
    [file_selector_android] Refactor interactions with `ContentProvider`
    provided filenames (flutter/packages#8184)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    81fad61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc0b62a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. improve ContainerRenderObjectMixin error message when parentData

    …is not set up properly (#157846)
    
    Previously when subclassing `MultiChildRenderObjectWidget` and
    `RenderObject with ContainerRenderObjectMixin`, if one forgot to set up
    parent data, the error message does not give hint that `setupParentData`
    need to be implemented by the `RenderObject`.
    
    This PR add assertion that check parent data type before type cast and
    give hints if it is was not properly set.
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    PurplePolyhedron authored Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a0ba2de View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Roll Flutter Engine from d7be573a5ee5 to 1f6312df6d75 (1 revision) (#…

    …159676)
    
    flutter/engine@d7be573...1f6312d
    
    2024-11-29 [email protected] Roll Fuchsia Linux SDK from
    oJzuSXcrUmaw5Ck2g... to pc49rc4B22IXqigQ-... (flutter/engine#56876)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from oJzuSXcrUmaw to pc49rc4B22IX
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2d2cc5d View commit details
    Browse the repository at this point in the history
  2. iPad Scribble flicker and crash (#159508)

    Previously, dragging to select with an Apple Pencil on an iPad
    (Scribble) caused the context menu to rapidly hide and show. Sometimes
    this even caused an assertion error when using SystemContextMenu due to
    showing two context menus in one frame. After this PR, the flicker and
    crash are gone.
    
    The flicker happened on both the Flutter-rendered context menu and
    SystemContextMenu, but the error only happened with SystemContextMenu
    due to a safeguard that prevents two from showing at the same time.
    
    The flickering is likely a regression caused by
    #142463.
    
    | Before this PR | After this PR |
    | --- | --- |
    | <video
    src="https://github.com/user-attachments/assets/e35f36f5-350d-41fb-b878-ee7b7820699d"
    /> | <video
    src="https://github.com/user-attachments/assets/262cb8d3-6670-4765-ace8-2d9bf61ae112"
    /> |
    
    Flutter's behavior isn't perfect compared to native (below), but it's a
    major improvement. If we want to match native, I think we might have to
    mess with the engine and see why it's calling showToolbar so much. I
    checked and scribbleInProgress is false during this selection gesture,
    so we can't use that.
    
    <details>
    
    <summary>Scribble native video</summary>
    
    
    
    https://github.com/user-attachments/assets/207e208a-ac36-4c9e-a8ed-9e90e6ef9e3a
    
    
    
    </details>
    
    
    Fixes #159259
    justinmc authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e7a8dc3 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 1f6312df6d75 to e0900f83a0c8 (3 revisions) (#…

    …159684)
    
    flutter/engine@1f6312d...e0900f8
    
    2024-12-02 [email protected] Roll Dart SDK from
    0740ded7b9bf to 5785058c9bb1 (5 revisions) (flutter/engine#56886)
    2024-12-02 [email protected] Roll Fuchsia Linux SDK from
    pc49rc4B22IXqigQ-... to j424tGVlulTUzBtPj... (flutter/engine#56889)
    2024-12-02 [email protected] Roll Skia from f149f852c70a to
    dd70c8e1c38f (4 revisions) (flutter/engine#56814)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from pc49rc4B22IX to j424tGVlulTU
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6a68c9b View commit details
    Browse the repository at this point in the history
  4. [tool] Removes deprecated --web-renderer parameter. (#159314)

    Removes the `--web-renderer` option.
    
    Flutter tool users won't be able to select their web renderer.
    
    In order to not drop test coverage, tests are still run with the HTML
    Renderer, until its code is fully removed from the engine.
    
    Part of #145954
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ditman authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    1e1b527 View commit details
    Browse the repository at this point in the history
  5. [ Tool ] Fix "Error: Unable to find git in your PATH" when Command Pr…

    …ocessor `AutoRun` registry key is defined (#159424)
    
    cmd.exe will read from the AutoRun registry key at launch and execute
    the commands listed in the key. Since `FOR /F IN (command) ...` causes a
    new terminal instance to start, the AutoRun commands will be run again,
    possibly changing the current working directory. In this case, the `git
    rev-parse HEAD` check run in `shared.bat` could fail, which we were
    assuming meant `git` was not on the user's PATH.
    
    This change ensures that `git rev-parse HEAD` will always run in
    %FLUTTER_ROOT% and explicitly adds a separate check for `git` using
    `WHERE git` to more accurately determine if `git` is on the PATH.
    
    Fixes #159018
    
    ---------
    
    Co-authored-by: Andrew Kolos <[email protected]>
    bkonyi and andrewkolos authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bc4fc5f View commit details
    Browse the repository at this point in the history
  6. Fix output path for --appSizeBase (#158302)

    Fixes #158211
    
    before
    
    ```shell
    A summary of your APK analysis can be found at: /Users/lxf/.flutter-devtools/apk-code-size-analysis_01.json
    
    To analyze your app size in Dart DevTools, run the following command:
    dart devtools --appSizeBase=apk-code-size-analysis_01.json
    ```
    
    now
    
    ```shell
    A summary of your APK analysis can be found at: /Users/lxf/.flutter-devtools/apk-code-size-analysis_01.json
    
    To analyze your app size in Dart DevTools, run the following command:
    dart devtools --appSizeBase=/Users/lxf/.flutter-devtools/apk-code-size-analysis_01.json
    ```
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    Co-authored-by: Kenzie Davisson <[email protected]>
    LinXunFeng and kenzieschmoll authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6b5cd01 View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from e0900f83a0c8 to 05fdaa6edc12 (9 revisions) (#…

    …159694)
    
    flutter/engine@e0900f8...05fdaa6
    
    2024-12-02 [email protected] Roll Skia from d7751d3d6ff4 to
    2c4ce1d953ba (5 revisions) (flutter/engine#56901)
    2024-12-02 [email protected] [ci] use env for format and support
    arm64 hosts (flutter/engine#56268)
    2024-12-02 [email protected] Replace outdated wiki URLs in pull
    request template (flutter/engine#56824)
    2024-12-02 [email protected] [impeller] makes
    UniformBindData 15% faster and adds unit test (flutter/engine#56844)
    2024-12-02 [email protected] Roll Skia from dd70c8e1c38f to
    d7751d3d6ff4 (36 revisions) (flutter/engine#56898)
    2024-12-02 [email protected] Roll Dart SDK from
    5785058c9bb1 to 46630dbefbbd (12 revisions) (flutter/engine#56897)
    2024-12-02 [email protected] switched reactor
    to absl::flat_hash_map (flutter/engine#56845)
    2024-12-02 [email protected] Sped up
    SubpixelGlyph::Equal (flutter/engine#56851)
    2024-12-02 [email protected] [Impeller] dont cache glyph layout
    if atlas is invalid. (flutter/engine#56879)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    41937cb View commit details
    Browse the repository at this point in the history
  8. Ignore exhaustiveness check for some semantics tests, for now (#159517)

    ~This also includes the engine hash change from
    https://github.com/flutter/flutter/pull/159453/files for testing
    purposes. Will revert if all tests pass~ all tests passed with the
    engine hash from #159453:
    0f26acb
    
    TODOs: #159515
    context: #159456
    
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    LongCatIsLooong authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    1e67f6c View commit details
    Browse the repository at this point in the history
  9. doc/improve-hint-text-doc (#156313)

    This PR improve the Flutter documentation about the Textfield.hintText
    property. On our e-commerce app, Samsung pass was not working and we
    discovered that, after using hintText : Samsung pass autofill was
    working perfectly.
    
    Example (that can help) : 
    ```dart
     TextFormField(
       autofillHints: const <String>[
        // Order is important, username must be first
         AutofillHints.username,
         AutofillHints.email,
       ],
       keyboardType: TextInputType.emailAddress,
       decoration: InputDecoration(
         hintText: "What do you want, it doesn't matter but it's important to use it",
      ),
     ),
     ...
     TextFormField(
       autofillHints: const <String>[AutofillHints.password],    
       obscureText: true,
       keyboardType: TextInputType.visiblePassword,
       decoration: InputDecoration(
         hintText: "What do you want, it doesn't matter but it's important to use it",
       ),
     ),
    ```
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    Co-authored-by: Enguerrand ARMINJON WINDOWS <[email protected]>
    EArminjon and Enguerrand ARMINJON WINDOWS authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0917d0d View commit details
    Browse the repository at this point in the history
  10. Marks Linux build_tests_4_5 to be unflaky (#154994)

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Linux build_tests_4_5"
    }
    -->
    The test has been passing for [50 consecutive
    runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_4_5%22).
    This test can be marked as unflaky.
    fluttergithubbot authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c055976 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Roll Flutter Engine from 05fdaa6edc12 to 5001e2a490db (6 revisions) (#…

    …159702)
    
    flutter/engine@05fdaa6...5001e2a
    
    2024-12-02 [email protected] Roll Skia from ac934b9e9df9 to
    3db026d62805 (2 revisions) (flutter/engine#56908)
    2024-12-02 [email protected] Roll Dart SDK from
    46630dbefbbd to c579d193341d (1 revision) (flutter/engine#56907)
    2024-12-02 [email protected] Reland
    "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56842)
    2024-12-02 [email protected] Always check for errors when
    propagating task values. (flutter/engine#56856)
    2024-12-02 [email protected] Roll Skia from 2c4ce1d953ba to
    ac934b9e9df9 (1 revision) (flutter/engine#56904)
    2024-12-02 [email protected] Fix linux on
    vivante drivers. (flutter/engine#56862)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6fe5363 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 5001e2a490db to 349ad277b574 (4 revisions) (#…

    …159706)
    
    flutter/engine@5001e2a...349ad27
    
    2024-12-03 [email protected] [Impeller] set GLES viewport once,
    remove extra unbind/validation. (flutter/engine#56902)
    2024-12-03 [email protected] Make a mock messenger that can
    easily mock channels (flutter/engine#56867)
    2024-12-03 [email protected] Manual roll Dart SDK from
    c579d193341d to 61bfa9bbb91d (1 revision) (flutter/engine#56909)
    2024-12-03 [email protected] Fix GTask reference counting
    (flutter/engine#56866)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b2357d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f66f6a7 View commit details
    Browse the repository at this point in the history
  4. Fix DropdownMenu menu is detached from the text field (#159665)

    ## Description
    
    This PR fixes `DropdownMenu` menu vertical position when tight
    constraints are given to the `DropdownMenu`.
    
    Before:
    
    
    ![image](https://github.com/user-attachments/assets/d8d9b857-07ed-4d3c-afe2-44518d979e66)
    
    After:
    
    
    ![image](https://github.com/user-attachments/assets/a71ea3c8-a408-43a1-8c99-c2612ad4b24b)
    
    
    
    ## Related Issue
    
    Fixes [DropdownMenu does not correctly handle incoming maxWidth and
    minHeight
    constraints](#147076).
    (It fixes the minHeight part, the maxWidth part was already fixed in
    #147233).
    
    ## Tests
    
    Adds 4 tests.
    bleroux authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    11fa41e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    65464a9 View commit details
    Browse the repository at this point in the history
  6. Make native asset tests more robust against flutter upgrading its pin…

    …ned dependencies (#159715)
    
    Native asset tests use `flutter create --no-pub --template=package_ffi`.
    The template used for this is checked in. It then adds extra
    dependencies to checked-in packages in flutter/flutter (which have
    pinned deps) in those generated templates.
    
    It then pins all dependencies in the modified template project. This can
    lead to constraint violations when flutter updates pinned dependencies,
    because the template uses old constraints (which are turned from `^x` to
    `=x`) and the additional dependency on flutter/flutter checked in
    package brings in different pinned dependencies.
    
    In a previous PR we already made this more robust by using flutter's
    pinned versions over the the versions from the template (that are
    changed from `^x` to `=x`).
    
    Though a new upgrade of flutters pinned packages reveals that this isn't
    quite sufficient: The template uses `test` at `^X`. The additional
    dependency to `link_hook` doesn't depend on `test`. It therefore turns
    it into `=X`. BUT `link_hooks` has a non-dev dependency on `test_core`
    which is incompatible with `=X`.
    
    => So we relax this even more by prefering to choose (pinned) versions
    of the flutter/flutter `link_hook` dependencies and (new) dev
    dependencies over the template dependencies.
    => This will make use use the pinned `test` version from `link_hooks`
    instead of from the template.
    mkustermann authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    227f6a0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e64ee5d View commit details
    Browse the repository at this point in the history
Loading