Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fe71cadf1959
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0fe615343bd9
Choose a head ref
  • 18 commits
  • 92 files changed
  • 10 contributors

Commits on Oct 30, 2024

  1. Mention partial PRs in the contributing docs (#157863)

    Adds a small new subsection to the section on contributing via coding that highlights the list of issues with partial patches that could be picked up by another contributor.
    stuartmorgan-g authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d372385 View commit details
    Browse the repository at this point in the history
  2. Roll Packages from 028027e to 7cc1caa (5 revisions) (#157864)

    flutter/packages@028027e...7cc1caa
    
    2024-10-30 [email protected] [tool] Update build-all app creation (flutter/packages#7955)
    2024-10-30 [email protected] Disable two lint rules which are being removed. (flutter/packages#7959)
    2024-10-29 [email protected] Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935)
    2024-10-29 [email protected] Roll Flutter from 3fb95c7 to 42132e8 (19 revisions) (flutter/packages#7958)
    2024-10-29 [email protected] [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e10d1de View commit details
    Browse the repository at this point in the history
  3. Add hidden --no-implicit-pubspec-resolution flag for one stable rel…

    …ease. (#157635)
    
    Closes #157532.
    
    Work towards #157819.
    
    Because this flag is checked in `FlutterCommand.verifyAndRun`, it seemed cleaner to just make it a global flag - particularly because this flag's longevity is unlikely to be longer than a single stable release.
    matanlurey authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e6c9fce View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) (#…

    …157833)
    
    flutter/engine@999797a...57ed5d3
    
    2024-10-29 [email protected] [Flutter GPU] Fix MSAA sample size and HostBuffer alignment. (flutter/engine#56218)
    2024-10-29 [email protected] Change default TileMode for blur ImageFilter objects to null (flutter/engine#55552)
    2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#56213)" (flutter/engine#56220)
    2024-10-29 [email protected] Made et compilation errors relative to the CWD (flutter/engine#56177)
    2024-10-29 [email protected] [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56213)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cf4a4b8 View commit details
    Browse the repository at this point in the history
  5. Update Material 3 LinearProgressIndicator for new visual style (#15…

    …4817)
    
    Related to [Update both `ProgressIndicator` for Material 3 redesign](#141340)
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatefulWidget {
      const MyApp({super.key});
    
      @OverRide
      State<MyApp> createState() => _MyAppState();
    }
    
    class _MyAppState extends State<MyApp> {
      bool isRTL = false;
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          debugShowCheckedModeBanner: false,
          home: Scaffold(
    
            body: Directionality(
              textDirection: isRTL ? TextDirection.rtl : TextDirection.ltr,
              child: Center(
                child: Column(
                  spacing: 2.0,
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    const Text('Default LinearProgressIndicator'),
                    const Padding(
                      padding: EdgeInsets.all(16.0),
                      child: LinearProgressIndicator(
                        value: 0.45,
                      ),
                    ),
                    const Text('Default indefinite LinearProgressIndicator'),
                    const Padding(
                      padding: EdgeInsets.all(16.0),
                      child: LinearProgressIndicator(),
                    ),
                    const Text('Updated height and border radius'),
                    Padding(
                      padding: const EdgeInsets.all(16.0),
                      child: LinearProgressIndicator(
                        value: 0.25,
                        minHeight: 16.0,
                        borderRadius: BorderRadius.circular(16.0),
                      ),
                    ),
                    const Text('Updated stop indicator color and radius'),
                    Padding(
                      padding: const EdgeInsets.all(16.0),
                      child: LinearProgressIndicator(
                        value: 0.74,
                        minHeight: 16.0,
                        borderRadius: BorderRadius.circular(16.0),
                        stopIndicatorColor: Theme.of(context).colorScheme.error,
                        stopIndicatorRadius: 32.0,
                      ),
                    ),
                    const Text('Track gap and stop indicator radius set to 0'),
                    Padding(
                      padding: const EdgeInsets.all(16.0),
                      child: LinearProgressIndicator(
                        value: 0.50,
                        minHeight: 16.0,
                        borderRadius: BorderRadius.circular(16.0),
                        trackGap: 0,
                        stopIndicatorRadius: 0,
                      ),
                    ),
                  ],
                ),
              ),
            ),
            floatingActionButton: FloatingActionButton.extended(
              onPressed: () {
                setState(() {
                  isRTL = !isRTL;
                });
              },
              label:  const Text('Toggle Direction'),
            ),
          ),
        );
      }
    }
    ```
    
    </details>
    
    ### Preview
    
    <img width="824" alt="Screenshot 2024-09-09 at 13 53 10" src="https://github.com/user-attachments/assets/d12e56a5-f196-4011-8266-c7ab96be96b2">
    TahaTesser authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b8dcb0c View commit details
    Browse the repository at this point in the history
  6. Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) (#…

    …157875)
    
    flutter/engine@57ed5d3...906a7ad
    
    2024-10-30 [email protected] Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237)
    2024-10-30 [email protected] Roll Skia from 948b01e28f48 to 03600bc22ab8 (1 revision) (flutter/engine#56236)
    2024-10-30 [email protected] Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235)
    2024-10-30 [email protected] Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231)
    2024-10-30 [email protected] Roll Skia from 5410f1c6f86c to 1a47627e627a (1 revision) (flutter/engine#56230)
    2024-10-30 [email protected] Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229)
    2024-10-30 [email protected] iOS: make unopt debug builds unopt and debug (flutter/engine#56226)
    2024-10-30 [email protected] Roll Skia from 7385b2d99fe9 to 5410f1c6f86c (1 revision) (flutter/engine#56227)
    2024-10-30 [email protected] Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225)
    2024-10-30 [email protected] Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222)
    2024-10-29 [email protected] Roll buildroot to 3f1a1f0. (flutter/engine#56214)
    2024-10-29 [email protected] [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187)
    2024-10-29 [email protected] Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cb7861c View commit details
    Browse the repository at this point in the history
  7. Upgrade templates to AGP 8.7/Gradle 8.10.2 (#157872)

    These are the versions we use in test, as of #157617.
    
    Motivated by noticing a warning with the old template version:
    ```
    This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
    You are strongly encouraged to update your project to use a newer
    Android Gradle plugin that has been tested with compileSdk = 35.
    ```
    gmackall authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    55c026a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bb08ec9 View commit details
    Browse the repository at this point in the history
  9. Fix GlowingOverscrollIndicator examples (#155203)

    Part of #130459
    
    This pull request adds tests for the example files shown in the [GlowingOverscrollIndicator](https://api.flutter.dev/flutter/widgets/GlowingOverscrollIndicator-class.html) Flutter API reference documentation.
    miechoo authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2d2ebbe View commit details
    Browse the repository at this point in the history
  10. Adds a new helpful tool exit message for SocketExceptions thrown duri…

    …ng mdns discovery (#157638)
    
    Addresses #150131, but doesn't fix it, as there seem to be cases where the steps included in the messages added in this PR don't work.
    LouiseHsu authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ec04707 View commit details
    Browse the repository at this point in the history
  11. Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) (#…

    …157882)
    
    flutter/engine@2bd854e...9295eeb
    
    2024-10-30 [email protected] Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243)
    2024-10-30 [email protected] [engine] add back opt out for merged thread mode. (flutter/engine#56242)
    2024-10-30 [email protected] [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223)
    2024-10-30 [email protected] Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241)
    2024-10-30 [email protected] Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from zuDYsDZHnJMZ to dDWvmfG4AxSE
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    939fd61 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) (#…

    …157893)
    
    flutter/engine@9295eeb...090c33a
    
    2024-10-30 [email protected] Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) (flutter/engine#56248)
    2024-10-30 [email protected] Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) (flutter/engine#56246)
    2024-10-30 [email protected] Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) (flutter/engine#56245)
    2024-10-30 [email protected] Add and use `mergeGnArgs` with `--gn-args` from `et`. (flutter/engine#56228)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b0e84af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6aaa387 View commit details
    Browse the repository at this point in the history
  3. Add and plumb useImplicitPubspecResolution across flutter_tools. (#…

    …157879)
    
    Work towards #157819. **No behavior changes as a result of this PR**.
    
    Based on a proof of concept by @jonahwilliams (#157818).
    
    The existence of this flag (which for the time being, defaults to `true`) implies the following:
    
    1. The (legacy, deprecated) `.flutter-plugins` file is not generated:
        https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration
        
    2. The (legacy, deprecated) `package:flutter_gen` is not synthetically generated:
        flutter/website#11343
        (awaiting website approvers, but owners approve this change)
    
    This change creates `useImplicitPubspecResolution` and plumbs it through as a required variable, parsing it from a `FlutterCommand.globalResults` where able. In tests, I've defaulted the value to `true` 100% of the time - except for places where the value itself is acted on directly, in which case there are true and false test-cases (e.g. localization and i10n based classes and functions).
    
    I'm not extremely happy this needed to change 50+ files, but is sort of a result of how inter-connected many of the elements of the tools are. I believe keeping this as an explicit (flagged) argument will be our best way to ensure the default behavior changes consistently and that tests are running as expected.
    matanlurey authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fb02229 View commit details
    Browse the repository at this point in the history
  4. Add test for media_query_data.system_gesture_insets.0.dart (#157854)

    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/media_query/media_query_data.system_gesture_insets.0.dart`
    ValentinVignal authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    16622e6 View commit details
    Browse the repository at this point in the history
  5. Fix cursor on hover expand/collapse icon (#155207) (#155209)

    @TahaTesser Fix undesirable side effects of your refactor away from my solution to add `IgnorePointer` during your code review of my PR #147098. I don't have time to implement my whole initial fix a second time, and update the tests that were added to verify your disabled color change. The issue is resolved with only adding the IgnorePointer.
    
    See [155207](#155207).
    benji-farquhar authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b01558c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b2f72e0 View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from c40b0b602822 to f2154ef3e31c (8 revisions) (#…

    …157926)
    
    flutter/engine@c40b0b6...f2154ef
    
    2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Skwasm single threaded (#56206)" (flutter/engine#56264)
    2024-10-31 [email protected] Roll Skia from 4f8f2ecadfb6 to 3c628426f85f (1 revision) (flutter/engine#56261)
    2024-10-31 [email protected] Roll Skia from 7e79a516284b to 4f8f2ecadfb6 (1 revision) (flutter/engine#56255)
    2024-10-31 [email protected] Roll Dart SDK from 6a8058eef22c to f3e3dc44b1dc (1 revision) (flutter/engine#56253)
    2024-10-31 [email protected] Roll Skia from 3c62d4a94d78 to 7e79a516284b (1 revision) (flutter/engine#56252)
    2024-10-31 [email protected] [Impeller] use primitive restart for faster tessellation: write directly into host buffer. (flutter/engine#56173)
    2024-10-31 [email protected] Skwasm single threaded (flutter/engine#56206)
    2024-10-31 [email protected] [Impeller] expose reference to tessellator instead of shared_ptr. (flutter/engine#56244)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0fe6153 View commit details
    Browse the repository at this point in the history
Loading