Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fe0275f9d5a7
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ad200896cbe1
Choose a head ref
  • 10 commits
  • 10 files changed
  • 4 contributors

Commits on Oct 5, 2023

  1. Roll Packages from d654f75 to 6714d50 (3 revisions) (#136039) 

    flutter/packages@d654f75...6714d50

2023-10-04 [email protected] [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 [email protected] [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 [email protected] [flutter_markdown] Footnote support (flutter/packages#5058)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5934c9f View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from f8d53c5fe9f2 to ad83202a59a6 (2 revisions) (#… 

    …136040)

flutter/engine@f8d53c5...ad83202

2023-10-05 [email protected] Replace use of Skia's Base64 Encoding/Decoding logic with a copy of the equivalent code (flutter/engine#46543)
2023-10-05 [email protected] Roll Skia from 2be211c972d5 to 09c71755bc6c (1 revision) (flutter/engine#46584)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    83b4919 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from ad83202a59a6 to 0ff05464f42f (1 revision) (#… 

    …136047)

flutter/engine@ad83202...0ff0546

2023-10-05 [email protected] Roll Skia from 09c71755bc6c to 0f2af25f15ee (2 revisions) (flutter/engine#46586)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    53333d0 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 0ff05464f42f to 27a674466094 (1 revision) (#… 

    …136050)

flutter/engine@0ff0546...27a6744

2023-10-05 [email protected] Roll Fuchsia Mac SDK from -RGP9v0n9shWn5yg1... to th0Ks2IEZYh6fe8G5... (flutter/engine#46593)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from -RGP9v0n9shW to th0Ks2IEZYh6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    32bd280 View commit details
    Browse the repository at this point in the history

  5. Upload frame_request_pending_latency [attempt #2] (#135890) 

    These values are generated since #135279, but I didn't know to add the new keys to this list to get them to upload. 

Failed to do so in #135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets.

Part of #129150
    @moffatman
    moffatman authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2925525 View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 27a674466094 to 6492e1f8c315 (1 revision) (#… 

    …136052)

flutter/engine@27a6744...6492e1f

2023-10-05 [email protected] Roll Fuchsia Linux SDK from bnd4FFub2R9Q4mlAC... to eI_FBTaRgvoBQaK5n... (flutter/engine#46599)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from bnd4FFub2R9Q to eI_FBTaRgvoB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    bf1cdb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Tiny improve code style by using records instead of lists (#135886)

    @fzyzcjy
    fzyzcjy authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7b0293d View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 6492e1f8c315 to cc9bc9e2c0d3 (1 revision) (#… 

    …136062)

flutter/engine@6492e1f...cc9bc9e

2023-10-06 [email protected] Roll Fuchsia Mac SDK from th0Ks2IEZYh6fe8G5... to 14dOVccxXOO5RPJJB... (flutter/engine#46611)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from th0Ks2IEZYh6 to 14dOVccxXOO5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    670e6ba View commit details
    Browse the repository at this point in the history

  3. Fix memory leaks in DateRangePickerDialog. (#136034) 

    This PR mainly fixes several memory leaks in the `DateRangePickerDialog`.

### Description
- Fixes #136033 by:
    1) adding a disposal of several `RestorableValue`;
    2) creating a separate `_DayItem` stateful widget that creates/updates/disposes internal `MaterialStatesController`.
- Marks #136036.

### Tests
- Updates `test/material/date_picker_theme_test.dart` to use `testWidgetsWithLeakTracking`;
- Updates `test/material/date_range_picker_test.dart` to use `testWidgetsWithLeakTracking`.
    @ksokolovskyi
    ksokolovskyi authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d76e3ab View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from cc9bc9e2c0d3 to 59b6b94e1a51 (1 revision) (#… 

    …136066)

flutter/engine@cc9bc9e...59b6b94

2023-10-06 [email protected] Roll Fuchsia Linux SDK from eI_FBTaRgvoBQaK5n... to K7K76tME-CSGhYlFm... (flutter/engine#46614)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from eI_FBTaRgvoB to K7K76tME-CSG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ad20089 View commit details
    Browse the repository at this point in the history
Loading