Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fcfb4f203eae
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 80e556c0432f
Choose a head ref
  • 5 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 1, 2026

  1. Configuration menu
    Copy the full SHA
    418d48f View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2026

  1. Configuration menu
    Copy the full SHA
    ef74a07 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from f5215e74aa16 to e5ad3868b8db (3 revisions) (#195779)

    engine-flutter-autoroll authored Nov 2, 2026
    Configuration menu
    Copy the full SHA
    6d4ace8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    091f11f View commit details
    Browse the repository at this point in the history
  4. [web] Unskip web tests that pass on CanvasKit and Skwasm: platform_vi…

    …ew_test, route_notification_messages_test (#195605)
    
    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    Removes the unexplained file-level `@TestOn('!chrome')` annotations from
    two widget test files so they also run on the web:
    
    - `packages/flutter/test/widgets/platform_view_test.dart`: 105 tests
    across `AndroidView`, `UiKitView`, `AppKitView`, and common
    `PlatformView` behaviors pass on Chrome under both CanvasKit (dart2js)
    and Skwasm (dart2wasm). The `HtmlElementView can be instantiated` test
    specifically asserts that `HtmlElementView` throws `UnimplementedError`
    on non-web platforms, so it is narrowed to `skip: kIsWeb` with an
    `[intended]` reason comment.
    - `packages/flutter/test/widgets/route_notification_messages_test.dart`:
    all 5 route notification message tests pass on Chrome under both
    CanvasKit and Skwasm.
    
    Keeping the entire files skipped hid any web regressions in these tests.
    
    No tracking issue: neither `@TestOn('!chrome')` annotation pointed to an
    issue, and this is a test-only change.
    
    ## Where to focus
    
    - **Key Architectural Decisions**: None (mechanical test unskip).
    - **Non-Obvious Logic**: In
    `packages/flutter/test/widgets/platform_view_test.dart`, the final test
    (`HtmlElementView can be instantiated`) verifies that `HtmlElementView`
    throws `UnimplementedError` when instantiated on non-web platforms; that
    single test retains `skip: kIsWeb` rather than skipping the entire 100+
    test file.
    - **Primary Review Files**:
      - `packages/flutter/test/widgets/platform_view_test.dart`
    - `packages/flutter/test/widgets/route_notification_messages_test.dart`
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant in-code documentation (doc comments with
    `///`).
    - [ ] If this PR introduces a new feature or capability, I created and
    linked a website documentation issue or PR in [flutter/website] (or
    verified none is needed).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [flutter/website]: https://github.com/flutter/website
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    harryterkelsen authored Nov 2, 2026
    Configuration menu
    Copy the full SHA
    80e556c View commit details
    Browse the repository at this point in the history
Loading