-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: fc19ecfc585a
head repository: flutter/flutter
compare: 32081aab69f8
- 9 commits
- 14 files changed
- 7 contributors
Commits on Jun 7, 2024
-
Reverts "Fix
SegmentedButtonclipping when drawing segments (#149739)……" (#149927) Reverts: #149739 Initiated by: QuncCccccc Reason for reverting: the newly-added unit test might cause the red tree Original PR Author: TahaTesser Reviewed By: {QuncCccccc} This change reverts the following previous change: fixes [`SegmentedButton` doesn't clip properly when one of the segments has `ColorFiltered`](#144990) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Center( child: SegmentedButton<int>( segments: const <ButtonSegment<int>>[ ButtonSegment<int>( value: 0, label: ColorFiltered( colorFilter: ColorFilter.mode(Colors.amber, BlendMode.colorBurn), child: Text('Option 1'), ), ), ButtonSegment<int>( value: 1, label: Text('Option 2'), ), ], onSelectionChanged: (Set<int> selected) {}, selected: const <int>{0}, ), ), ), ); } } ``` </details> ### Before  ### After 
Configuration menu - View commit details
-
Copy full SHA for b5697a0 - Browse repository at this point
Copy the full SHA b5697a0View commit details -
Revert "Identify and re-throw our dependency checking errors in `flut…
Configuration menu - View commit details
-
Copy full SHA for 15307a9 - Browse repository at this point
Copy the full SHA 15307a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bdebcf - Browse repository at this point
Copy the full SHA 6bdebcfView commit details -
A sliver that remains �pinned� to the top of the scroll view. Subsequent slivers scroll behind it. Typically the sliver is created as the first item in the list however it can be inserted anywhere and it will always stop at the top of the scroll view. When the scrolling axis is vertical, the PinnedHeaderSliver�s height is defined by its widget child. Multiple PinnedHeaderSlivers will layout one after the other, once they've scrolled to the top. This sliver is preferable to the general purpose SliverPersistentHeader - for its relatively narrow use case - because there's no need to create a [SliverPersistentHeaderDelegate] or to predict the header's size. Here's a [working demo in DartPad](https://dartpad.dev/?id=3b3f24c14fa201f752407a21ca9c9456). https://github.com/flutter/flutter/assets/1377460/943f2e02-8e73-48b7-90be-61168978ff71 Related sliver utility PRs: #143538, #143325, #127340.
Configuration menu - View commit details
-
Copy full SHA for 9ce0a9e - Browse repository at this point
Copy the full SHA 9ce0a9eView commit details -
Remove zanderso from TESTOWNERS (#149935)
Instead I've added @andrewkolos for tools tests and @jtmcdole for engine tests. This doesn't mean you have to investigate and solve the issues filed by the flake bot. Instead, an assignee is just the mechanism used by the flake bot to ensure that the issues are triaged at the appropriate team triage meetings. FYI @christopherfujino
Configuration menu - View commit details
-
Copy full SHA for 47560fa - Browse repository at this point
Copy the full SHA 47560faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 034c0d0 - Browse repository at this point
Copy the full SHA 034c0d0View commit details
Commits on Jun 8, 2024
-
Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (#…
…149944) flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f634098 - Browse repository at this point
Copy the full SHA f634098View commit details -
Reverts "Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 re…
…visions) (#149944)" (#149960) Reverts: #149944 Initiated by: jason-simmons Reason for reverting: Regression affecting `integration_test/test/web_extension_test.dart` ``` PathNotFoundException: Cannot open file, path = '/chromium/canvaskit.wasm' (OS Error: No such file or directory, errno = 2) ``` (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745735238400976001/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_1_5/stdout) It looks like the p Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f380842 - Browse repository at this point
Copy the full SHA f380842View commit details -
[CupertinoActionSheet] Match colors to native (#149568)
This PR matches the various colors of `CupertinoActionSheet` more closely with the native one. The following colors are changed. * Sheet background color * Pressed button color * Cancel button color * Pressed cancel button color * Divider color * Content text color The resulting colors match with native one with deviation of at most 1 (in terms of 0~255 RGB). The following are comparison (left to right: Native, Flutter after PR, Flutter current) <img width="1295" alt="image" src="https://github.com/flutter/flutter/assets/1596656/3703a4a8-a856-42b1-9395-a6e14b1881ca"> <img width="1268" alt="image" src="https://github.com/flutter/flutter/assets/1596656/1eb9964e-41f1-414a-99ae-0a2e7da8d3fd"> _Note: The divider thickness is adjusted to `1/dpr` instead of 0.3 in both Flutter version to make them look more native, as will be proposed in #149636 ### Derivation All the colors are derived through color picker and calculation. The algorithm is as followed: * Assume all colors are translucent grey colors, i.e. having the same value `x` for R, G, and B, with an alpha `a`. * Given the barrier color is `x_B1=0` when the background is black, and `x_B2=204` when the background is white. * Pick the target color `x_t1` when the background is black, and `x_t2` when the background is white * Solve the following equations for `x` and `a` ``` a * x + (1-a) * x_B1 = x_t1 a * x + (1-a) * x_B2 = x_t2 a = 1 - (x_t1 - x_t2) / (x_B1 - x_B2) x = (x_t1 - (1-a) * x_B1) / a ``` These equations use a linear model for color composition, which might not be exact, but is close enough for an accuracy of (1/255). The full table is as follows: <img width="1091" alt="image" src="https://github.com/flutter/flutter/assets/1596656/0fb76291-c3cc-4bb5-aefa-03ac6ac9bf1f"> * The first two columns are colors picked from XCode. * The 3~4 columns are the colors picked from the current Flutter. Notice the deviation, which is sometimes drastic. * The 5~6 columns are the colors picked from Flutter after this PR. The deviation is at most 1. * The last few columns are calculation. * There are two rows whose calculation is based on adjusted numbers, since the original results are not accurate enough, possibly due to the linear composition. During the calculation, I assumed these colors vary between light and dark modes, but it turns out that both modes use the same set of colors. ### Screenshots
Configuration menu - View commit details
-
Copy full SHA for 32081aa - Browse repository at this point
Copy the full SHA 32081aaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff fc19ecfc585a...32081aab69f8