-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: fa402c8057a1
head repository: flutter/flutter
compare: ead6b0d17c89
- 14 commits
- 83 files changed
- 9 contributors
Commits on Sep 26, 2024
-
remove fujino from CODEOWNERS (#155369)
Every time someone tries to merge stable into master, I get pinged. It's not worth the distraction. I initially added myself as CODEOWNER because I wanted to make sure people weren't adding unneccessary dependencies to the tool, but I give up.
Configuration menu - View commit details
-
Copy full SHA for a0e75cd - Browse repository at this point
Copy the full SHA a0e75cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20bc0a9 - Browse repository at this point
Copy the full SHA 20bc0a9View commit details -
Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) (#…
…155772) flutter/engine@9e6133e...5351777 2024-09-26 [email protected] fixes color filter + advanced blends (flutter/engine#55448) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for feb9c59 - Browse repository at this point
Copy the full SHA feb9c59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f663fc - Browse repository at this point
Copy the full SHA 7f663fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a64920 - Browse repository at this point
Copy the full SHA 9a64920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0a4f2 - Browse repository at this point
Copy the full SHA 2c0a4f2View commit details
Commits on Sep 27, 2024
-
Use flutter from in same repo (not path) in `generate_gradle_lockfile…
…s.dart` (again) (#155794) Fixes another invocation of `flutter`. Follow up to #155790. Checked that this is the only other one (and also the only use of `exec()` left that is relying on the path and shouldn't be (one other use uses git from the path, which is fine, and the other one uses an absolute path).
Configuration menu - View commit details
-
Copy full SHA for 5b32f33 - Browse repository at this point
Copy the full SHA 5b32f33View commit details -
fix: SelectableText should handle focus changes (#155771)
This change updates the behavior of `SelectableText`, to clear its selection when it loses focus and the application is currently running. This fixes the behavior where you may have multiple active highlights if you have `SelectableText` along with other "selectable" widgets such as `TextField`, or `Text` widgets under a `SelectionArea`. If the application is in the background, for example when another window is focused, the selection should be retained so when a user returns to the application it is still there. This change also updates the behavior of selection on macOS, single tap up, previously it was selecting the word edge closest to the tapped position, the correct behavior on native is to select the precise position. This was causing `onSelectionChanged` to be called twice, once for tap down (sets the precise tapped position, handled by logic in `TextSelectionGestureDetector`), and a second time for single tap up (moves the cursor to closest word edge, handled by logic in `_SelectableTextSelectionGestureDetectorBuilder`). This type of selection inconsistency is related to this issue #129726, I plan to look into this further in a separate PR. Fixes #117573 Fixes #103725
Configuration menu - View commit details
-
Copy full SHA for 799cf16 - Browse repository at this point
Copy the full SHA 799cf16View commit details -
Roll packages manually (#155786)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for cad7418 - Browse repository at this point
Copy the full SHA cad7418View commit details -
Throw StateError when implicitView is null on
wrapWithDefaultView. (#……155734) This PR tweaks `wrapWithDefaultView` (used by `runApp`) to raise a StateError with a legible error message when the `platformDispatcher.implicitView` is missing (for example, when enabling multi-view embedding on the web), instead of crashing with an unexpected `nullCheck` a few lines below. * Before: <img width="619" alt="Screenshot 2024-09-25 at 7 33 47â�¯PM" src="https://github.com/user-attachments/assets/4897dd3c-bdd0-4217-9f23-7eee9fab4999"> * After: <img width="613" alt="Screenshot 2024-09-26 at 5 01 49â�¯PM" src="https://github.com/user-attachments/assets/3febb91d-a8c3-41b6-bf34-c2c8743b637c"> ## Issues * Fixes #153198 ## Tests Added a test to ensure the assertion is thrown when the `implicitView` is missing. Had to hack a little because I couldn't find any clean way of overriding the `implicitView`. The problem is that the flutter_test bindings [use `runApp` internally](https://github.com/flutter/flutter/blob/8925e1ffdfe880b06a8bc5877f017083d6652f5b/packages/flutter_test/lib/src/binding.dart#L1020) a couple of times, so I can only disable the implicitView inside the test body (and must re-enable it before returning). Not sure if it's the best way, but it seems to do the trick for this simple test case!
Configuration menu - View commit details
-
Copy full SHA for f9a76ae - Browse repository at this point
Copy the full SHA f9a76aeView commit details -
Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) (#…
…155799) flutter/engine@5351777...e57b440 2024-09-26 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464) 2024-09-26 [email protected] [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019) 2024-09-26 [email protected] Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466) 2024-09-26 [email protected] Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465) 2024-09-26 [email protected] Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (#55450)" (flutter/engine#55463) 2024-09-26 [email protected] cipd: add mobileprovision CIPD package (flutter/engine#55449) 2024-09-26 [email protected] Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7bb9352 - Browse repository at this point
Copy the full SHA 7bb9352View commit details -
Fix DropdownMenu rendered behind AppBar (#155539)
## Description This PR changes the `MenuAnchor` implementation in order to always show the menu on the root overlay. Doing so menus can't be hidden by other widgets especially when using go_router. See [[go_router] DropdownMenu behind NavigationBar](#155034) where the DropdownMenu menu was displayed behind the navigation bar. I did not make this configurable for the moment to avoid introducing a new parameter until there is a clear use case for it. ## Related Issue Fixes [[go_router] DropdownMenu behind NavigationBar](#155034). ## Tests Adds 1 test.
Configuration menu - View commit details
-
Copy full SHA for 9ee3fb8 - Browse repository at this point
Copy the full SHA 9ee3fb8View commit details -
Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) (#…
…155811) flutter/engine@e57b440...7c603de 2024-09-27 [email protected] Roll Skia from 9ebb7c3640a1 to e77818421e91 (4 revisions) (flutter/engine#55479) 2024-09-27 [email protected] [ci] make opengles impeller scenario app non-bringup (flutter/engine#55474) 2024-09-27 [email protected] [Impeller] dont use blend shader for simple drawAtlas calls. (flutter/engine#55420) 2024-09-27 [email protected] Add `format` field to EGL surface backing store (flutter/engine#54499) 2024-09-26 [email protected] [Impeller] avoid reading font while parsing sktextblob. (flutter/engine#55442) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9be22b5 - Browse repository at this point
Copy the full SHA 9be22b5View commit details -
Remove left-over traces of "link-dry-run" - which isn't used anywhere…
… in flutter (#155820) The "link-dry-run" functionality was never used in flutter (even before the recent refactoring). I think we can remove this "link-dry-run" concept everywhere. PR to remove this in dart-lang/native: dart-lang/native#1613
Configuration menu - View commit details
-
Copy full SHA for ead6b0d - Browse repository at this point
Copy the full SHA ead6b0dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff fa402c8057a1...ead6b0d17c89