Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f86b77721524
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8591d0c16a6c
Choose a head ref
  • 16 commits
  • 72 files changed
  • 6 contributors

Commits on Nov 1, 2024

  1. Make the SwiftPM integration tests more idiomatic (#157971)

    I recommend reviewing with [whitespace changes disabled](https://github.com/flutter/flutter/pull/157971/files?diff=split&w=1).
    
    Changes:
    
    1. Replaces `expect(string.contains('foo'), isTrue)` with `expect(string, contains('foo'))`
    2. Replaces `try/finally` with `addTearDown`
    
    Follow-up to: #157482 (comment)
    loic-sharma authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    49ccfb7 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary kCliAnimationsFeatureName that is available as `…

    ….configSetting`. (#158013)
    
    ... for consistency with the rest of the file/features.
    matanlurey authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2ce743d View commit details
    Browse the repository at this point in the history
  3. Improve consistency of code snippets in basic.dart (#158015)

    Updates `basic.dart` to use consistent doc snippets that follows the style from the [documentation on snippets](https://github.com/flutter/flutter/tree/master/dev/snippets#snippet-tool).
    
    Follow-up to: #157227 (comment)
    loic-sharma authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    84ad67f View commit details
    Browse the repository at this point in the history
  4. Make SwiftPM integration tests even MORE idiomatic (#158014)

    Reach peak idiomacy by replacing `expect(file.existsSync(), isTrue)` with `expect(file, exists)`!
    
    Follow up to: #157971
    loic-sharma authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3699474 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f45e290 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9a5e8ce View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Delete unused references to dev.flutter.plugins.e2e. (#158031)

    Closes #157826.
    
    Like @gmackall I could not find any reference to these, and assume they were boilerplate that was never used (or deleted).
    matanlurey authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8b5ad69 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) (#…

    …158034)
    
    flutter/engine@7dfdcac...38b6165
    
    2024-11-01 [email protected] [Impeller] fix downsample with decal tile mode. (flutter/engine#56316)
    2024-11-01 [email protected] Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320)
    2024-11-01 [email protected] Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315)
    2024-11-01 [email protected] Write run_tests console logs to stdout instead of stderr (flutter/engine#56312)
    2024-11-01 [email protected] [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    2068fe7 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) (#…

    …158038)
    
    flutter/engine@38b6165...05cb5d7
    
    2024-11-02 [email protected] Refactor `BuildPlan`, better document and explain `--config`. (flutter/engine#56324)
    2024-11-01 [email protected] Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... (flutter/engine#56322)
    2024-11-01 [email protected] [Impeller] implement external texture gl for embedder. (flutter/engine#56277)
    2024-11-01 [email protected] Roll Dart SDK from 789763468d6b to 61bf0877807e (2 revisions) (flutter/engine#56323)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from MjcuejuzYvYG to 07KmbdEtnhkg
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ced3e85 View commit details
    Browse the repository at this point in the history
  4. Add test for raw_scrollbar.0.dart (#157989)

    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/scrollbar/raw_scrollbar.0.dart`
    ValentinVignal authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    574b7e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Fixes typos & spelling error in changelog.md file (#157438)

    This PR fixes the typos and spelling error in `CHANGELOG.md` file.
    
    Fixes #157083
    thejitenpatel authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    a1651c6 View commit details
    Browse the repository at this point in the history
  2. Revert "Add a warning/additional handlers for parsing`synthetic-packa…

    …ge`." (#158078)
    
    Reverts #157934 to unblock #158076 and then flutter roll.
    
    Reason: b/377107864
    polina-c authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    f7b24fa View commit details
    Browse the repository at this point in the history
  3. Revert "Add and plumb useImplicitPubspecResolution across `flutter_…

    …tools`." (#158076)
    
    Reverts #157879 to unblock flutter roll.
    
    Prerequisite reverts:
    #157934
    
    Reason: b/377107864
    polina-c authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    0505176 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Add test for interactive_viewer.constrained.0.dart (#158044)

    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/interactive_viewer/interactive_viewer.constrained.0.dart`
    ValentinVignal authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a1fbc83 View commit details
    Browse the repository at this point in the history
  2. Add test for raw_scrollbar.1.dart (#158069)

    Contributes to #130459
    
    It adds a test for
    - `examples/api/lib/widgets/scrollbar/raw_scrollbar.1.dart`
    ValentinVignal authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ed91ba1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8591d0c View commit details
    Browse the repository at this point in the history
Loading