Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f331a555e20c
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 29a238d0d506
Choose a head ref
  • 20 commits
  • 9 files changed
  • 6 contributors

Commits on Sep 12, 2025

  1. Configuration menu
    Copy the full SHA
    3310be0 View commit details
    Browse the repository at this point in the history
  2. Update transformHitTests documentation for clarity (#174286)

    ## Description 📝
    
    This PR updates the documentation for the transformHitTests parameter in
    the Transform widget to resolve ambiguity in the API documentation that
    has caused hit testing issues for developers.
    
    The current documentation simply states "Whether to apply the
    transformation when performing hit tests" which is ambiguous. As seen in
    issues like #27587, developers expect transformed widgets to receive
    touch events across their entire visual area, but hits only register
    within the parent's original bounds.
    
    **The core issue**:  The documentation lacks clarity on:
    ❌ Hit test coordinate system transformation vs. hit test bounds
    expansion
    🔄 Parent widget bounds as the constraint for hit test registration
    ⚠️ The distinction between visual rendering bounds and interactive
    bounds
    
    ### Before (Current Documentation) 
    
    *Current documentation is vague: "Whether to apply the transformation
    when performing hit tests"*
    
    <img width="1887" height="483" alt="Screenshot 2025-08-22 214745"
    src="https://github.com/user-attachments/assets/24569be5-8dbe-4a02-8851-1546b8ac109e"
    />
    
    ### After (Improved Documentation) 
    <img width="1091" height="293" alt="Screenshot 2025-08-22 214808"
    src="https://github.com/user-attachments/assets/f8504134-eba7-43ea-a71f-d9a8740ff295"
    />
    
    *New documentation clearly explains behavior, limitations, and
    solutions*
    
    **Changes made:** ✅
    - 🔧 Clarified that `transformHitTests` transforms registered hits into
    the child's resulting coordinate system
    - 🚨 Explicitly documented the critical limitation: only hits within
    parent bounds can be registered
    - 📚 Explained the behavior difference between `true` and `false`
    settings with concrete examples of transformation types
    - 💡 Added guidance for common workarounds: expanding parent bounds or
    using Overlay for out-of-bounds elements
    
    ## Issues Fixed 🐛
    
    Fixes #78120
    
    **Related issues that motivated this change:** 🔗
    - #27587 - Developers confused why GestureDetector doesn't respond after
    Transform
    - Multiple developers reported spending significant time debugging this
    behavior
    - Common misconception that visual transformation expands the hit test
    area
    
    **Note**: This PR is test-exempt as it only updates documentation
    comments without changing any functionality.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Rushikeshbhavsar20 authored Sep 12, 2025
    Configuration menu
    Copy the full SHA
    6e66c14 View commit details
    Browse the repository at this point in the history
  3. Fix crash when attaching to a device with multiple active flutter apps (

    #175147)
    
    `vmServiceUri` is a stream, and might emit multiple values. But
    `discoveryStatus.stop()` can only be called once.
    chingjun authored Sep 12, 2025
    Configuration menu
    Copy the full SHA
    1586c0c View commit details
    Browse the repository at this point in the history
  4. Add semanticIndexOffset argument to SliverList.builder, SliverGrid.bu…

    …ilder, and SliverFixedExtentList.builder (#174856)
    
    Issue: #173019 
    
    This pull request adds support for the `semanticIndexOffset` parameter
    to the `SliverList.builder`, `SliverFixedExtentList.builder`, and
    `SliverGrid.builder` constructors in Flutter. This allows developers to
    offset the starting semantic index for items in these slivers, which is
    important for accessibility scenarios (such as when combining multiple
    slivers). The changes are thoroughly tested with new widget tests to
    ensure correct behavior.
    
    **Accessibility improvements:**
    
    * Added `semanticIndexOffset` parameter to the constructors of
    `SliverList.builder`, `SliverFixedExtentList.builder`, and
    `SliverGrid.builder`, and ensured it is passed to the underlying
    `SliverChildBuilderDelegate`. This allows customization of the starting
    semantic index for sliver children.
    [[1]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR219)
    [[2]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR228)
    [[3]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR476)
    [[4]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR485)
    [[5]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR751)
    [[6]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR760)
    
    **Testing:**
    
    * Added a new test for `SliverList.builder` to verify that the
    `semanticIndexOffset` is respected in the generated semantics tree.
    [[1]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR366-R382)
    [[2]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR446-R474)
    * Added a new test for `SliverFixedExtentList.builder` to verify correct
    semantics index offsetting.
    * Added a new test for `SliverGrid.builder` to ensure it respects the
    `semanticIndexOffset` parameter.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: Loïc Sharma <[email protected]>
    rodrigogmdias and loic-sharma authored Sep 12, 2025
    Configuration menu
    Copy the full SHA
    adca933 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2025

  1. Configuration menu
    Copy the full SHA
    0e0d951 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from b2cdcf07b2b5 to 3321829b90dd (22 revisions) (#175295)

    https://skia.googlesource.com/skia.git/+log/b2cdcf07b2b5..3321829b90dd
    
    2025-09-12
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-12 [email protected] Add docs for SkPathRaw and expand tests
    2025-09-12 [email protected] Fix reference to renamed variable
    2025-09-12 [email protected] Add warning to note
    SK_SUPPORT_LEGACY_RRECT_TRANSFORM is load bearing
    2025-09-12
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-12 [email protected] [rust png] Update Chromium build
    instructions.
    2025-09-12
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-12 [email protected] More FromSVGString site updates
    2025-09-12 [email protected] [rust png] Move Rust PNG public headers
    to non-"experimental" dirs (1/3)
    2025-09-12 [email protected] Roll
    vulkan-deps from 62e39e6f037d to 2de7b0ea6642 (3 revisions)
    2025-09-12 [email protected] Use pathbuilder to keep paths immutable
    2025-09-12 [email protected] Roll ANGLE
    from f27d171991de to 46444b3df88c (17 revisions)
    2025-09-12 [email protected] Roll Skia
    Infra from 599ecfb9b331 to a3f4e114d37b (8 revisions)
    2025-09-12 [email protected] Roll Dawn
    from 4a8b7b7b5040 to a9061604eabb (7 revisions)
    2025-09-12
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-12 [email protected] Roll
    vulkan-deps from 53c9754ba412 to 62e39e6f037d (4 revisions)
    2025-09-11
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-11
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-11 [email protected] [infra] Tweaks needed to support internal
    devices
    2025-09-11 [email protected] [infra] Fixes for now.TimeTravelingContext
    2025-09-11 [email protected] Change CreateDrawArcPath to return its
    path
    2025-09-11
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 13, 2025
    Configuration menu
    Copy the full SHA
    376735c View commit details
    Browse the repository at this point in the history
  3. [ios]Do not re-adds delaying recognizer on iOS 26 (#175097)

    Removing since the workaround doesn't work anymore for iOS 26. It caused
    our whole gesture blocking system to fail completely (see
    #174513). We have to revert it
    and find other solutions.
    
    
    *List which issues are fixed by this PR. You must list at least one
    issue. An issue is not required if the PR fixes something trivial like a
    typo.*
    
    Fixes #174513
    
    Follow-up issue:  #175099
    
    
    *If you had to change anything in the [flutter/tests] repo, include a
    link to the migration guide as per the [breaking change policy].*
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    hellohuanlin authored Sep 13, 2025
    Configuration menu
    Copy the full SHA
    fd88c47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e4f5ed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3c74216 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8cbca23 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e1c2ccb View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2025

  1. Configuration menu
    Copy the full SHA
    933ccec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59c274a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81928ee View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2025

  1. Configuration menu
    Copy the full SHA
    a8acab0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e0f582 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from 785f8859c7b9 to d84a369255c4 (5 revisions) (#175342)

    https://skia.googlesource.com/skia.git/+log/785f8859c7b9..d84a369255c4
    
    2025-09-15 [email protected] SkColorSpacePrimaries: Add operator==
    and operator!=
    2025-09-15 [email protected] Roll ANGLE
    from 46444b3df88c to 81a181d12531 (8 revisions)
    2025-09-15 [email protected] Roll Skia
    Infra from a3f4e114d37b to 3f6aa4f56ad1 (5 revisions)
    2025-09-15 [email protected] Roll Dawn
    from a9061604eabb to af2f85f5494c (18 revisions)
    2025-09-15 [email protected] Roll
    skottie-base from 125a9ff87309 to 663e45a448ff
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    0eec486 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5ccb53d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2594f40 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    29a238d View commit details
    Browse the repository at this point in the history
Loading