-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: ee0cc6652be7
head repository: flutter/flutter
compare: afba7d75b391
- 10 commits
- 50 files changed
- 6 contributors
Commits on Jul 22, 2025
-
Unclear why the bot didn't bump this.
Configuration menu - View commit details
-
Copy full SHA for 6b7d928 - Browse repository at this point
Copy the full SHA 6b7d928View commit details -
Revert #160653 Fix view removal process for AutofillContextAction.can…
…cel (#172490) Between #145681 (autofill save prompt shows up for password fields when you dismiss the keyboard) and #172250 (calling `TextInput.hide` causes the current active text field to lose its text) the latter seems to be the worse bug. The framework `EditableText` implementation only calls `TextInput.hide` when switching input controls, so #172250 typically does not affect flutter text fields itself, but becomes a problem if the app wishes to add UI (similar to the iOS down-arrow button that would show up above the keyboard when you're filling out a form) to dismiss the keyboard. This reopens #145681. See #145681 (comment) @koji-1009 does reverting sound ok to you? ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for be9526f - Browse repository at this point
Copy the full SHA be9526fView commit details -
Use a fake representation of
cache/artifacts/gradle_wrapper(#172503)... so that it doesn't require downloading cache artifacts to run `general.shard/project_test.dart`. Closes #83275.
Configuration menu - View commit details
-
Copy full SHA for 3038239 - Browse repository at this point
Copy the full SHA 3038239View commit details -
Update warnGradleVersion to
8.7.0(#172576)When using a lower Gradle version, a warning to update to at least 8.7.2 is shown, but 8.7.2 is not a valid version. Changed warnGradleVersion from 8.7.2 to 8.7.0. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for e12d263 - Browse repository at this point
Copy the full SHA e12d263View commit details -
Improve assertion message in
AlignmentDirectional.resolve(#172096)Replaces the generic assertion in `AlignmentDirectional.resolve` and `_MixedAlignment.resolve` with `debugCheckCanResolveTextDirection`. This change provides a more helpful and descriptive error message when the `TextDirection` is null, improving the developer experience by clearly stating why the resolution failed and how to fix it. Fixes: #171813, Fixes: #171814, also fixes: #171812 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for c45a67e - Browse repository at this point
Copy the full SHA c45a67eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d62770 - Browse repository at this point
Copy the full SHA 6d62770View commit details
Commits on Jul 23, 2025
-
Wraps all
gitexecutions in aGit(...).*, use*=noglobon Windo……ws (#172495) Closes #74165. The original issue called for, on Windows, telling `CYGWIN` to use `=noglob`, to work around some git operation errors that happen when using non-native Git. There ... was no great way to do this with the existing codebase without, IMO, adding lots of confusing code. So, I refactored all the calls of: - before: `processUtils.<method>(['git', ...args], ...params)` - after: `git.<method>([...args], ...params)` ... and implicitly add the new environment variables, if `Platform.isWindows`. Did some minor test cleanup and process execution cleanup while I was at it.
Configuration menu - View commit details
-
Copy full SHA for 6fd30fd - Browse repository at this point
Copy the full SHA 6fd30fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f92ee2 - Browse repository at this point
Copy the full SHA 7f92ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb80c97 - Browse repository at this point
Copy the full SHA fb80c97View commit details -
Remove GtkGLArea and render directly into GtkDrawingArea (#172343)
This simplifies the OpenGL/software case and allows us more control over the buffering.
Configuration menu - View commit details
-
Copy full SHA for afba7d7 - Browse repository at this point
Copy the full SHA afba7d7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ee0cc6652be7...afba7d75b391