Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e64ee5de7cdd
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1e4ee9a016e
Choose a head ref
  • 18 commits
  • 43 files changed
  • 16 contributors

Commits on Dec 3, 2024

  1. [SwiftPM] Rename SWIFT_PACKAGE_MANAGER environment variable to `FLU…

    …TTER_SWIFT_PACKAGE_MANAGER` (#159502)
    
    Previously, the Swift Package Manager feature could be overridden using
    the `SWIFT_PACKAGE_MANAGER` environment variable.
    
    This environment variable name is a bit generic and might collide with
    other tooling.
    
    This renames the environment variable to
    `FLUTTER_SWIFT_PACKAGE_MANAGER`.
    
    **This is a breaking change**, however, [we haven't documented this
    environment
    variable](https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#how-to-turn-on-swift-package-manager).
    
    Addresses #159121
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    loic-sharma authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    88a7ec6 View commit details
    Browse the repository at this point in the history
  2. remove unnecessary semicolon in module_plugin_loader.radle (#159303)

    `what lint is failing ?`
    ![Capture d’écran 2024-11-25
    215213](https://github.com/user-attachments/assets/c2be911c-981a-4d47-8c52-9802d4855666)
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    AbdeMohlbi authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c90080c View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from c7f553eb6a30 to 938f8163b526 (1 revision) (#…

    …159742)
    
    flutter/engine@c7f553e...938f816
    
    2024-12-03 [email protected] Roll Fuchsia Linux SDK from
    j424tGVlulTUzBtPj... to CCKZcL47N_2_vxAtS... (flutter/engine#56921)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from j424tGVlulTU to CCKZcL47N_2_
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8612ce0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f0cfc4 View commit details
    Browse the repository at this point in the history
  5. Fix typo in flutter_command.dart (#159398)

    sever -> server
    TheJoeSchr authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    980df92 View commit details
    Browse the repository at this point in the history
  6. fix fialing lint `Consider using 'register' to avoid unnecessary conf…

    …iguration` (#159137)
    
    fix failing lint `Consider using 'register' to avoid unnecessary
    configuration` in Android studio :
    ![Capture d’écran 2024-11-19
    132110](https://github.com/user-attachments/assets/ffc98203-5563-4846-aa42-60a0b8defa27)
    
    ![Capture d’écran 2024-11-19
    133050](https://github.com/user-attachments/assets/7671b6f4-5a18-460a-8456-608a40e6da22)
    see #147122
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    AbdeMohlbi authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    1b048b0 View commit details
    Browse the repository at this point in the history
  7. [Widget Inspector] Only include truncated field in JSON response if…

    … `true` (#159701)
    
    Work towards flutter/devtools#8582
    
    Follow up to #159454
    
    Only include the `truncated` field if it is `true`. We accidentally were
    including it even when `false` which is what caused the regression in
    the DevTools tests.
    elliette authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8106f2a View commit details
    Browse the repository at this point in the history
  8. Add IconAlignment to ButtonStyle and styleFrom methods (#158503)

    Fixes [Proposal to add iconAlignment to
    ButtonStyle](#153350)
    
    ### Description
    
    This PR refactors buttons `IconAlignment`, adds to `ButtonStyle` and
    `styleFrom` methods. Which makes it possible to customize iconAlignment
    same way as icon size and color in the `ButtonStyle`.
    
    ### Code sample 
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    enum StyleSegment {
      none,
      widgetButtonStyle,
      widgetStyleFrom,
      themeButtonStyle,
      themeStyleFrom
    }
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatefulWidget {
      const MyApp({super.key});
    
      @OverRide
      State<MyApp> createState() => _MyAppState();
    }
    
    class _MyAppState extends State<MyApp> {
      StyleSegment _selectedSegment = StyleSegment.none;
    
      ThemeData? getThemeStyle() => switch (_selectedSegment) {
            StyleSegment.themeButtonStyle => ThemeData(
                textButtonTheme: const TextButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                elevatedButtonTheme: const ElevatedButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                outlinedButtonTheme: const OutlinedButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                filledButtonTheme: const FilledButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
              ),
            StyleSegment.themeStyleFrom => ThemeData(
                textButtonTheme: TextButtonThemeData(
                  style: TextButton.styleFrom(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                elevatedButtonTheme: const ElevatedButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                outlinedButtonTheme: const OutlinedButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
                filledButtonTheme: const FilledButtonThemeData(
                  style: ButtonStyle(
                    iconAlignment: IconAlignment.end,
                  ),
                ),
              ),
            _ => null
          };
    
      ButtonStyle? getTextButtonStyle() => switch (_selectedSegment) {
            StyleSegment.widgetStyleFrom => TextButton.styleFrom(
                iconAlignment: IconAlignment.end,
              ),
            StyleSegment.widgetButtonStyle => const ButtonStyle(
                iconAlignment: IconAlignment.end,
              ),
            _ => null
          };
    
      ButtonStyle? getElevatedButtonStyle() => switch (_selectedSegment) {
            StyleSegment.widgetStyleFrom => ElevatedButton.styleFrom(
                iconAlignment: IconAlignment.end,
              ),
            StyleSegment.widgetButtonStyle => const ButtonStyle(
                iconAlignment: IconAlignment.end,
              ),
            _ => null
          };
    
      ButtonStyle? getOutlinedButtonStyle() => switch (_selectedSegment) {
            StyleSegment.widgetStyleFrom => OutlinedButton.styleFrom(
                iconAlignment: IconAlignment.end,
              ),
            StyleSegment.widgetButtonStyle => const ButtonStyle(
                iconAlignment: IconAlignment.end,
              ),
            _ => null
          };
    
      ButtonStyle? getFilledButtonStyle() => switch (_selectedSegment) {
            StyleSegment.widgetStyleFrom => FilledButton.styleFrom(
                iconAlignment: IconAlignment.end,
              ),
            StyleSegment.widgetButtonStyle => const ButtonStyle(
                iconAlignment: IconAlignment.end,
              ),
            _ => null
          };
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          debugShowCheckedModeBanner: false,
          theme: getThemeStyle(),
          home: Scaffold(
            appBar: AppBar(
              title: const Text('ButtonStyle Icon Alignment'),
            ),
            body: Center(
              child: Padding(
                padding: const EdgeInsets.all(16.0),
                child: Column(
                  mainAxisAlignment: MainAxisAlignment.center,
                  spacing: 20,
                  children: [
                    Wrap(
                      spacing: 16,
                      runSpacing: 16,
                      children: [
                        TextButton.icon(
                          style: getTextButtonStyle(),
                          onPressed: () {},
                          icon: const Icon(Icons.add),
                          label: const Text('Text Button'),
                        ),
                        ElevatedButton.icon(
                          style: getElevatedButtonStyle(),
                          onPressed: () {},
                          icon: const Icon(Icons.add),
                          label: const Text('Elevated Button'),
                        ),
                        OutlinedButton.icon(
                          style: getOutlinedButtonStyle(),
                          onPressed: () {},
                          icon: const Icon(Icons.add),
                          label: const Text('Outlined Button'),
                        ),
                        FilledButton.icon(
                          style: getFilledButtonStyle(),
                          onPressed: () {},
                          icon: const Icon(Icons.add),
                          label: const Text('Filled Button'),
                        ),
                        FilledButton.tonalIcon(
                          style: getFilledButtonStyle(),
                          onPressed: () {},
                          icon: const Icon(Icons.add),
                          label: const Text('Filled Button Tonal Icon'),
                        ),
                      ],
                    ),
                    StyleSelection(
                      selectedSegment: _selectedSegment,
                      onSegmentSelected: (StyleSegment segment) {
                        setState(() {
                          _selectedSegment = segment;
                        });
                      },
                    ),
                  ],
                ),
              ),
            ),
          ),
        );
      }
    }
    
    class StyleSelection extends StatelessWidget {
      const StyleSelection(
          {super.key,
          this.selectedSegment = StyleSegment.none,
          required this.onSegmentSelected});
    
      final ValueChanged<StyleSegment> onSegmentSelected;
      final StyleSegment selectedSegment;
    
      @OverRide
      Widget build(BuildContext context) {
        return SegmentedButton<StyleSegment>(
          segments: const <ButtonSegment<StyleSegment>>[
            ButtonSegment<StyleSegment>(
              value: StyleSegment.none,
              label: Text('None'),
            ),
            ButtonSegment<StyleSegment>(
              value: StyleSegment.widgetButtonStyle,
              label: Text('Widget Button Style'),
            ),
            ButtonSegment<StyleSegment>(
              value: StyleSegment.widgetStyleFrom,
              label: Text('Widget Style From'),
            ),
            ButtonSegment<StyleSegment>(
              value: StyleSegment.themeButtonStyle,
              label: Text('Theme Button Style'),
            ),
            ButtonSegment<StyleSegment>(
              value: StyleSegment.themeStyleFrom,
              label: Text('Theme Style From'),
            ),
          ],
          selected: <StyleSegment>{selectedSegment},
          onSelectionChanged: (Set<StyleSegment> newSelection) {
            onSegmentSelected(newSelection.first);
          },
        );
      }
    }
    ```
    
    </details>
    
    ### Preview
    
    <img width="1175" alt="Screenshot 2024-11-12 at 12 10 43"
    src="https://github.com/user-attachments/assets/a28207c5-0ef7-41fa-a45c-e9401df897a0">
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    TahaTesser authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9e2d9de View commit details
    Browse the repository at this point in the history
  9. Increase timeout of Devtools tests (#159759)

    Increases from the default 30 minutes to 45.
    After devtools testing was re-enabled in
    flutter/tests#432 the tree is red because the
    test shard exceeds 30 minutes again.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Piinks authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cff62c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Roll Flutter Engine from 938f8163b526 to 1e6864c489c8 (6 revisions) (#…

    …159776)
    
    flutter/engine@938f816...1e6864c
    
    2024-12-04 [email protected] [Android] Save
    back handling state in Activity/Fragment bundle (flutter/engine#56715)
    2024-12-03 [email protected] Split keyevent channel into own
    class (flutter/engine#56911)
    2024-12-03 [email protected] Add tests for errors encoding
    message channel request and method calls. (flutter/engine#56914)
    2024-12-03 [email protected] Roll Skia from 8dc8bdc364f5 to
    e02d856f86fb (3 revisions) (flutter/engine#56926)
    2024-12-03 [email protected] [Impeller] invalidate cached atlas
    data, take 2. (flutter/engine#56925)
    2024-12-03 [email protected] Add typeface_proxy
    dependency to the Skia build script for the Android font manager
    (flutter/engine#56924)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    a9ed692 View commit details
    Browse the repository at this point in the history
  2. Add mouseCursor parameter to Chips (#159422)

    Part of #58192
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Victor Sanni <[email protected]>
    ValentinVignal and victorsanni authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    628ab7f View commit details
    Browse the repository at this point in the history
  3. Format controller.dart of flutter_test (#159667)

    Format controller.dart of flutter_test
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    hgraceb authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    74757b3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be50ec7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    03aeaf1 View commit details
    Browse the repository at this point in the history
  6. Reland Fix InkWell overlayColor resolution ignores selected state (#1…

    …59784)
    
    Reland #159072 without change.
    The initial PR was flagged for a non-related perf regression, see
    #159337 (comment)
    
    Fixes #159063
    bleroux authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    0187788 View commit details
    Browse the repository at this point in the history
  7. Marks Mac_benchmark flutter_view_macos__start_up to be flaky (#159541)

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Mac_benchmark flutter_view_macos__start_up"
    }
    -->
    Issue link: #159540
    
    Co-authored-by: Chris Bracken <[email protected]>
    fluttergithubbot and cbracken authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    c99653d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eabed23 View commit details
    Browse the repository at this point in the history
  9. Fix DropdownMenu focus (#156412)

    Fixes #143505
    
    I am unable to test sending `TextInputClient.performAction` when the
    enter key is pressed on desktop platforms. I have created an issue for
    this: #156414. The current test approach is to check whether the
    `DropdownMenu` has focus.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Bruno Leroux <[email protected]>
    yiiim and bleroux authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e1e4ee9 View commit details
    Browse the repository at this point in the history
Loading