Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e1e4ee9a016e
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ab5b20c16d56
Choose a head ref
  • 7 commits
  • 25 files changed
  • 5 contributors

Commits on Dec 4, 2024

  1. [Android] Removes dev dependency plugins from release builds (#158026)

    Removes plugins that are `dev_dependency`s from being dependencies of
    release builds of Flutter Android app projects.
    
    Fixes #157949.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    camsim99 authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    f9f42be View commit details
    Browse the repository at this point in the history
  2. Fix: Update PopupMenu position when layout changes (#157983)

    This PR fixes an issue where PopupMenu doesn't update its position when
    the screen layout changes (e.g. during rotation or window resizing).
    
    ## Changes
    - Introduces `positionBuilder` instead of directly using position
    - Calls positionBuilder after layout changes to get the updated position
    - Adds tests to verify position updates correctly
    
    ## Related Issues
    Fixes #152475 - PopupMenu retains wrong position on layout change
    
    ## Implementation Notes
    This implementation uses a builder pattern to dynamically calculate
    positions. This approach may be applicable to other popup widgets (like
    DropdownButton mentioned in #156980) that have similar positioning
    requirements.
    
    <br>
    <br>
    <br>
    <br>
    <br>
    
    
    
    
    
    
    
    *Replace this paragraph with a description of what this PR is changing
    or adding, and why. Consider including before/after screenshots.*
    
    *List which issues are fixed by this PR. You must list at least one
    issue. An issue is not required if the PR fixes something trivial like a
    typo.*
    
    *If you had to change anything in the [flutter/tests] repo, include a
    link to the migration guide as per the [breaking change policy].*
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    YeungKC authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    efa7d52 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a72ad54 View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 1f7f37e264b0 to 9e8fcad4eaf6 (2 revisions) (#…

    …159808)
    
    flutter/engine@1f7f37e...9e8fcad
    
    2024-12-04 [email protected] Manual roll Dart SDK from
    470117150f34 to a2a9428e761f (1 revision) (flutter/engine#56939)
    2024-12-04 [email protected] Added the ability
    to make untracked opengles handles (migrated textures)
    (flutter/engine#56927)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    3de19db View commit details
    Browse the repository at this point in the history
  5. Add flutter widget-preview {start, clean} commands (#159510)

    This is the initial tooling work for Flutter Widget Previews, adding two
    commands: `flutter widget-preview start` and `flutter widget-preview
    clean`.
    
    The `start` command currently only checks to see if
    `.dart_tool/widget_preview_scaffold/` exists and creates a new Flutter
    project using the widget_preview_scaffold template if one isn't found.
    The widget_preview_scaffold template currently only contains some
    placeholder files and will be updated to include additional code
    required by the scaffold.
    
    The `clean` command simply deletes `.dart_tool/widget_preview_scaffold/`
    if it's found.
    
    This change also includes some refactoring of the `create` command in
    order to share some project creation logic without requiring `flutter
    widget-preview start` to spawn a new process simply to run `flutter
    create -t widget_preview .dart_tool/widget_preview_scaffold`.
    
    Related issue: #115704
    
    ---------
    
    Co-authored-by: Andrew Kolos <[email protected]>
    bkonyi and andrewkolos authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    74669e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2024

  1. Roll Flutter Engine from 9e8fcad4eaf6 to 8d3c71840069 (3 revisions) (#…

    …159818)
    
    flutter/engine@9e8fcad...8d3c718
    
    2024-12-04 [email protected] [Impeller] remove extra validation
    checks in GLES backend. (flutter/engine#56944)
    2024-12-04 [email protected] Remove LSAN supressions for Linux
    embedder (flutter/engine#56913)
    2024-12-04 [email protected] [web] Start with a smaller memory
    allocation for CanvasKit (flutter/engine#56900)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    f89546c View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 8d3c71840069 to 05e2d6597cb2 (4 revisions) (#…

    …159836)
    
    flutter/engine@8d3c718...05e2d65
    
    2024-12-05 [email protected] [Impeller] store GLES bindings on
    render pass w/ offsets instead of per-command. (flutter/engine#56910)
    2024-12-05 [email protected] [Impeller] avoid re-binding winding
    order and cull mode. (flutter/engine#56943)
    2024-12-05 [email protected] Implements the
    naming of untracked gles handles (flutter/engine#56948)
    2024-12-05 [email protected] Roll Fuchsia Test Scripts from
    VilXq4eGH5A24wRWA... to r9Dc5VRF6sE3pJH20... (flutter/engine#56953)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    ab5b20c View commit details
    Browse the repository at this point in the history
Loading