Comparing changes

This PR adds my name to AUTHORS. Reference: [author:ValentinVignal](https://github.com/flutter/flutter/issues?q=author%3AValentinVignal)

This helps green the tree considering firebase outage: #147335

…onAnimationStyle` (#147103) This PR adds support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle`. Closes #146760

When Swift Package Manager feature is enabled, create app and create plugin will have Swift Package Manager integration already added and will not need to undergo a migration. Fixes #146371. ``` flutter config --enable-swift-package-manager flutter create --ios-language swift --platforms ios,macos swift_app_name flutter create --ios-language objc --platforms ios objc_app_name flutter create --template=plugin --ios-language swift --platforms ios,macos swift_plugin_name flutter create --template=plugin --ios-language objc --platforms ios objc_plugin_name ```

) This is part 12 of a broken down version of the #140101 refactor. This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.

…147336) flutter/engine@b5d5832...b30c0a7 2024-04-24 [email protected] Remove UIAccessibilityTraitKeyboardKey to fix touch typing (flutter/engine#52333) 2024-04-24 [email protected] [Impeller] Remove libtess2 from libflutter. (flutter/engine#52357) 2024-04-24 [email protected] Roll Skia from 510b6766d907 to afcc1db27593 (2 revisions) (flutter/engine#52367) 2024-04-24 [email protected] [web:tests] switch to new HTML DOM matcher (flutter/engine#52354) 2024-04-24 [email protected] [Impeller] use spec constant for gaussian shader, rename, and reuse vertex sources. (flutter/engine#52361) 2024-04-24 [email protected] [Impeller] delete points compute shader. (flutter/engine#52346) 2024-04-24 [email protected] [darwin] Update pixel format handling in FlutterTexture (flutter/engine#52326) 2024-04-24 [email protected] [Impeller] make drawAtlas always use porterduff or vertices_uber shader (flutter/engine#52348) 2024-04-24 [email protected] Migrate ios_surface files to ARC (flutter/engine#52139) 2024-04-24 [email protected] Roll Dart SDK from f470eaaf6e6d to 38c43a01a51e (1 revision) (flutter/engine#52365) 2024-04-24 [email protected] Roll Skia from b5dd23bd29df to 510b6766d907 (16 revisions) (flutter/engine#52364) 2024-04-24 [email protected] Fix some warnings reported by recent versions of clang-tidy (flutter/engine#52349) 2024-04-24 [email protected] Roll Skia from e15464e6e982 to b5dd23bd29df (1 revision) (flutter/engine#52353) 2024-04-24 [email protected] Roll Dart SDK from 5227dc5103f6 to f470eaaf6e6d (1 revision) (flutter/engine#52359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description This PR fixes the filled color for a focused and hovered text field. Before this PR, the filled color for a focused text field did not change when hovered, after this PR the filled color is blended with the hover color. The change removes a `isFocused` check which deactivated the blending. This check was introduced in #32776, at that time it was needed because there was also a focus color animation. Sometimes later, the focus animation was removed, see #33062, but the flag was not removed. **Before**: https://github.com/flutter/flutter/assets/840911/9698ba82-eb67-428a-8635-8054a4b8dfaf **After**: https://github.com/flutter/flutter/assets/840911/4c03a137-360d-4612-8946-765d7b5c698d ## Related Issue Fixes #146573 ## Tests Adds 1 tests.

…rom the rendering layer to be hooked (#147271) This also includes some minor cleanup of documentation, asserts, and tests.

…147348) flutter/engine@b30c0a7...f48f3b6 2024-04-24 [email protected] [Impeller] only use porter duff or vertices.uber for drawVertices. (flutter/engine#52345) 2024-04-24 [email protected] Roll Fuchsia Linux SDK from le_-uFgRD5DjvvqgL... to PJBX8xxRnd5vCFnQM... (flutter/engine#52376) 2024-04-24 [email protected] [Impeller] Remove additional shader bootstrap. (flutter/engine#52368) 2024-04-24 [email protected] Remove TODO I will never do: `runIfNot` is deprecated. (flutter/engine#52308) 2024-04-24 [email protected] Roll Dart SDK from 38c43a01a51e to 9a0f141e9a67 (1 revision) (flutter/engine#52373) 2024-04-24 [email protected] [Impeller] Cleanup legacy StencilModes and document overdraw prevention. (flutter/engine#52372) 2024-04-24 [email protected] Roll Skia from afcc1db27593 to 864f6d868ec0 (1 revision) (flutter/engine#52371) 2024-04-24 [email protected] Move zlib to //flutter/third_party (flutter/engine#52366) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from le_-uFgRD5Dj to PJBX8xxRnd5v If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…147351) flutter/engine@f48f3b6...2f48456 2024-04-25 [email protected] [macOS] Remove extra `setViewController` and extra import (flutter/engine#52255) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…147354) flutter/engine@2f48456...9de649e 2024-04-25 [email protected] Document the new binding hooks for SceneBuilder, PictureRecorder, Canvas (flutter/engine#52374) 2024-04-25 [email protected] Roll Dart SDK from 9a0f141e9a67 to 4ec0cf16c47c (1 revision) (flutter/engine#52382) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…147356) flutter/engine@9de649e...ccd57f5 2024-04-25 [email protected] Roll Skia from 864f6d868ec0 to e1fbdd02b79b (1 revision) (flutter/engine#52383) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…147359) flutter/engine@ccd57f5...6b33890 2024-04-25 [email protected] Roll Skia from e1fbdd02b79b to 15da9c78ddbd (1 revision) (flutter/engine#52385) 2024-04-25 [email protected] Roll Dart SDK from 4ec0cf16c47c to 386cac001e2b (1 revision) (flutter/engine#52384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Uses kernel concatenation to concatenate the `program.dill` and `native_assets.dill`. This will enable compiling `native_assets.dill` after `program.dill` so that tree-shaking information can be used. Issue: * #146270 ## Implementation choices * We can either run the frontend_server twice as a process invocation (current PR), or keep the process running after the dart compilation and then shut it down after native assets compilation to kernel. Keeping the process running would require more coordination between different `Target`s. * We can either chose to only do separate kernel file compilation in release (AOT) builds, or do it both for JIT and AOT (current PR). Doing it differently in JIT/AOT means more conditionals in lib/src/build_system/targets/, doing it single-shot in JIT might be more performant though. Update: Both of these are mitigated by not running the kernel compiler process if there are no native assets at all. ## Implementation notes This only updates `flutter assemble`. The kernel compilation calls in `flutter run` do not require kernel concatenation. The native-assets-kernel-mapping in `flutter run` contains results from `--dry-run` invocations of `hook/build.dart` (and in the future `hook/link.dart`). These `--dry-run` invocations do not get access to tree-shaking information, so the `link` hook to be introduced later can be run before Dart compilation. ## Tests * Updated the `Target`s tests to reflect the new implementation. ## Related CLs * frontend_server support: https://dart-review.googlesource.com/c/sdk/+/363567 * Same PR for Dart standalone: https://dart-review.googlesource.com/c/sdk/+/362384

…147365) flutter/engine@6b33890...674890c 2024-04-25 [email protected] Roll Skia from 15da9c78ddbd to 283d3e4e8e35 (1 revision) (flutter/engine#52386) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Apr 24, 2024

Commits on Apr 25, 2024

This comparison is taking too long to generate.

Uh oh!