Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: db68c950c599
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aef4718b3956
Choose a head ref
  • 7 commits
  • 27 files changed
  • 7 contributors

Commits on Apr 15, 2025

  1. license checker: ignore git sha in dart license (#167153)

    This works around the problem of the git sha in the license golden for
    dart by:
    1) Ignoring that line in the comparison
    1) Verifying that that line includes the googlesource url
    
    fixes #166807
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    gaaclarke authored Apr 15, 2025
    Configuration menu
    Copy the full SHA
    4ae02d2 View commit details
    Browse the repository at this point in the history
  2. Removed superfluous copy in license checker (#167146)

    This was the most expensive part of finding the files phase.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    gaaclarke authored Apr 15, 2025
    Configuration menu
    Copy the full SHA
    b4dc233 View commit details
    Browse the repository at this point in the history
  3. Roll Dartdoc to 8.3.3 (#167231)

    This is required for the latest Dart SDK roll which removes the macros
    package (see #167223)
    jason-simmons authored Apr 15, 2025
    Configuration menu
    Copy the full SHA
    3900a25 View commit details
    Browse the repository at this point in the history
  4. Add button icon support for animation duration (#162667)

    Fixes [Default foreground color animation duration doesn't apply on icon
    of `Button` widgets](#162301)
    Fixes [Implement similar widget to``AnimatedDefaultTextStyle`` but for
    child ``Icon``](#137251)
    
    ### Description
    
    This PR adds``AnimatedTheme` to `ButtonStyleButton` which is extended by
    buttons. It animates the button icon when changing icon color and size,
    similar to button text.
    
    ### Code Sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return const MaterialApp(
          home: HomePage(),
        );
      }
    }
    
    class HomePage extends StatelessWidget {
      const HomePage({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return Scaffold(
          body: Center(
            child: Column(
              mainAxisAlignment: MainAxisAlignment.center,
              spacing: 20,
              children: <Widget>[
                ElevatedButton.icon(
                  icon: const Icon(Icons.favorite_rounded, size: 50),
                  label: const Text('Button', style: TextStyle(fontSize: 36)),
                  onPressed: () {},
                  style: const ButtonStyle(
                    iconColor: WidgetStateProperty<Color>.fromMap(
                      <WidgetStatesConstraint, Color>{
                        WidgetState.pressed: Color(0XFFFF0000),
                        WidgetState.any: Color(0XFF000000),
                      },
                    ),
                    foregroundColor: WidgetStateProperty<Color>.fromMap(
                      <WidgetStatesConstraint, Color>{
                        WidgetState.pressed: Color(0XFFFF0000),
                        WidgetState.any: Color(0XFF000000),
                      },
                    ),
                  ),
                ),
                ElevatedButton.icon(
                  icon: const Icon(Icons.favorite_rounded, size: 50),
                  label: const Text('Button', style: TextStyle(fontSize: 36)),
                  onPressed: () {},
                  style: const ButtonStyle(
                    animationDuration: Duration(seconds: 2),
                    iconColor: WidgetStateProperty<Color>.fromMap(
                      <WidgetStatesConstraint, Color>{
                        WidgetState.pressed: Color(0XFFFF0000),
                        WidgetState.any: Color(0XFF000000),
                      },
                    ),
                    foregroundColor: WidgetStateProperty<Color>.fromMap(
                      <WidgetStatesConstraint, Color>{
                        WidgetState.pressed: Color(0XFFFF0000),
                        WidgetState.any: Color(0XFF000000),
                      },
                    ),
                  ),
                )
              ],
            ),
          ),
        );
      }
    }
    
    ```
    
    </details>
    
    ### Before
    
    
    https://github.com/user-attachments/assets/86fcab94-1147-4c49-b362-12f804a5d540
    
    ### After
    
    
    https://github.com/user-attachments/assets/12a49de8-06d6-46c5-976f-5ce182d60423
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    Co-authored-by: Qun Cheng <[email protected]>
    TahaTesser and QuncCccccc authored Apr 15, 2025
    Configuration menu
    Copy the full SHA
    a8a61a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. Adding macrobenchmarks for DDC (#166617)

    We're adding macrobenchmark support to DDC (AMD modules and our new
    hot-reload-capable module system) to be aware of any current/future
    performance regressions. I'm not terribly aware of the metrics
    collection pipeline; please let me know if we need to do any more work
    to see these tests run/report numbers to the proper dashboards.
    Markzipan authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    10a1d15 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (#167249)

    https://skia.googlesource.com/skia.git/+log/76cb5d4fba27..6627deb65939
    
    2025-04-15 [email protected] [graphite] Read dst as input attachment
    in Vulkan
    2025-04-15 [email protected] Roll skcms
    from 8faeb7707de8 to df82c365f7be (1 revision)
    2025-04-15 [email protected] Roll
    vulkan-deps from 72ecfe9950d2 to 971325a8d446 (1 revision)
    2025-04-15 [email protected] Rename existing SkRecorder ->
    SkRecordCanvas
    2025-04-15 [email protected] Roll ANGLE
    from 1c0bcb06e36f to a3f2545f6bb3 (12 revisions)
    2025-04-15 [email protected] Roll
    SwiftShader from 2b323370501c to 2d70dae3d0ca (2 revisions)
    2025-04-15 [email protected] Ensure SkTraceEvent.h is kept as the
    canonical header for tracing
    2025-04-15 [email protected] Revert "IWYU for SkTraceEventCommon.h"
    2025-04-14 [email protected] Roll
    vulkan-deps from a24af46b3d3b to 72ecfe9950d2 (10 revisions)
    2025-04-14 [email protected] IWYU for SkTraceEventCommon.h
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    055b23d View commit details
    Browse the repository at this point in the history
  3. [Web] Remove webOnlyUniformRadii from RRect (#167237)

    This variable was added in flutter/engine#15970
    (for the HTML renderer I guess?) and is apparently no long used
    anywhere.
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    dkwingsmt authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    aef4718 View commit details
    Browse the repository at this point in the history
Loading