Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d7b523b356d1
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: edada7c56edf
Choose a head ref
  • 7 commits
  • 26 files changed
  • 4 contributors

Commits on Jul 21, 2025

  1. [CP stable] Don't throw on error for mDNS when searching for Dart VML…

    … url on core devices (#172461)
    
    Impacted Users: iOS users on macOS 15
    Impact Description: mDNS may cause a crash on macOS 15 if permissions are missing. When possible use device logs to continue the process instead of using mDNS.
    Workaround: Enable mDNS permissions
    Risk: low
    Test Coverage: Yes
    Validation Steps: Toggle off Local Network permissions (System Settings > Privacy & Security > Local Network) and do `flutter run` on iOS 17+ physical device. Device should still connect.
    
    Release note: This is a prerequisite to allowing stable branch to be upgraded to macOS 15
    vashworth authored Jul 21, 2025
    Configuration menu
    Copy the full SHA
    d94d554 View commit details
    Browse the repository at this point in the history
  2. [CP-stable][canvaskit] Manually trigger input event in text editing…

    … tests for Safari (#172462)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    #169282
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
    
    Updates Flutter CI Safari test to make compatible with maCOS 15.5.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    No impact to Flutter Developers. Flutter Release/Infrastructure can't be upgraded to macOS 15 until this is landed in stable.
    
    ### Workaround:
    Is there a workaround for this issue?
    
    No
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    Run `Linux linux_web_engine_tests` on macOS 15.5
    flutteractionsbot authored Jul 21, 2025
    Configuration menu
    Copy the full SHA
    107d8df View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2025

  1. [CP stable] Run tests on either macOS 14 or 15 (#171076) (#172480)

    Impacted Users: Flutter Infra and Release teams
    Impact Description: Allows Flutter CI tests to run on macOS 15
    Workaround: N/A
    Risk: low
    Test Coverage: Yes
    Validation Steps: N/A
    
    Release note: This is a prerequisite to allowing stable branch to be upgraded to macOS 15
    
    Should **NOT** be landed until the following land:
    * #172461
    * #172462 land.
    vashworth authored Jul 22, 2025
    Configuration menu
    Copy the full SHA
    e11aada View commit details
    Browse the repository at this point in the history
  2. [CP][Android] Add a way to request new Surfaces from `SurfaceProduc…

    …er` … (#172384)
    
    Cherry-picks c7362b4 to 3.32 stable **without** the changes to the pre-existing `SurfaceProducer.getSurface` method, only the addition of `SurfaceProducer.getForcedNewSurface`.
    
    Note that this change is already present in the 3.35 beta.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    #155294, #169506
    
    ### Changelog Description:
    Adds a new method for requesting a new surface from the embedder than any previously returned.
    
    ### Impact Description:
    Developers using `SurfaceProducer.getForcedNewSurface` will receive a `Surface` that is different than previous calls to `SurfaceProducer.getForcedNewSurface` or pre-existing method  `SurfaceProducer.getSurface`.
    
    In other words, there is no impact to current users. This is a new method, so there will be a gap between 3.32.0 and 3.32.8, but I think it's worth landing because this would unblock fixing resuming/pausing the camera preview as described by the linked issues.
    
    ### Workaround:
    
    Working around the need for the new `getForcedSurface` method (like the `camera` issues linked above require) can be done by creating new `SurfaceProducer`s; however, this might have other side-effect unbeknownst to me.
    
    ### Risk:
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    
    You can test with flutter/packages#9360 (which I accidentally landed because I forgot this wasn't in stable yet...oops).
    camsim99 authored Jul 22, 2025
    Configuration menu
    Copy the full SHA
    77b8e5d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. [CP-stable]fix: macOS Mojave Crash on Flutter Desktop Startup (#172602)

    ### Issue Link:
    
    #172282 (comment)
    
    ### Changelog Description:
    
    Do not call an API that was introduced in macOS 10.15 on versions before 10.15.
    
    ### Impact Description:
    
    Apps will crash on macOS 10.14 (which is a supported platform according to https://docs.flutter.dev/reference/supported-platforms)
    
    ### Workaround:
    Is there a workaround for this issue?
    
    No
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    (Tests that run on current versions of macOS will confirm that this PR does not cause regressions.  But I don't know if we have any tests that run on macOS 10.14)
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    Run a Flutter app on macOS Mojave (10.14)
    flutteractionsbot authored Jul 23, 2025
    Configuration menu
    Copy the full SHA
    2350e38 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2025

  1. [CP-stable]Revert #160653 Fix view removal process for AutofillContex…

    …tAction.cancel (#172676)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    #172250
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
    
    Fixes a bug where `TextInput.hide` call incorrect clears the text in the active text field.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    If an app calls `TextInput.hide` to hide the software keyboard, the user input in the current active text field will also be erased. It impacts the production app.
    The framework itself doesn't seem to call `TextInput.hide` in a way that would affect the user.
    
    ### Workaround:
    Is there a workaround for this issue?
    
    Yes, in theory, developers can store and restore the `TextEditingValue`, when they need to call `TextInput.hide`, to undo the clear. However I suspect the reverted PR may also [break voiceover](#145681 (comment)).
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    This is a revert of #160653. The reverted PR was merged in February, and the previous implementation was [introduced in 2021](flutter/engine#23776).
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
      - [] No
    
    This change is a revert so the added test will also get reverted.
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    To verify the fix on master (it has already landed on master), run this app:
    ```dart
    import 'package:flutter/material.dart';
    import 'package:flutter/services.dart';
    
    void main() {
      runApp(const MyApp());
    }
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          title: 'Flutter Demo',
          debugShowCheckedModeBanner: false,
          theme: ThemeData(
            colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
            useMaterial3: true,
          ),
          home: const MyHomePage(),
        );
      }
    }
    
    class MyHomePage extends StatelessWidget {
      const MyHomePage({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return Scaffold(
          body: Center(
            child: SizedBox(
              child: ListView(
                children: [
                  TextButton(
                    child: Text('hide keyboard'),
                    onPressed: () =>
                        SystemChannels.textInput.invokeListMethod("TextInput.hide"),
                  ),
                  TextField(
                    controller: TextEditingController(text: '️a' * 20),
                    maxLines: 1,
                  ),
                ],
              ),
            ),
          ),
        );
      }
    }
    ```
    focus the text field and then click the hide keyboard button. The text "aaaaaa..." should remain after the button is clicked.
    flutteractionsbot authored Jul 24, 2025
    Configuration menu
    Copy the full SHA
    ef0cd00 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2025

  1. Configuration menu
    Copy the full SHA
    edada7c View commit details
    Browse the repository at this point in the history
Loading