Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d2da1b280b51
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 39651e84ea12
Choose a head ref
  • 18 commits
  • 27 files changed
  • 11 contributors

Commits on May 14, 2024

  1. Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) (#…

    …148338)
    
    flutter/engine@7bf8657...08b44d9
    
    2024-05-14 [email protected] [Impeller] migrated one test over from aiks to dl (flutter/engine#52786)
    2024-05-14 [email protected] [Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage (flutter/engine#52790)
    2024-05-14 [email protected] Refactor Semantics in preparation for ARC migration (flutter/engine#52729)
    2024-05-14 [email protected] Rolls in buildroot with stack protection flag (flutter/engine#52774)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 14, 2024
    Configuration menu
    Copy the full SHA
    034aa2f View commit details
    Browse the repository at this point in the history
  2. add another print trace to runInView (#148337)

    In service of #146879. See #146879 (comment). I wonder if something is going wrong in the process of subscribing to the isolate event stream in the VM service. This adds a print trace to the `catch` clause of this subscription call.
    andrewkolos authored May 14, 2024
    Configuration menu
    Copy the full SHA
    c7574be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a24b764 View commit details
    Browse the repository at this point in the history
  4. Move toggleable to widget layer (#148272)

    Currently, toggleable exists independently in the material and cupertino
    libraries. Cupertino's toggleable is a minimal copy of material's, and
    so it makes sense to have only one toggleable in the widgets layer.
    
    This change makes it easier for cupertino's toggleables (switch, radio,
    checkbox) to potentially have as many capabilities as material
    toggleables (for example, resolving in different widget states), thus
    increasing support for the cupertino library.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/wiki/Data-driven-Fixes
    
    ---------
    
    Co-authored-by: Pierre-Louis <[email protected]>
    victorsanni and guidezpl authored May 14, 2024
    Configuration menu
    Copy the full SHA
    7d92700 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4ecc1b0 View commit details
    Browse the repository at this point in the history
  6. Maintain the same layout constraints for item in the ReorderableList …

    …during dragging as before dragging. (#147863)
    
    Fixes #147419
    yiiim authored May 14, 2024
    Configuration menu
    Copy the full SHA
    e2ef38d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4a1e3ea View commit details
    Browse the repository at this point in the history
  8. Add missing InputDecorator.hintText tests (#148113)

    ## Description
    
    This PR reorganized some `InputDecorator.hintText` tests and add many of them (theses tests are organized similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs).
    
    This is somewhat repetitive but it helped me to catch two hint styling issues (wrong colors and font), I added TODOs because I will file the fixes once this PR is merged (just in case the fixes break some Google tests). The test I added are from lines 2779 to 3952 (below it is existing tests that I moved). 
    
    ## Related Issue
    
    Part of #139076
    bleroux authored May 14, 2024
    Configuration menu
    Copy the full SHA
    ced962d View commit details
    Browse the repository at this point in the history
  9. Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) (#…

    …148351)
    
    flutter/engine@ae9ff69...1b508a0
    
    2024-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] immediately encode blit commands for Metal. (#52795)" (flutter/engine#52816)
    2024-05-14 [email protected] [Impeller] immediately encode blit commands for Metal. (flutter/engine#52795)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 14, 2024
    Configuration menu
    Copy the full SHA
    2d3e55d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    de9ca5c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b23f346 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f335145 View commit details
    Browse the repository at this point in the history
  13. Bump codecov/codecov-action from 4.3.1 to 4.4.0 (#148355)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.4.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
    <blockquote>
    <h2>v4.4.0</h2>
    <h2>What's Changed</h2>
    <ul>
    <li>chore: Clarify isPullRequestFromFork by <a href="https://github.com/jsoref"><code>@�jsoref</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1411">codecov/codecov-action#1411</a></li>
    <li>build(deps): bump actions/checkout from 4.1.4 to 4.1.5 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1423">codecov/codecov-action#1423</a></li>
    <li>build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1421">codecov/codecov-action#1421</a></li>
    <li>build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1420">codecov/codecov-action#1420</a></li>
    <li>feat: remove GPG and run on spawn by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1426">codecov/codecov-action#1426</a></li>
    <li>build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.8.0 to 7.9.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1428">codecov/codecov-action#1428</a></li>
    <li>chore(release): 4.4.0 by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1430">codecov/codecov-action#1430</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0">https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/codecov/codecov-action/commit/6d798873df2b1b8e5846dba6fb86631229fbcb17"><code>6d79887</code></a> chore(release): 4.4.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1430">#1430</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/37364fa731f6f151c7b36cf5e9636df33c8a3544"><code>37364fa</code></a> build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.8.0 to 7.9.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1428">#1428</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/2791a5c4fec00bcacd1b1117999188e05a9e4660"><code>2791a5c</code></a> fix: remove GPG and run on spawn (<a href="https://redirect.github.com/codecov/codecov-action/issues/1426">#1426</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/b71af43c1ec8a1fcefe49210d6019eee9f95b0c6"><code>b71af43</code></a> build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1420">#1420</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/29f97fc54f5d3b739ff3eb4562ffa21bf391cd44"><code>29f97fc</code></a> build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1421">#1421</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/645d2a5926c80a56eded0d36b983cffd2d74aa23"><code>645d2a5</code></a> build(deps): bump actions/checkout from 4.1.4 to 4.1.5 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1423">#1423</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/f691d469fbba7b31a1cb026e3a2f86e28c9dcdb6"><code>f691d46</code></a> chore: Clarify isPullRequestFromFork (<a href="https://redirect.github.com/codecov/codecov-action/issues/1411">#1411</a>)</li>
    <li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/5ecb98a3c6b747ed38dc09f787459979aebb39be...6d798873df2b1b8e5846dba6fb86631229fbcb17">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.3.1&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored May 14, 2024
    Configuration menu
    Copy the full SHA
    cbc51f1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f9afa8f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ea85c56 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (#…

    …148365)
    
    flutter/engine@a1d930a...55c62ff
    
    2024-05-14 [email protected] [Impeller] reland: directly encode blit commands for Metal. (flutter/engine#52819)
    2024-05-14 [email protected] Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) (flutter/engine#52825)
    2024-05-14 [email protected] [docs] Suggest using same Xcode version as bots (flutter/engine#52821)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    dafce76 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (#…

    …148367)
    
    flutter/engine@55c62ff...d35a1a6
    
    2024-05-15 [email protected] Roll FreeType from af4c2d86 to bfc3453f (flutter/engine#52829)
    2024-05-14 [email protected] [Impeller] immediately encode blit commands for Vulkan. (flutter/engine#52794)
    2024-05-14 [email protected] Fix non-vd android platform view input event offsets (flutter/engine#52532)
    2024-05-14 [email protected] Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) (flutter/engine#52827)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    ddd6c86 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39651e8 View commit details
    Browse the repository at this point in the history
Loading