-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: cfbaa18bdecc
head repository: flutter/flutter
compare: 46b097a3070d
- 12 commits
- 100 files changed
- 14 contributors
Commits on Jul 28, 2025
-
[ios]update provisioning profile for 2025-2026 cert for chromium bots (…
…#171021) This updates provisioning profile mainly for chromium bots. Some devicelab tests also use this profile, according to #155101. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* #168427 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Victoria Ashworth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 053c8a5 - Browse repository at this point
Copy the full SHA 053c8a5View commit details -
Add Gemini Code Assist review config and style guide (#172785)
- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for b2cc192 - Browse repository at this point
Copy the full SHA b2cc192View commit details -
Add
--config-onlybuild option for Linux and Windows (#172239)Adds a `--config-only` option for Linux and Windows, which generates the native build files (ninja and Visual Studio respectively) without actually doing the build. This brings them into alignment with Android, iOS, and macOS, which already have this flag, and will allow some workflow improvements when running native plugin tests in environments like the flutter/packages CI. Fixes #93407 Fixes #172029 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3c9b128 - Browse repository at this point
Copy the full SHA 3c9b128View commit details -
[flutter_tools] Add --no-codesign support for macOS build (#169034)
Unlike iOS, the macOS build currently does not support `--no-codesign` option to skip signing of application bundle. Having this option is useful for situation where the code-signing step is happens separately after the bundle is built (i.e. on CI). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Victoria Ashworth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3ac59c9 - Browse repository at this point
Copy the full SHA 3ac59c9View commit details -
Reverts "[flutter_tools] Add --no-codesign support for macOS build (#…
…169034)" (#172878) <!-- start_original_pr_link --> Reverts: #169034 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: vashworth <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: failing in post-submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8708074284638575793/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: knopp <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi, vashworth} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Unlike iOS, the macOS build currently does not support `--no-codesign` option to skip signing of application bundle. Having this option is useful for situation where the code-signing step is happens separately after the bundle is built (i.e. on CI). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d060ae - Browse repository at this point
Copy the full SHA 4d060aeView commit details -
Reland licenses cpp switch (#172671)
changes since last land: 1) Now the license checker can trim matched licenses to remove regions that aren't apropos 1) There is a `.autoroller-preupload.sh` script that should update the LICENSE file when the autoroller executes relies on: - #172655 - https://skia-review.googlesource.com/c/buildbot/+/1025936 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 7063ea1 - Browse repository at this point
Copy the full SHA 7063ea1View commit details -
Roll Packages from 963550c to 6b2e34e (7 revisions) (#172869)
flutter/packages@963550c...6b2e34e 2025-07-28 [email protected] [interactive_media_ads] Adds support to set general SDK settings (flutter/packages#9648) 2025-07-28 [email protected] Roll Flutter from 20788c0 to cfbaa18 (43 revisions) (flutter/packages#9688) 2025-07-25 [email protected] Roll Flutter (stable) from d7b523b to edada7c (7 revisions) (flutter/packages#9677) 2025-07-25 [email protected] Resolve `android_build_all_packages` Warnings (flutter/packages#9643) 2025-07-25 [email protected] [video_player] Move Android to per-player-instance Pigeon APIs (flutter/packages#9511) 2025-07-24 [email protected] [ci] Re-enable wasm and Windows ARM64 tests (flutter/packages#9667) 2025-07-24 [email protected] Roll Flutter from afba7d7 to 20788c0 (27 revisions) (flutter/packages#9670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 24fc562 - Browse repository at this point
Copy the full SHA 24fc562View commit details -
[Flutter GPU] Fix Android/GLES crashers. (#172588)
Continuation of #165630. Resolves #164278. Resolves bdero/flutter_scene#35. Partly fixes: #160948. * Fixes OpenGLES crashers. * Threadsafe GLES pipeline creation. * Threadsafe GLES texture creation. * Fix GLES internal float texture formats. * Encode GLES passes on the raster thread. * Overwrite GLES textures on the raster thread. * Fixes vulkan memory leak (#164278).
Configuration menu - View commit details
-
Copy full SHA for 831a7a1 - Browse repository at this point
Copy the full SHA 831a7a1View commit details
Commits on Jul 29, 2025
-
Migrate Embedder code to impeller/DL geometry classes (#172804)
Ticks off another checkbox in #161456
Configuration menu - View commit details
-
Copy full SHA for 9e82be4 - Browse repository at this point
Copy the full SHA 9e82be4View commit details -
Revert "Remove 2023 deprecated
'platforms'key from daemon output (#……172593)" (#172883) This reverts commit cfe6f3d. The change broke the vscode extension. The extension has been updated in Dart-Code/Dart-Code#5610 but it is worth keeping this for a little while longer.
Configuration menu - View commit details
-
Copy full SHA for 7832d84 - Browse repository at this point
Copy the full SHA 7832d84View commit details -
Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149 https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
Configuration menu - View commit details
-
Copy full SHA for 9ceb761 - Browse repository at this point
Copy the full SHA 9ceb761View commit details -
Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783…
…)" (#172900) <!-- start_original_pr_link --> Reverts: #172783 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jtmcdole <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Failing in post submit tests: ``` ╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════ ║ UNEXPECTED ERROR! ║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm ║ #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9) ║ <asynchron <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: a-siva <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jason-simmons} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149 https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46b097a - Browse repository at this point
Copy the full SHA 46b097aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff cfbaa18bdecc...46b097a3070d