Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cd3aeef3a826
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ec387a467a68
Choose a head ref
  • 15 commits
  • 17 files changed
  • 6 contributors

Commits on Aug 27, 2023

  1. Roll Flutter Engine from b4e2758d6d43 to fc592728a7d0 (1 revision) (#… 

    …133410)

flutter/engine@b4e2758...fc59272

2023-08-27 [email protected] Roll Fuchsia Mac SDK from jZgLG9jWLutILTtsL... to 8nJB1-rSpC5L4digu... (flutter/engine#45156)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from jZgLG9jWLutI to 8nJB1-rSpC5L

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    3f5583c View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from fc592728a7d0 to 0593c0455fd6 (4 revisions) (#… 

    …133419)

flutter/engine@fc59272...0593c04

2023-08-27 [email protected] Roll Fuchsia Linux SDK from N-A8agqDgvTKiT2Wc... to jnDJLdEAx34diOWFx... (flutter/engine#45159)
2023-08-27 [email protected] [Impeller] SuboptimalKHR is not an exit condition. (flutter/engine#45157)
2023-08-27 [email protected] Use YAML >- to avoid strange formatting. (flutter/engine#45158)
2023-08-27 [email protected] [Impeller] Implement TextDecoration (i.e. dashed lines) (flutter/engine#45041)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from N-A8agqDgvTK to jnDJLdEAx34d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    6d22a11 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Roll Flutter Engine from 0593c0455fd6 to f8a171aa173f (1 revision) (#… 

    …133425)

flutter/engine@0593c04...f8a171a

2023-08-27 [email protected] Roll Fuchsia Mac SDK from 8nJB1-rSpC5L4digu... to xRUHI4zSil6TevQTa... (flutter/engine#45160)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 8nJB1-rSpC5L to xRUHI4zSil6T

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2660fdc View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from f8a171aa173f to 78c26aeff3ee (1 revision) (#… 

    …133428)

flutter/engine@f8a171a...78c26ae

2023-08-28 [email protected] Roll Skia from 0f9e50daa879 to 405c2ecb7f2a (1 revision) (flutter/engine#45161)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2e075d0 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 78c26aeff3ee to b26e2da130ab (2 revisions) (#… 

    …133432)

flutter/engine@78c26ae...b26e2da

2023-08-28 [email protected] Roll Skia from 2582a06b4618 to 1ce3c2af0971 (2 revisions) (flutter/engine#45163)
2023-08-28 [email protected] Roll Skia from 405c2ecb7f2a to 2582a06b4618 (1 revision) (flutter/engine#45162)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9218f93 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from b26e2da130ab to d89824ab018f (2 revisions) (#… 

    …133444)

flutter/engine@b26e2da...d89824a

2023-08-28 [email protected] Roll Skia from 1ce3c2af0971 to 0d39172f35d2 (1 revision) (flutter/engine#45164)
2023-08-28 [email protected] Manual roll Dart SDK from ab417bc74bb1 to 5d3ab5db5037 (17 revisions) (flutter/engine#45165)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7c13003 View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from d89824ab018f to 4924cf453398 (1 revision) (#… 

    …133447)

flutter/engine@d89824a...4924cf4

2023-08-28 [email protected] Roll Fuchsia Linux SDK from jnDJLdEAx34diOWFx... to AQZddYgKiWrQL8vny... (flutter/engine#45167)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from jnDJLdEAx34d to AQZddYgKiWrQ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8309216 View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 4924cf453398 to 9ab2603db24f (1 revision) (#… 

    …133449)

flutter/engine@4924cf4...9ab2603

2023-08-28 [email protected] Roll Fuchsia Mac SDK from xRUHI4zSil6TevQTa... to u44zzvYd85WSDMpS3... (flutter/engine#45168)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from xRUHI4zSil6T to u44zzvYd85WS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0027d18 View commit details
    Browse the repository at this point in the history

  7. PlatformRouteInformationProvider should dispatch creation in construc… 

    …tor. (#133353)
    @polina-c
    polina-c authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2ea5296 View commit details
    Browse the repository at this point in the history

  8. added option to change color of heading row(#132428) (#132728) 

    Paginated datatable widget cannot give color to table header
 
fixes #132428

---------

Co-authored-by: Hans Muller <[email protected]>
    @salmanulfarisi @HansMuller
    salmanulfarisi and HansMuller authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    69f61a2 View commit details
    Browse the repository at this point in the history

  9. Fix stuck predictive back platform channel calls (#133368) 

    Fix a Google test flakiness increase.
    @justinmc
    justinmc authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    dfd4147 View commit details
    Browse the repository at this point in the history

  10. ShortcutManager should dispatch creation in constructor. (#133356)

    @polina-c
    polina-c authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cf91262 View commit details
    Browse the repository at this point in the history

  11. FocusNode and FocusManager should dispatch creation in constructor. (#… 

    …133352)
    @polina-c
    polina-c authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    703d60b View commit details
    Browse the repository at this point in the history

  12. Roll Flutter Engine from 9ab2603db24f to 91522a188bda (2 revisions) (#… 

    …133462)

flutter/engine@9ab2603...91522a1

2023-08-28 [email protected] Roll Skia from fe4f018ef935 to df783b542165 (1 revision) (flutter/engine#45171)
2023-08-28 [email protected] Roll Skia from 0d39172f35d2 to fe4f018ef935 (1 revision) (flutter/engine#45169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    05259ca View commit details
    Browse the repository at this point in the history

  13. Revert "ShortcutManager should dispatch creation in constructor." (#1… 

    …33472)

Reverts #133356

Tree is failing on customer_testing on this PR.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview
    @vashworth
    vashworth authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ec387a4 View commit details
    Browse the repository at this point in the history
Loading