Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cb26a01a40e9
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 656447127360
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on May 25, 2024

  1. Fix Linux numpad shortcuts on web (#148988) 

    ## Description

This PRs fixes a Web issue on Linux related to numpad keys.
In #145464, I introduced numpad shortcuts for Linux. These shortcuts work well on a desktop Linux application but they broke the Linux+Web numpad logic.

When I added these shortcuts, I expected them to not be active on Web (because I knew that on Web, those shortcuts are handled by the browser). But there is a trick: text editing shortcuts are still defined on Web but they are disabled at the editable text level so one can use them in components that are not `EditableText` (see #103377).
In this PR, I used the same approach than for other text editing shortcuts: when on web associate those shortcuts to the `DoNothingAndStopPropagationTextIntent` intent.

## Related Issue

Fixes #148447.

## Tests

Updates 2 tests.
Adds 2 tests.
    @bleroux
    bleroux authored May 25, 2024
    Configuration menu
    Copy the full SHA
    0f3882e View commit details
    Browse the repository at this point in the history

  2. Manual roll Flutter Engine from 1d154ff93a87 to a207dfe8e96b (10 revi… 

    …sions) (#149096)

Manual roll requested by [email protected]

flutter/engine@1d154ff...a207dfe

2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (#53032)" (flutter/engine#53041)
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (#53036)" (flutter/engine#53040)
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (#53037)" (flutter/engine#53039)
2024-05-25 [email protected] Roll Skia from 6e42cb7a099d to 93ef9f3c4f39 (1 revision) (flutter/engine#53038)
2024-05-25 [email protected] Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (flutter/engine#53037)
2024-05-25 [email protected] Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (flutter/engine#53036)
2024-05-25 [email protected] Roll Fuchsia Linux SDK from 9PoD1BZXVglZ-EWu3... to j_hH7zx04OsJaL9p2... (flutter/engine#53035)
2024-05-25 [email protected] Roll Skia from a783c0c8df89 to 6e42cb7a099d (1 revision) (flutter/engine#53034)
2024-05-25 [email protected] Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (flutter/engine#53032)
2024-05-25 [email protected] Roll Skia from 7eb8515603c1 to a783c0c8df89 (1 revision) (flutter/engine#53033)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 9PoD1BZXVglZ to j_hH7zx04OsJ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored May 25, 2024
    Configuration menu
    Copy the full SHA
    e2c25b2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Roll Flutter Engine from a207dfe8e96b to f3025ae1511b (1 revision) (#… 

    …149098)

flutter/engine@a207dfe...f3025ae

2024-05-26 [email protected] Roll Skia from 93ef9f3c4f39 to f357c9f2781c (1 revision) (flutter/engine#53045)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored May 26, 2024
    Configuration menu
    Copy the full SHA
    6564471 View commit details
    Browse the repository at this point in the history
Loading