-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: cb18290fa45e
head repository: flutter/flutter
compare: 4c910983cbfd
- 9 commits
- 32 files changed
- 6 contributors
Commits on Oct 24, 2025
-
[web] Use SkPathBuilder because SkPath is becoming immutable (#177343)
Skia is working on making `SkPath` immutable: https://skia-review.googlesource.com/c/skia/+/1075478 In Flutter Web's CanvasKit renderer, we use `SkPath` as a mutable object, which made the [Skia roll](#177184) fail. To fix this, we should start using `SkPathBuilder` instead. Remaining work: - [x] Figure out the deletion/disposal of `SkPath`s generated from `.snapshot()` calls. - [ ] `LazyPath` should be restructured to better accommodate a world of immutable paths and path builders (coming in a future PR).
Configuration menu - View commit details
-
Copy full SHA for 3759033 - Browse repository at this point
Copy the full SHA 3759033View commit details -
Bump Templates To Correct Versions (#177416)
I bumped templates to the correct versions. I also included a fix for kgp and agp compatability. AGP 8.11.0 -> 8.11.1 Gradle 8.13 -> 8.14 KGP 2.2.0 -> 2.2.20 I ran `flutter analyze --suggestions` and `flutter build apk` to ensure these are safe versions. Will cherry pick this to beta after the pr merges. Fixes #177320 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 3c04c99 - Browse repository at this point
Copy the full SHA 3c04c99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8180ae0 - Browse repository at this point
Copy the full SHA 8180ae0View commit details
Commits on Oct 25, 2025
-
Roll Skia from e91d238ce638 to f352da2d607f (4 revisions) (#177525)
https://skia.googlesource.com/skia.git/+log/e91d238ce638..f352da2d607f 2025-10-24 [email protected] Reland "Make SkPath immutable on GN build" 2025-10-24 [email protected] Build everything with c++20 2025-10-24 [email protected] Set reuseRequiresPurgeable flag for Grahpite Vk resources. 2025-10-24 [email protected] Update SkPathBuilder::reset() docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4f36fce - Browse repository at this point
Copy the full SHA 4f36fceView commit details -
Roll Skia from f352da2d607f to b85c7ae19092 (1 revision) (#177539)
https://skia.googlesource.com/skia.git/+log/f352da2d607f..b85c7ae19092 2025-10-25 [email protected] Roll vulkan-deps from 00a17acf0058 to 26d980ac653d (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f62f80b - Browse repository at this point
Copy the full SHA f62f80bView commit details -
Fix DropdownMenu filtering is broken (#177450)
## Description This PR fixes `DropdownMenu` filtering. This is mainly a revert of #162062. It adds a test to avoid a similar regression in the future. It will reeopen #155660. A future PR will try to fix that issue. See #174757 (comment) for more context. ## Related Issue Fixes [DropdownMenu filtering is broken](#174609) Reeopens [DropdownMenu.didUpdateWidget should re-match initialSelection when dropdownMenuEntries have changed](#155660) ## Tests Adds 1 test. Removes 3 tests (reverted tests from #162062).
Configuration menu - View commit details
-
Copy full SHA for b05f001 - Browse repository at this point
Copy the full SHA b05f001View commit details -
Make sure that a DropdownMenu doesn't crash in 0x0 environment (#174809)
This is my attempt to handle #6537 for the DropdownMenu widget.
Configuration menu - View commit details
-
Copy full SHA for 673023b - Browse repository at this point
Copy the full SHA 673023bView commit details
Commits on Oct 26, 2025
-
Roll Skia from b85c7ae19092 to de52b3a7585a (1 revision) (#177550)
https://skia.googlesource.com/skia.git/+log/b85c7ae19092..de52b3a7585a 2025-10-26 [email protected] Roll vulkan-deps from 26d980ac653d to aff9933d5aca (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f13db12 - Browse repository at this point
Copy the full SHA f13db12View commit details -
Roll ICU from ff35c4f9df23 to f27805b7d7d8 (1 revision) (#177558)
https://chromium.googlesource.com/chromium/deps/icu.git/+log/ff35c4f9df23..f27805b7d7d8 2025-10-23 [email protected] [intl] Update filter rule for android,cast,chromecast,ios If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4c91098 - Browse repository at this point
Copy the full SHA 4c91098View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff cb18290fa45e...4c910983cbfd