Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cb18290fa45e
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4c910983cbfd
Choose a head ref
  • 9 commits
  • 32 files changed
  • 6 contributors

Commits on Oct 24, 2025

  1. [web] Use SkPathBuilder because SkPath is becoming immutable (#177343)

    Skia is working on making `SkPath` immutable:
    https://skia-review.googlesource.com/c/skia/+/1075478
    
    In Flutter Web's CanvasKit renderer, we use `SkPath` as a mutable
    object, which made the [Skia
    roll](#177184) fail. To fix this,
    we should start using `SkPathBuilder` instead.
    
    Remaining work:
    - [x] Figure out the deletion/disposal of `SkPath`s generated from
    `.snapshot()` calls.
    - [ ] `LazyPath` should be restructured to better accommodate a world of
    immutable paths and path builders (coming in a future PR).
    mdebbar authored Oct 24, 2025
    Configuration menu
    Copy the full SHA
    3759033 View commit details
    Browse the repository at this point in the history
  2. Bump Templates To Correct Versions (#177416)

    I bumped templates to the correct versions. I also included a fix for
    kgp and agp compatability.
    
    AGP 8.11.0 -> 8.11.1
    Gradle 8.13 -> 8.14
    KGP 2.2.0 -> 2.2.20
    
    I ran `flutter analyze --suggestions` and `flutter build apk` to ensure
    these are safe versions.
    
    Will cherry pick this to beta after the pr merges.
    
    Fixes #177320
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    jesswrd authored Oct 24, 2025
    Configuration menu
    Copy the full SHA
    3c04c99 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8180ae0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2025

  1. Roll Skia from e91d238ce638 to f352da2d607f (4 revisions) (#177525)

    engine-flutter-autoroll authored Oct 25, 2025
    Configuration menu
    Copy the full SHA
    4f36fce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f62f80b View commit details
    Browse the repository at this point in the history
  3. Fix DropdownMenu filtering is broken (#177450)

    ## Description
    
    This PR fixes `DropdownMenu` filtering.
    This is mainly a revert of
    #162062.
    It adds a test to avoid a similar regression in the future.
    
    It will reeopen #155660. A
    future PR will try to fix that issue.
    
    See
    #174757 (comment)
    for more context.
    
    ## Related Issue
    
    Fixes [DropdownMenu filtering is
    broken](#174609)
    Reeopens [DropdownMenu.didUpdateWidget should re-match initialSelection
    when dropdownMenuEntries have
    changed](#155660)
    
    ## Tests
    
    Adds 1 test.
    Removes 3 tests (reverted tests from
    #162062).
    bleroux authored Oct 25, 2025
    Configuration menu
    Copy the full SHA
    b05f001 View commit details
    Browse the repository at this point in the history
  4. Make sure that a DropdownMenu doesn't crash in 0x0 environment (#174809)

    This is my attempt to handle
    #6537 for the DropdownMenu
    widget.
    ahmedsameha1 authored Oct 25, 2025
    Configuration menu
    Copy the full SHA
    673023b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2025

  1. Configuration menu
    Copy the full SHA
    f13db12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c91098 View commit details
    Browse the repository at this point in the history
Loading