-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: be698c48a675
head repository: flutter/flutter
compare: b25305a8832c
- 11 commits
- 25 files changed
- 6 contributors
Commits on May 20, 2025
-
[CP: 3.32] [Widget Inspector] Update on-device inspector button to ge…
…neric unicode icon (#169092) ### Issue Link: What is the link to the issue this cherry-pick is addressing? #168846 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples This cherry pick fixes an issue where some users would see a question mark instead of the appropriate icon in the widget inspector button which toggles select-mode on/off. ### Impact Description: Users who don't have `cupertino_icons` as a dependency in their pubspec will see a question mark in one of the widget inspector buttons. <img width="169" alt="Screenshot 2025-05-19 at 12 50 15 PM" src="https://github.com/user-attachments/assets/40cd01c9-f8a6-407d-9d1b-303bc1516d62" /> ### Workaround: Is there a workaround for this issue? Yes, add `cupertino_icons` package to user's pubspec. ### Risk: What is the risk level of this cherry-pick? Low ### Test Coverage: Are you confident that your fix is well-tested by automated tests? This was tested manually, there are no screenshot tests for this. However, this is only a UI change and not a behavior change. ### Validation Steps: What are the steps to validate that this fix works? 1. Run an app that doesn't have `cupertino_icons` in its pubspec 2. Open Flutter DevTools > Inspector 3. Enable select widget mode 4. Should not see a ? on any of the buttons
Configuration menu - View commit details
-
Copy full SHA for 673806f - Browse repository at this point
Copy the full SHA 673806fView commit details
Commits on May 23, 2025
-
[CP-stable][reland] Fix regression in NDK version checking (#169289)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? There was no associated issue, but the problem is that #166727 broke Flutter Android builds on apps that use plugins with AGP versions less than 8.2. ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes Flutter Android builds for apps which use plugins with old Android Gradle Plugin versions. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) The impact is a crash in the build process. ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Build an app that uses AGP < 8.2.
Configuration menu - View commit details
-
Copy full SHA for 44b32ec - Browse repository at this point
Copy the full SHA 44b32ecView commit details -
[CP-stable]Skip running
Linux fuchsia_teston non-master channel. (#……169380) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #169101 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Reduces the cost of running the (sometimes flaky) `Linux fuchsia_test` on release branches. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) N/A - CI infra optimization. ### Workaround: Is there a workaround for this issue? N/A - CI infra optimization ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A - CI infra optimization
Configuration menu - View commit details
-
Copy full SHA for 6e07e1f - Browse repository at this point
Copy the full SHA 6e07e1fView commit details
Commits on May 27, 2025
-
[CP-stable]Use
.flutter-plugins-dependenciesfor crash reporting. (#……169484) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #169319 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixed a bug where the `flutter` tool crash reporting did not include what plugins were being used by the current project. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Tool crash reports are missing plugins in use. ### Workaround: Is there a workaround for this issue? Yes, `flutter config --no-explicit-package-dependencies`, but that has other project impact, or copying and pasting the plugins manually. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? See unit tests.
Configuration menu - View commit details
-
Copy full SHA for 9057717 - Browse repository at this point
Copy the full SHA 9057717View commit details -
[stable] Roll
package:ddsto 5.0.2 (#169471) (#169515)Fixes #156793 ### Issue Link: #156793 ### Changelog Description: Fix flaky crash when targeting web applications via IDEs using the DAP. ### Impact Description: The `flutter debug-adapter` process started by IDEs can crash when requesting isolate information from a Flutter web application that has disposed its isolate (i.e., at shutdown or due to a hot restart). This is the top crasher for `flutter_tools`, accounting for ~66% of all crashes for 3.32.0. ### Workaround: Is there a workaround for this issue? No. ### Risk: This CP is low risk as only additional exception handling was added to the DAP logic in `package:dds` (see https://dart-review.googlesource.com/c/sdk/+/431060) to handle the specific case outlined in the issue. ### Test Coverage: This issue is difficult to reproduce without injecting test-only code via custom VM service RPCs across multiple repositories. Testing was done manually with this approach, but the testing code is not committed. ### Validation Steps: IDE extensions don't crash when interacting with Flutter Web applications during hot restart / application shutdown.
Configuration menu - View commit details
-
Copy full SHA for 80f085c - Browse repository at this point
Copy the full SHA 80f085cView commit details
Commits on May 28, 2025
-
Roll Skia to the flutter/3.32 branch (#169531)
That branch includes a cherry pick of a fix for #168849
Configuration menu - View commit details
-
Copy full SHA for c56879b - Browse repository at this point
Copy the full SHA c56879bView commit details -
[CP-stable]Fixes tab semantics gets dropped if the child produce a se…
…mantics node (#169362) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #169175 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixed unexpected crash when using Tab and TabBar widgets. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) app crash ### Workaround: Is there a workaround for this issue? Wrap the Tab widget with a MergeSemantics widget will mitigate the issue. ### Risk: What is the risk level of this cherry-pick? - [O] Low ### Test Coverage: Are you confident that your fix is well-tested by automated tests? - [O] Yes ### Validation Steps: What are the steps to validate that this fix works? create a TabBar that has a Tab with image widget ```dart TabBar( tabs: <Widget>[ Tab(icon: Image.network('https://some-url')), Tab(icon: Icon(Icons.beach_access_sharp)), Tab(icon: Icon(Icons.brightness_5_sharp)), ], ), ```
Configuration menu - View commit details
-
Copy full SHA for 7d3efe4 - Browse repository at this point
Copy the full SHA 7d3efe4View commit details -
Update dart revision (3.8.1) for 3.32.1 release (#169601)
This updated the dart revision for the upcoming flutter stable release, 3.32.1
Configuration menu - View commit details
-
Copy full SHA for 1425e5e - Browse repository at this point
Copy the full SHA 1425e5eView commit details
Commits on May 29, 2025
-
Update
engine.versionto1425e5e9ec5eeb4f225c401d8db69b860e0fde9a. (#169675) ```sh git log -1 --pretty=format:%H -- "$(git rev-parse --show-toplevel)/DEPS" "$(git rev-parse --show-toplevel)/engine" ```
Configuration menu - View commit details
-
Copy full SHA for 6374794 - Browse repository at this point
Copy the full SHA 6374794View commit details -
[CP-stable]Roll forward: "Initialize default-app-flavor" (#169298) (#…
…169623) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #169602 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes a bug where `appFlavor` is `null` when being run with `flutter test` or being hot-restarted. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Cannot reliably use `appFlavor` without rebuilding the app from scratch. ### Workaround: Is there a workaround for this issue? Do not use hot restart, do not use `flutter test`. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Automated test coverage.
Configuration menu - View commit details
-
Copy full SHA for 0a159b3 - Browse repository at this point
Copy the full SHA 0a159b3View commit details -
Update engine.version and changelog for upcoming stable release 3.32.1 (
#169619) Update engine.version and changelog for upcoming stable release 3.32.1
Configuration menu - View commit details
-
Copy full SHA for b25305a - Browse repository at this point
Copy the full SHA b25305aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff be698c48a675...b25305a8832c