-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: bd836cc63ae0
head repository: flutter/flutter
compare: deeb811ef0bb
- 17 commits
- 26 files changed
- 10 contributors
Commits on Aug 23, 2023
-
Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (#…
…133158) flutter/engine@72a0642...ac352ba 2023-08-23 [email protected] Roll Skia from d0c369eaa637 to 2111e8126c08 (1 revision) (flutter/engine#45002) 2023-08-23 [email protected] Roll Fuchsia Linux SDK from VSvpNFoFjqXIQTcs6... to -HcyJtxGxUDcqX-jo... (flutter/engine#44999) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VSvpNFoFjqXI to -HcyJtxGxUDc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8ba40bb - Browse repository at this point
Copy the full SHA 8ba40bbView commit details -
Add
--experimental-wasm-type-reflectionand support newer emscripte……n builds. (#133084) This makes two changes to prepare for incoming changes to skwasm in the web engine: * We will (at least for now) be depending on the `WebAssembly.Function` constructor in `skwasm`, which is hidden behind the `--experimental-wasm-type-reflection` flag. We need to pass that when running skwasm benchmarks. * We are going to be upgrading the skwasm build to a newer version of emscripten, which exposes the wasm exports via the `wasmExports` property instead of the `asm` property. Make sure to support either, if passed.
Configuration menu - View commit details
-
Copy full SHA for d8b1e81 - Browse repository at this point
Copy the full SHA d8b1e81View commit details -
[web] Remove unnecessary lint ignore (#133164)
This became unnecessary since #132087
Configuration menu - View commit details
-
Copy full SHA for fd155a3 - Browse repository at this point
Copy the full SHA fd155a3View commit details -
Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (#…
…133165) flutter/engine@ac352ba...58dc868 2023-08-23 [email protected] Roll Skia from 2111e8126c08 to 5428f147e632 (2 revisions) (flutter/engine#45008) 2023-08-23 [email protected] Roll Fuchsia Mac SDK from DoQ8KUxSk-5EU6VQ1... to vJ6oaubpqgRM2nb1e... (flutter/engine#45005) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from DoQ8KUxSk-5E to vJ6oaubpqgRM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3cfaa34 - Browse repository at this point
Copy the full SHA 3cfaa34View commit details -
Remove deprecated *TestValues from TestWindow (#131098)
Part of #133171. Removes from `TestWindow`: * `localeTestValue` * `clearLocaleTestValue` * `localesTestValue` * `clearLocalesTestValue` * `initialLifecycleStateTestValue` * `alwaysUse24HourFormatTestValue` * `clearAlwaysUse24HourTestValue` * `brieflyShowPasswordTestValue` * `defaultRouteNameTestValue` * `clearDefaultRouteNameTestValue` * `semanticsEnabledTestValue` * `clearSemanticsEnabledTestValue` * `accessibilityFeaturesTestValue` * `clearAccessibilityFeaturesTestValue` These properties have reached the end of their deprecation period.
Configuration menu - View commit details
-
Copy full SHA for ad78cf3 - Browse repository at this point
Copy the full SHA ad78cf3View commit details -
[flutter_tools] Fix legacy version file not being ensured (#133097)
Fixes #133093 When I introduced the new, more robust version file `//flutter/bin/cache/version.json` in #124558, I changed `class FlutterVersion` into an abstract interface, implemented by `_FlutterVersionFromGit` (which is essentially the previous behavior) and `_FlutterVersionFromFile`, which merely reads the data it would have computed via git from `//flutter/bin/cache/version.json`. While doing this, I made `_FlutterVersionFromGit.ensureVersionFile()` to be a no-op, since I assumed this would not be necessary since we already had a version file in the cache. However, this method was what was previously responsible for ensuring `//flutter/version` existed on disk. This means that if, for whatever reason, the user had `//flutter/bin/cache/flutter.version.json` present but NOT `//flutter/version`, the tool would have never created that file, and they would hit the tool crash seen in #133093. This fixes the tool by ensuring `//flutter/version` exists regardless of if we're hydrating `FlutterVersion` from `//flutter/bin/cache/flutter.version.json` or not.
Configuration menu - View commit details
-
Copy full SHA for 9e59a68 - Browse repository at this point
Copy the full SHA 9e59a68View commit details -
Bump memory usage in gradle for platform views (#133155)
fixes #133119 Similar to #131006 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for 6fd3387 - Browse repository at this point
Copy the full SHA 6fd3387View commit details -
Add android analyzer commands for applinks (#131009)
Since applink validation tool is going to be a static tool, It won't have access to vmservices. [flutter.dev/go/static-tooling-in-devtools](http://flutter.dev/go/static-tooling-in-devtools) I remove the vm services and also update the deeplink task to also include path pattern and custom scheme http://go/android-applink-apis (internal only)
Configuration menu - View commit details
-
Copy full SHA for 4930613 - Browse repository at this point
Copy the full SHA 4930613View commit details -
Enable literal_only_boolean_expressions (#133186)
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
Configuration menu - View commit details
-
Copy full SHA for 382ceb5 - Browse repository at this point
Copy the full SHA 382ceb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89907f6 - Browse repository at this point
Copy the full SHA 89907f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c69fd5 - Browse repository at this point
Copy the full SHA 8c69fd5View commit details -
Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (#…
…133211) flutter/engine@58dc868...27d75f6 2023-08-23 [email protected] Roll Skia from 76898dad9fda to a631fefdba37 (2 revisions) (flutter/engine#45027) 2023-08-23 [email protected] Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#45023) 2023-08-23 [email protected] [Impeller] Dat rvalue reference (fix engine head) (flutter/engine#45024) 2023-08-23 [email protected] Revert "Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param`" (flutter/engine#45020) 2023-08-23 [email protected] Roll Skia from 4e42b51cfe27 to 76898dad9fda (1 revision) (flutter/engine#45019) 2023-08-23 [email protected] [Impeller] Add STB text backend. (flutter/engine#44887) 2023-08-23 [email protected] Followup to flutter/engine#44982 (flutter/engine#45018) 2023-08-23 [email protected] Roll Skia from 5428f147e632 to 4e42b51cfe27 (4 revisions) (flutter/engine#45016) 2023-08-23 [email protected] Eliminate android test log spam (flutter/engine#44982) 2023-08-23 [email protected] [web] Remove some unused functions (flutter/engine#44505) 2023-08-23 [email protected] Use decal TileMode in blur image_filter_test.dart (flutter/engine#45004) 2023-08-23 [email protected] FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#44996) 2023-08-23 [email protected] [impeller] combine sampler and texture maps. (flutter/engine#44990) 2023-08-23 [email protected] [Impeller] Flutter GPU: Add HostBuffer. (flutter/engine#44696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for cfe41a6 - Browse repository at this point
Copy the full SHA cfe41a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87c1a46 - Browse repository at this point
Copy the full SHA 87c1a46View commit details
Commits on Aug 24, 2023
-
Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (#…
…133214) flutter/engine@27d75f6...67e8b82 2023-08-23 [email protected] [Impeller] combine uniform metadata and buffer slots. (flutter/engine#45021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for dc7fa47 - Browse repository at this point
Copy the full SHA dc7fa47View commit details -
Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (#…
…133220) flutter/engine@67e8b82...aa98a9d 2023-08-24 [email protected] [Impeller] Fix stencil buffer format selection on Vulkan backend, add support for D24UnormS8Uint (flutter/engine#45025) 2023-08-24 [email protected] Fix a clang-tidy error seen in the latest toolchain roll (flutter/engine#45039) 2023-08-23 [email protected] Roll Skia from a631fefdba37 to 9d4db3443527 (1 revision) (flutter/engine#45031) 2023-08-23 [email protected] Roll clang with fix for ABI change (flutter/engine#44711) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b32cd68 - Browse repository at this point
Copy the full SHA b32cd68View commit details -
Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#…
…133224) flutter/engine@aa98a9d...3b92bb6 2023-08-24 [email protected] [Impeller] Add debug captures and inspector. (flutter/engine#43764) 2023-08-24 [email protected] Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (flutter/engine#45042) 2023-08-24 [email protected] Remove a clang-tidy test that launches a full run of clang-tidy (flutter/engine#45033) 2023-08-24 [email protected] Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (flutter/engine#45036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for bede50c - Browse repository at this point
Copy the full SHA bede50cView commit details -
Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 rev…
…isions) (#133224)" (#133255) Reverts #133224 Reverting for failing wide gamut test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview
Configuration menu - View commit details
-
Copy full SHA for deeb811 - Browse repository at this point
Copy the full SHA deeb811View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff bd836cc63ae0...deeb811ef0bb