Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bae5e49bc2a8
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: abb292a07e20
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 20, 2024

  1. [CP-stable]instead of exiting the tool, print a warning when using --… 

    …flavor with an incompatible device (#143785)

**This pull request is opened against a release branch.<br>
To request a cherry pick of a commit, please fill in the form below.** (Questions with an asterisk are required.)<br>

**To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords. <br>
A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.**

* Issue Link: What is the link to the issue this cherry-pick is addressing?<br>

<pre>
  <b>My Answer:</b>
#143574

</pre>

* Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers
        See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples (Bug fix, feature, docs update, ...)<br>

<pre>
  <b>My Answer:</b>

Instead of exiting, the `flutter` CLI tool now prints a warning when the `--flavor` option is used with a target platform that doesn't have flavors support.
</pre>

* impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)<br>

<pre>
  <b>My Answer:</b>
All Flutter devs using the Flavors feature that use their IDE to select a target device.

</pre>

* Workaround: Is there a workaround for this issue?<br>

<pre>
  <b>My Answer:</b> Users can create duplicate debug launch configurations for target platforms that do not support the flavors feature.
</pre>

* Risk: What is the risk level of this cherry-pick?<br>

<pre>
  <b>My Answer:</b>

</pre>

* Test Coverage: Are you confident that your fix is well-tested by automated tests?<br>

<pre>
  <b>My Answer:</b>

</pre>

* Validation Steps: What are the steps to validate that this fix works?<br>

<pre>
  <b>My Answer:</b>

Set up a flutter project and configure at least one flavor for it. In VSCode, create a launch configuration that uses `--flavor` to select the flavor you configured (see #143574 (comment) for an example). In VSCode, select chrome as the target device and try running the application using the configured launch configuration.

</pre>
    @flutteractionsbot
    flutteractionsbot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    abb292a View commit details
    Browse the repository at this point in the history
Loading