Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b77560e92a58
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c30f998eb5db
Choose a head ref
  • 12 commits
  • 36 files changed
  • 7 contributors

Commits on Feb 26, 2024

  1. Roll Packages from 7df2085 to 353086c (7 revisions) (#144144) 

    flutter/packages@7df2085...353086c

2024-02-26 [email protected] [google_map_flutter] Add style to widget - platform interface (flutter/packages#6197)
2024-02-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.4 to 3.24.5 (flutter/packages#6204)
2024-02-25 [email protected] Roll Flutter from f6c1082 to 1e8dd1e (3 revisions) (flutter/packages#6203)
2024-02-24 [email protected] Roll Flutter from 39585e6 to f6c1082 (20 revisions) (flutter/packages#6200)
2024-02-23 [email protected] Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter/packages#6194)
2024-02-23 [email protected] [camera] Document -1 return value for `getExposureOffsetStepSize` (flutter/packages#6182)
2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/packages#6184)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d05eaf4 View commit details
    Browse the repository at this point in the history

  2. Update copyDirectory to allow links to not be followed (#144040) 

    In other words, copy links within a directory as links rather than copying them as files/directories. 

Fixes #144032.
    @vashworth
    vashworth authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    45c8881 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (#… 

    …144145)

flutter/engine@a15326b...7a573c2

2024-02-26 [email protected] Roll Skia from cb2a47da08b7 to ba3ed5998af3 (2 revisions) (flutter/engine#50966)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    96dc989 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (#… 

    …144147)

flutter/engine@7a573c2...34a8b9b

2024-02-26 [email protected] Add Platform View Manager to Windows shell (flutter/engine#50598)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    469a233 View commit details
    Browse the repository at this point in the history

  5. Implementing switch expressions in rendering/ (#143812) 

    This pull request is part of the effort to solve issue #136139.

The previous [`switch` expressions PR](#143496) was comprised of many simple changes throughout `flutter/lib/src/`, but due to some more in-depth refactoring in `flutter/lib/src/rendering/`, I decided to submit the changes to this directory as a separate pull request.

There was really just one function that I changed significantly; I'll add a comment for explanation.
    @nate-thegrate
    nate-thegrate authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    60d28ad View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (#… 

    …144159)

flutter/engine@34a8b9b...04ff286

2024-02-26 [email protected] [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9d53808 View commit details
    Browse the repository at this point in the history

  7. refactor: Differentiate pubspec and resolution errors for plugins (#1… 

    …42035)

Part of #137040 and #80374

- Differentiate pubspec and resolution errors
- Rename platform to platformKey
- Add TODO for rework logic of flag [throwOnPluginPubspecError]
- Swap for loop: handle by platform and then by plugin
    @Gustl22
    Gustl22 authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b4f925e View commit details
    Browse the repository at this point in the history

  8. Mark firebase_release_smoke_test as bringup: true (#144186) 

    #144183
    @keyonghan
    keyonghan authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c82ca46 View commit details
    Browse the repository at this point in the history

  9. Allow Listenable.merge() to use any iterable (#143675) 

    This is a very small change that fixes #143664.
    @nate-thegrate
    nate-thegrate authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7b5ec58 View commit details
    Browse the repository at this point in the history

  10. Move debugShowWidgetInspectorOverride (#144029) 

    Contributes to dart-lang/leak_tracker#218
    @polina-c
    polina-c authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    523b0c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (#… 

    …144208)

flutter/engine@04ff286...0bc21ea

2024-02-27 [email protected] Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989)
2024-02-27 [email protected] Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998)
2024-02-27 [email protected] Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996)
2024-02-27 [email protected] Fix usage of `--out-dir` with a relative path. (flutter/engine#50992)
2024-02-27 [email protected] Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991)
2024-02-27 [email protected] Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995)
2024-02-27 [email protected] Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993)
2024-02-27 [email protected] Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985)
2024-02-26 [email protected] Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980)
2024-02-26 [email protected] [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981)
2024-02-26 [email protected] [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983)
2024-02-26 [email protected] Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979)
2024-02-26 [email protected] Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327)
2024-02-26 [email protected] [Impeller] disble render pass caches. (flutter/engine#50976)
2024-02-26 [email protected] Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971)
2024-02-26 [email protected] [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883)
2024-02-26 [email protected] Better filtering for Android `scenario_app` runner. (flutter/engine#50937)
2024-02-26 [email protected] Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920)
2024-02-26 [email protected] Correctly offset the cull rect of the opacity layer. (flutter/engine#50928)
2024-02-26 [email protected] Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    331769f View commit details
    Browse the repository at this point in the history

  2. [flutter_tools] Fix missing stack trace from daemon (#144113) 

    When the daemon throws an exception, the receiving client is unable to surface stack traces from the daemon.

This is because it is sent with the `trace` key here:

https://github.com/flutter/flutter/blob/1e8dd1e4d6d70c5e06525bea3fb164a03d7a6c1d/packages/flutter_tools/lib/src/daemon.dart#L308

But the client tries to read it with the `stackTrace` key here:

https://github.com/flutter/flutter/blob/1e8dd1e4d6d70c5e06525bea3fb164a03d7a6c1d/packages/flutter_tools/lib/src/daemon.dart#L343

Thanks to @mraleph for spotting this!

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

b/326825892
    @jiahaog
    jiahaog authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c30f998 View commit details
    Browse the repository at this point in the history
Loading