Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b3f99ffe610a
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c00d241938b1
Choose a head ref
  • 12 commits
  • 193 files changed
  • 10 contributors

Commits on Aug 2, 2023

  1. [flutter_tools] set terminal.singleCharMode to false after attach fin… 

    …ishes (#131723)

Fixes #131511

Similar fix to 84c8abd#diff-38f3e3415d9806f22a78060fafb3206d1a006f74631fac04e7a680a64e06ccf0
    @christopherfujino
    christopherfujino authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    55bb3e5 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from d6b962d0e36d to 9304c0074d29 (4 revisions) (#… 

    …131790)

flutter/engine@d6b962d...9304c00

2023-08-02 [email protected] Roll ANGLE from d29f946d6180 to 01ee134bb223 (1 revision) (flutter/engine#44269)
2023-08-02 [email protected] [iOS][A11Y] fix hittest with non-SemanticsObject (flutter/engine#44014)
2023-08-02 [email protected] Roll ANGLE from d61a50c155bd to d29f946d6180 (1 revision) (flutter/engine#44267)
2023-08-02 [email protected] Roll Skia from 6009cc6d7d80 to 514c66ce0471 (2 revisions) (flutter/engine#44268)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    aa77d1f View commit details
    Browse the repository at this point in the history

  3. add gem dependency to the ios_app_with_extensions_test (#131713) 

    Adds gem dependency to the tests 

Fixes #131693
    Chris Yang authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    12b8e0c View commit details
    Browse the repository at this point in the history

  4. Roll Packages from 3dc00c1 to 4e4961a (1 revision) (#131788) 

    flutter/packages@3dc00c1...4e4961a

2023-08-02 [email protected] [google_maps_flutter_android] Disable flaky `testToggleInfo` test (flutter/packages#4629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5720dea View commit details
    Browse the repository at this point in the history

  5. [framework] lerp images in a save layer. (#131703) 

    Without a saveLayer, the BlendMode.plus will add itself to the backdrop and not just the previous image. Pushing without tests to see if existing goldens fail, but otherwise I have some good examples locally.

This is necessary uncondtionally, and lerping lerped images has the same issue.

Fixes #131617

### Before

![flutter_02](https://github.com/flutter/flutter/assets/8975114/1e783285-2fc2-429f-9fd8-6d04d4a155e1)

### After

![flutter_03](https://github.com/flutter/flutter/assets/8975114/3d08b187-26aa-4471-926d-e9ed5946a206)
    Jonah Williams authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    253bd3d View commit details
    Browse the repository at this point in the history

  6. Add documentation in flutter.groovy noting that we always use the lat… 

    …est available android version (#131705)

Last piece of/
Fixes #131425

Also added a period to a comment line that was missing one.
    @gmackall
    gmackall authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    00a8323 View commit details
    Browse the repository at this point in the history

  7. [framework] Add Look Up to selection controls for iOS (#131798) 

    This PR adds framework support for the Look Up feature in iOS. 

https://github.com/flutter/flutter/assets/36148254/d301df79-4e23-454f-8742-2f8e39c2960c

The corresponding merged engine PR can be found [here](flutter/engine#43308).
This PR addresses #82907 
More details are available in this [design doc.](flutter.dev/go/add-missing-features-to-selection-controls)

This is the same PR as #130532, this is an attempt to fix the Google Testing issue
    @LouiseHsu
    LouiseHsu authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f019789 View commit details
    Browse the repository at this point in the history

  8. Mention that the widget tree is not disposed on exit (#131637)

    @Hixie
    Hixie authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    47b188e View commit details
    Browse the repository at this point in the history

  9. Replace TextField.canRequestFocus with TextField.focusNode.canRequest… 

    …Focus (#130164)

Simplifying the TextField API.
    @justinmc
    justinmc authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9cda309 View commit details
    Browse the repository at this point in the history

  10. Update stack_frame.dart to parse unexpected error format to null. (#1… 

    …31786)

Fixes #131627

Originally this code sometimes was returning null and sometimes was failing, when stack frame is in unexpected format.

This PR updates for one of the code paths from failing to returning null.
    @polina-c
    polina-c authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0ad45f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Assert against infinite values of control points in CatmullRomSpline (#… 

    …131820)

When providing infinite values for the control points of CatmullRomSpline, a StackOverflowError occurs. This asserts against that and provides a helpful error message. 

Fixes #131246
    @Piinks
    Piinks authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b3a4dec View commit details
    Browse the repository at this point in the history

  2. Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revi… 

    …sions) (#131830)

Manual roll requested by [email protected]

flutter/engine@9304c00...4c1157b

2023-08-03 [email protected] Revert Android Hardware Texture PRs (flutter/engine#44310)
2023-08-03 [email protected] Roll Dart SDK from 87df1bbcea5e to 3b9af2825d47 (2 revisions) (flutter/engine#44308)
2023-08-03 [email protected] Roll Fuchsia Mac SDK from Hx7ap5qcoqRIknnnG... to WwFjJuQF_rpToCYPJ... (flutter/engine#44306)
2023-08-03 [email protected] Check whether the lookup of android.hardware.HardwareBuffer found a class (flutter/engine#44304)
2023-08-02 [email protected] [Impeller] Add placeholder filter input. (flutter/engine#44290)
2023-08-02 [email protected] Roll ANGLE from 6c1bab070220 to 6a09e41ce6ea (1 revision) (flutter/engine#44300)
2023-08-02 [email protected] Roll Skia from fd5bd67d532f to c0956a252f30 (1 revision) (flutter/engine#44296)
2023-08-02 [email protected] [iOS] Fix use-after-free in setBinaryMessenger (flutter/engine#44294)
2023-08-02 [email protected] Add Search Web to selection controls on iOS (flutter/engine#43324)
2023-08-02 [email protected] Improve logging in the clang-tidy script (flutter/engine#44228)
2023-08-02 [email protected] Roll ANGLE from 335c6b86d70b to 6c1bab070220 (1 revision) (flutter/engine#44291)
2023-08-02 [email protected] Roll Skia from 25f5a32367ad to fd5bd67d532f (2 revisions) (flutter/engine#44289)
2023-08-02 [email protected] Be sure to clear exceptions after a failed JNI lookup (flutter/engine#44293)
2023-08-02 [email protected] Handle deprecation of Dart_TimelineEvent Embedder API (flutter/engine#42497)
2023-08-02 [email protected] Roll Skia from ccc17f784e5d to 25f5a32367ad (4 revisions) (flutter/engine#44283)
2023-08-02 [email protected] Roll ANGLE from 01ee134bb223 to 335c6b86d70b (2 revisions) (flutter/engine#44287)
2023-08-02 [email protected] Roll Skia from 7104d0e8863f to ccc17f784e5d (2 revisions) (flutter/engine#44279)
2023-08-02 [email protected] [ios][autocorrection]disable auto-correction highlight in iOS 17 (flutter/engine#44176)
2023-08-02 [email protected] Reland Introduce TextureRegistry.ImageTexture and HardwareBufferExternalTextureGL (flutter/engine#44278)
2023-08-02 [email protected] Roll Dart SDK from afbaf4216fc8 to 87df1bbcea5e (1 revision) (flutter/engine#44276)
2023-08-02 [email protected] Roll Skia from 93764a98b866 to 7104d0e8863f (4 revisions) (flutter/engine#44273)
2023-08-02 [email protected] [Impeller] Fix leak of wrapped TextureMTL objects in the Metal embedder API (flutter/engine#44245)
2023-08-02 [email protected] Revert "Listen to window notifications to update application lifecycle" (flutter/engine#44275)
2023-08-02 [email protected] Roll Skia from 514c66ce0471 to 93764a98b866 (1 revision) (flutter/engine#44270)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Hx7ap5qcoqRI to WwFjJuQF_rpT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c00d241 View commit details
    Browse the repository at this point in the history
Loading