Comparing changes

…161855)" (#162046)  Reverts: #161855   Initiated by: harryterkelsen   Reason for reverting: causing test failures on `linux_unopt` shard https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1044163/infra   Original PR Author: flar   Reviewed By: {jonahwilliams}   This change reverts the following previous change: Handles the impeller unittests line in #161456 This PR is focused on the unit tests in Impeller. There are still some uses in other non-test areas which will be handled in a separate PR.  Co-authored-by: auto-submit[bot] <[email protected]>

…#161838) Fixes #161374 When we round out the texture size for a saveLayer, also round out the coverage so that the drawing origin is correct. Otherwise we may actually cut off the top left edge of rendering. --------- Co-authored-by: gaaclarke <[email protected]>

…1822) This reverts commit fe598e7. This benchmark can be moved back to the Linux devicelab machines now that https://dart-review.googlesource.com/c/sdk/+/403924 has landed. Fixes #161620

…rrectly. (#162023) Closes #62626.

…159975) ## Description This PR fixes `DropdownButtonFormField` text being clipped when using a large text scale. Before: ![image](https://github.com/user-attachments/assets/6c4deed2-eb61-4c0a-912e-dba364013038) After: ![image](https://github.com/user-attachments/assets/1dee5cda-9885-47c1-92a6-afbbc2312266) This extend the fix from #107201 which does not work properly with Material 3 (because of TextStyle.height being set for M3 default text styles). ## Related Issue Fixes [DropdownButtonFormField clips text when large text scale is used and useMaterial3 is true](#159971) ## Tests Adds 1 test. Updates 1 test.

This PR rolls in a number of breaking changes for native assets: * Pub workspaces are now supported, this requires a refactoring to how the `NativeAssetsBuildRunner` is used. Most notably it requires being explicit about the `runPackageName`. Flutter does not seem to have that value, but it does have the `projectUri` which can be used to find the package name via the package config. * The API for build hooks has been redesigned. This PR updates the project template, test project files, and test project strings. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Rolling in dart-lang/native#1933.

Make async calls use standard GLib async API. Remove test specific methods. Smaller cleanups.

Inherited opacity should be combined with the alpha of the ColorFilterContents when drawing objects with filters inside an opacity layer.

According to KhronosGroup/Vulkan-ValidationLayers#5806 , both eSampledImageYcbcrConversionLinearFilter and eSampledImageFilterLinear properties are required to use a linear chromaFilter.

Towards #160701. This adds a `bringup: true` node that duplicates what `Mac mac_clang_tidy` is doing, to be turned down/up in a follow-up.

…162032) Closes #161990. Closes #161406. I don't have a Windows machine present, so will let CI tell me if it's good to go.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Jan 23, 2025

This comparison is taking too long to generate.

Uh oh!