Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b0188cd18274
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fc8856eb80d3
Choose a head ref
  • 14 commits
  • 105 files changed
  • 7 contributors

Commits on Jun 15, 2023

  1. flutter update-packages --force-upgrade (#128908)

    - Bumps `vm_service` from `11.6.0` to `11.7.1`
    - Bumps `web` from `0.1.3-beta` to `0.1.4-beta` and adds it everywhere.
    - Moves `js` from `dependencies` to `dev_dependencies`
    mdebbar authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a162d75 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (#…

    …128849)
    
    flutter/engine@2d8d5ec...9934c0d
    
    2023-06-14 [email protected] Roll Dart SDK from
    2465228c0c21 to c4e9794df8af (1 revision) (flutter/engine#42831)
    2023-06-14 [email protected] Roll Fuchsia Linux SDK from
    kQbij6Tvqe7F9-PhR... to Xi3c5nti2LKnEOqYt... (flutter/engine#42832)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from kQbij6Tvqe7F to Xi3c5nti2LKn
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    12f2cbc View commit details
    Browse the repository at this point in the history
  3. add .pub-cache back to .gitignore (#128894)

    Fixes #128635
    
    In 1fd84f8, we renamed the `.pub-cache` entry in the `.gitignore` file to `.pub-preload-cache`, and ensured the packaging script was now populating that directory. However, for users who already had this directory from downloading an earlier archive but used `flutter upgrade` to get the latest code, they now had a `.gitignore` file that was no longer ignoring their `.pub-cache` directory.
    
    Now, when these users try to `flutter upgrade` again, the tool tries to verify if their checkout is clean, and will exit early if not directing the user to either stash or commit these changes, or do `flutter upgrade --force` which will try to update their branch anyway (and which would succeed since there would be no git conflict). These change adds back the `.pub-cache` entry to `.gitignore`, which won't retroactively fix broken releases, but will at least ensure if they `flutter upgrade --force` once to get this fix, they won't need to again.
    christopherfujino authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d3e771c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8c5a70f View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (#…

    …128959)
    
    flutter/engine@9934c0d...48e0b4e
    
    2023-06-15 [email protected] Roll Skia from 0b66c6928dcf to 2d531d020c26 (3 revisions) (flutter/engine#42883)
    2023-06-15 [email protected] Raster cache should preserve RTree for overlay layers (flutter/engine#42552)
    2023-06-15 [email protected] Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision) (flutter/engine#42879)
    2023-06-15 [email protected] [Linux] Allow BasicMessageChannel sending and responding to null message (flutter/engine#42808)
    2023-06-15 [email protected] Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision) (flutter/engine#42876)
    2023-06-15 [email protected] Roll Skia from d62221bd33a6 to 12375fb6f3c8 (1 revision) (flutter/engine#42873)
    2023-06-15 [email protected] Roll Skia from e2e0256d4c6a to d62221bd33a6 (1 revision) (flutter/engine#42871)
    2023-06-15 [email protected] Roll Skia from c3abd540c7f9 to e2e0256d4c6a (1 revision) (flutter/engine#42869)
    2023-06-15 [email protected] Roll Fuchsia Linux SDK from uvmDF7KM34dWGdsuK... to 53EjCyuRu91oFTBf2... (flutter/engine#42868)
    2023-06-15 [email protected] Roll Fuchsia Mac SDK from h3-8RUVrC889UXou7... to P7QA6bfO_Ij5dre7B... (flutter/engine#42867)
    2023-06-15 [email protected] Roll Skia from 2718866006d2 to c3abd540c7f9 (1 revision) (flutter/engine#42866)
    2023-06-15 [email protected] Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions) (flutter/engine#42864)
    2023-06-15 [email protected] Roll Dart SDK from 922c315b2c34 to 8eaed3382237 (1 revision) (flutter/engine#42862)
    2023-06-15 [email protected] Add missing artifact to the android_arm64_profile config. (flutter/engine#42858)
    2023-06-14 [email protected] Build skia with expat (flutter/engine#42859)
    2023-06-14 [email protected] [ios] use interfaceOrientation orientation on iOS 13 and above (flutter/engine#42846)
    2023-06-14 [email protected] Manual roll Dart SDK from f1387834bfd9 to 922c315b2c34 (4 revisions) (flutter/engine#42855)
    2023-06-14 [email protected] [Impeller] Make interleaved layout (more) explicit in generated headers. (flutter/engine#42628)
    2023-06-14 [email protected] Renamed validation layers build (flutter/engine#42826)
    2023-06-14 [email protected] [ios] view controller based status bar (flutter/engine#42643)
    2023-06-14 [email protected] Roll Skia from 6d5dc31d88e2 to 19051bc5fc90 (25 revisions) (flutter/engine#42828)
    2023-06-14 [email protected] Roll Fuchsia Linux SDK from Xi3c5nti2LKnEOqYt... to uvmDF7KM34dWGdsuK... (flutter/engine#42842)
    2023-06-14 [email protected] Fix generateLockfiles running directory for documentation (flutter/engine#42734)
    2023-06-14 [email protected] Roll Fuchsia Mac SDK from Cld7-rm6ZmCOO8j-K... to h3-8RUVrC889UXou7... (flutter/engine#42839)
    2023-06-14 [email protected] Roll ANGLE from 7e075469ff02 to 3a3a3c655a96 (8 revisions) (flutter/engine#42834)
    2023-06-14 [email protected] Roll Dart SDK from c4e9794df8af to f1387834bfd9 (1 revision) (flutter/engine#42833)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from Xi3c5nti2LKn to 53EjCyuRu91o
      fuchsia/sdk/core/mac-amd64 from Cld7-rm6ZmCO to P7QA6bfO_Ij5
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c716776 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3b2175 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f8e8d89 View commit details
    Browse the repository at this point in the history
  8. [flutter_tools] refactor license collector (#128748)

    Improve debugging for #128680
    
    In the linked issue, I cannot explain how we are getting a type error. However, this refactor eliminates the null check operator (by iterating over `MapEntries` rather than the keys) in hopes that there will be a more descriptive error in the future. The correctness of this change is verified by the existing tests in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/license_collector_test.dart
    christopherfujino authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    735fc29 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc83f03 View commit details
    Browse the repository at this point in the history
  10. Fix dart pub cache clean command on pub.dart (#128171)

    Command instruction for clearing dart pub cache is somewhat wrong. Instead of `clear`, `clean` is the correct one. Ref: https://dart.dev/tools/pub/cmd/pub-cache
    
    Fixes #128663
    
    (Edited by @andrewkolos. Changed "related to" issue to "fixes" to link this PR to the issue).
    deryrahman authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6b5766d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e87b202 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    dd4a815 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5cb2799 View commit details
    Browse the repository at this point in the history
  3. [web] Don't crash on const HtmlElementView() (#128965)

    Previously, when the code contained `const HtmlElementView()` it would break even if it's guarded by `if (kIsWeb)`.
    
    This PR makes it such that `const HtmlElementView()` is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms.
    
    One improvement we can make in the future is to have a conditional import:
    - `_html_element_view_web.dart` that contains the real `HtmlElementView` that can only be instantiated on web.
    - `_html_element_view_io.dart` that contains a stub with an unimplemented `build()` method.
    
    Fixes #43532
    mdebbar authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    fc8856e View commit details
    Browse the repository at this point in the history
Loading