Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab721f935ffc
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14549b38891f
Choose a head ref
  • 20 commits
  • 51 files changed
  • 9 contributors

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    85e509d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e791c43 View commit details
    Browse the repository at this point in the history
  3. Fix M3 Tabs Specs links (#138808)

    fixes [Material 3 Tab Specs links are broken/outdated ](#138805)
    TahaTesser authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ccc3622 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50c9a37 View commit details
    Browse the repository at this point in the history
  5. Reland VelocityTracker update (again) (#138843)

    This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.
    
    Relands #137381 which attempted to reland #132291
    Fixes #97761
    
    The original change was reverted due to flakiness it introduced in tests that use fling gestures.
    * #135728
    
    It was reverted again due to a change in the leak tracking tests that broke it.
    Piinks authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3e4e280 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba433eb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9d9dbb7 View commit details
    Browse the repository at this point in the history
  8. In flutter doctor -v, when JRE is too out-of-date to run `sdkmanage…

    …r`, print a helpful error message (#138762)
    
    Closes #138132. See this issue for more information.
    andrewkolos authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cf09a8a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    b186c69 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 7cf9d90d59e1 to 1ae1d5318257 (8 revisions) (#…

    …138861)
    
    flutter/engine@7cf9d90...1ae1d53
    
    2023-11-22 [email protected] Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299)
    2023-11-22 [email protected] [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298)
    2023-11-21 [email protected] Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297)
    2023-11-21 [email protected] Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296)
    2023-11-21 [email protected] Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295)
    2023-11-21 [email protected] Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294)
    2023-11-21 [email protected] Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293)
    2023-11-21 [email protected] [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    615481d View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 1ae1d5318257 to dda2499df48a (4 revisions) (#…

    …138872)
    
    flutter/engine@1ae1d53...dda2499
    
    2023-11-22 [email protected] Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) (flutter/engine#48305)
    2023-11-22 [email protected] Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) (flutter/engine#48304)
    2023-11-22 [email protected] [Impeller] make host buffer state internally ref counted. (flutter/engine#48303)
    2023-11-22 [email protected] Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) (flutter/engine#48302)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9a9ee23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b3f71ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    67a602d View commit details
    Browse the repository at this point in the history
  6. Add commandHasTerminal parameter + apple usage event + `sendExcepti…

    …on` events for `package:unified_analytics` (#138806)
    
    Relates to tracker issue:
    - #128251
    
    This PR includes 3 major updates:
    - Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult`
      - In `packages/flutter_tools/lib/src/runner/flutter_command.dart`
    - Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools)
      - In `packages/flutter_tools/lib/runner.dart`
    - Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites
      - Found in several files, highlighted in the sheet above
    eliasyishak authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    4818702 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    35a53b0 View commit details
    Browse the repository at this point in the history
  8. Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be u…

    …nflaky (#138886)
    
    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Mac_build_test flutter_gallery__transition_perf_e2e_ios"
    }
    -->
    The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_build_test%20flutter_gallery__transition_perf_e2e_ios%22).
    This test can be marked as unflaky.
    fluttergithubbot authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    29c95cd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    721ee57 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    843074c View commit details
    Browse the repository at this point in the history
  11. Update the default outline color for OutlinedButton (#138768)

    Fix b/311343182
    
    This is to update the default outline for `OutlinedButton`. When the button is focused, the outline color should be primary color.
    QuncCccccc authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c7d4b32 View commit details
    Browse the repository at this point in the history
  12. make FakeView not send Scene and semantics to the engine (#138849)

    `FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that.
    
    This unblocks flutter/engine#48251, which implements multi-view semantics for web.
    yjbanov authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    14549b3 View commit details
    Browse the repository at this point in the history
Loading