-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: ab721f935ffc
head repository: flutter/flutter
compare: 14549b38891f
- 20 commits
- 51 files changed
- 9 contributors
Commits on Nov 21, 2023
-
Roll Flutter Engine from 746697c27569 to 0c2de1e8849c (1 revision) (#…
…138834) flutter/engine@746697c...0c2de1e 2023-11-21 [email protected] [Impeller] preallocate command buffer to next power of two of entity list. (flutter/engine#48185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 85e509d - Browse repository at this point
Copy the full SHA 85e509dView commit details -
Roll Flutter Engine from 0c2de1e8849c to 31799868224d (1 revision) (#…
…138840) flutter/engine@0c2de1e...3179986 2023-11-21 [email protected] Make `{flow|fml|impeller}/...` compatible with `.clang_tidy`. (flutter/engine#48241) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for e791c43 - Browse repository at this point
Copy the full SHA e791c43View commit details -
Fix M3 Tabs Specs links (#138808)
fixes [Material 3 Tab Specs links are broken/outdated ](#138805)
Configuration menu - View commit details
-
Copy full SHA for ccc3622 - Browse repository at this point
Copy the full SHA ccc3622View commit details -
Roll Flutter Engine from 31799868224d to 90d1ff04ae02 (2 revisions) (#…
…138844) flutter/engine@3179986...90d1ff0 2023-11-21 [email protected] Make `{shell|lib/ui}/...` compatible with `.clang_tidy`. (flutter/engine#48242) 2023-11-21 [email protected] [Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. (flutter/engine#48190) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 50c9a37 - Browse repository at this point
Copy the full SHA 50c9a37View commit details -
Reland VelocityTracker update (again) (#138843)
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands #137381 which attempted to reland #132291 Fixes #97761 The original change was reverted due to flakiness it introduced in tests that use fling gestures. * #135728 It was reverted again due to a change in the leak tracking tests that broke it.
Configuration menu - View commit details
-
Copy full SHA for 3e4e280 - Browse repository at this point
Copy the full SHA 3e4e280View commit details -
Roll Flutter Engine from 90d1ff04ae02 to a8e9b8dd562b (1 revision) (#…
…138846) flutter/engine@90d1ff0...a8e9b8d 2023-11-21 [email protected] Update skia build file to account for new skcms changes. (flutter/engine#48286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ba433eb - Browse repository at this point
Copy the full SHA ba433ebView commit details -
Roll Flutter Engine from a8e9b8dd562b to 7cf9d90d59e1 (1 revision) (#…
…138847) flutter/engine@a8e9b8d...7cf9d90 2023-11-21 [email protected] Yet more compliance with `.clang_tidy`, stragglers edition. (flutter/engine#48291) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9d9dbb7 - Browse repository at this point
Copy the full SHA 9d9dbb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf09a8a - Browse repository at this point
Copy the full SHA cf09a8aView commit details
Commits on Nov 22, 2023
-
Revert "Reland VelocityTracker update (again)" (#138863)
Reverts #138843 This has broken the Mac_ios microbenchmarks_ios. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/9339/overview
Configuration menu - View commit details
-
Copy full SHA for b186c69 - Browse repository at this point
Copy the full SHA b186c69View commit details -
Roll Flutter Engine from 7cf9d90d59e1 to 1ae1d5318257 (8 revisions) (#…
…138861) flutter/engine@7cf9d90...1ae1d53 2023-11-22 [email protected] Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) (flutter/engine#48299) 2023-11-22 [email protected] [Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. (flutter/engine#48298) 2023-11-21 [email protected] Finish making `shell/platform/linux/...` compatible with `.clang-tidy`. (flutter/engine#48297) 2023-11-21 [email protected] Finish making `shell/platform/android/...` compatible with `.clang-tidy`. (flutter/engine#48296) 2023-11-21 [email protected] Finish making `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48295) 2023-11-21 [email protected] Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... (flutter/engine#48294) 2023-11-21 [email protected] Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) (flutter/engine#48293) 2023-11-21 [email protected] [Impeller] Switched to static linked libc++ in vulkan validation layers. (flutter/engine#48290) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Q3HcTitDF90Z to IK4xyRtZkDwq If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 615481d - Browse repository at this point
Copy the full SHA 615481dView commit details -
Roll Flutter Engine from 1ae1d5318257 to dda2499df48a (4 revisions) (#…
…138872) flutter/engine@1ae1d53...dda2499 2023-11-22 [email protected] Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) (flutter/engine#48305) 2023-11-22 [email protected] Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) (flutter/engine#48304) 2023-11-22 [email protected] [Impeller] make host buffer state internally ref counted. (flutter/engine#48303) 2023-11-22 [email protected] Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) (flutter/engine#48302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9a9ee23 - Browse repository at this point
Copy the full SHA 9a9ee23View commit details -
Roll Flutter Engine from dda2499df48a to 6c8f7b566a22 (1 revision) (#…
…138875) flutter/engine@dda2499...6c8f7b5 2023-11-22 [email protected] Roll Skia from 143b6b5b91a5 to cc9006085362 (1 revision) (flutter/engine#48306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b3f71ff - Browse repository at this point
Copy the full SHA b3f71ffView commit details -
Roll Flutter Engine from 6c8f7b566a22 to d55b673f895c (1 revision) (#…
…138890) flutter/engine@6c8f7b5...d55b673 2023-11-22 [email protected] Roll Skia from cc9006085362 to af2bd26a3a5e (1 revision) (flutter/engine#48307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 67a602d - Browse repository at this point
Copy the full SHA 67a602dView commit details -
Add
commandHasTerminalparameter + apple usage event + `sendExcepti……on` events for `package:unified_analytics` (#138806) Relates to tracker issue: - #128251 This PR includes 3 major updates: - Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult` - In `packages/flutter_tools/lib/src/runner/flutter_command.dart` - Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools) - In `packages/flutter_tools/lib/runner.dart` - Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites - Found in several files, highlighted in the sheet above
Configuration menu - View commit details
-
Copy full SHA for 4818702 - Browse repository at this point
Copy the full SHA 4818702View commit details -
Roll Flutter Engine from d55b673f895c to c954a64c509b (1 revision) (#…
…138894) flutter/engine@d55b673...c954a64 2023-11-22 [email protected] Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) (flutter/engine#48311) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 35a53b0 - Browse repository at this point
Copy the full SHA 35a53b0View commit details -
Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be u…
…nflaky (#138886) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_build_test flutter_gallery__transition_perf_e2e_ios" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_build_test%20flutter_gallery__transition_perf_e2e_ios%22). This test can be marked as unflaky.
Configuration menu - View commit details
-
Copy full SHA for 29c95cd - Browse repository at this point
Copy the full SHA 29c95cdView commit details -
Roll Packages from c9933fc to 2102327 (3 revisions) (#138895)
flutter/packages@c9933fc...2102327 2023-11-22 [email protected] [cross_file] adopt code excerpts in README (flutter/packages#5347) 2023-11-21 [email protected] Manual roll Flutter from 9c9e061 to ab721f9 (16 revisions) (flutter/packages#5461) 2023-11-21 [email protected] [url_launcher_web] migrate to pkg:web (flutter/packages#5451) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 721ee57 - Browse repository at this point
Copy the full SHA 721ee57View commit details -
Roll Flutter Engine from c954a64c509b to 342fb003b11f (1 revision) (#…
…138903) flutter/engine@c954a64...342fb00 2023-11-22 [email protected] Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) (flutter/engine#48315) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 843074c - Browse repository at this point
Copy the full SHA 843074cView commit details -
Update the default outline color for
OutlinedButton(#138768)Fix b/311343182 This is to update the default outline for `OutlinedButton`. When the button is focused, the outline color should be primary color.
Configuration menu - View commit details
-
Copy full SHA for c7d4b32 - Browse repository at this point
Copy the full SHA c7d4b32View commit details -
make FakeView not send Scene and semantics to the engine (#138849)
`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that. This unblocks flutter/engine#48251, which implements multi-view semantics for web.
Configuration menu - View commit details
-
Copy full SHA for 14549b3 - Browse repository at this point
Copy the full SHA 14549b3View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ab721f935ffc...14549b38891f