Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a8c8c5598c85
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d7ed5dc2e212
Choose a head ref
  • 7 commits
  • 10 files changed
  • 2 contributors

Commits on Jul 24, 2023

  1. Roll Flutter Engine from b314a29830f8 to 2ec1183e0dc3 (1 revision) (#… 

    …131167)

flutter/engine@b314a29...2ec1183

2023-07-24 [email protected] Roll Skia from 964f26400b7a to ce49fc71bc7c (1 revision) (flutter/engine#43939)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    bae6546 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 2ec1183e0dc3 to 35eab1bcf335 (1 revision) (#… 

    …131169)

flutter/engine@2ec1183...35eab1b

2023-07-24 [email protected] Roll Fuchsia Linux SDK from ybLfhFrKOi6jaYUv7... to A02P1GsGg001-Mpn3... (flutter/engine#43940)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from ybLfhFrKOi6j to A02P1GsGg001

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2b9ec67 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 35eab1bcf335 to c2c54f6406df (2 revisions) (#… 

    …131173)

flutter/engine@35eab1b...c2c54f6

2023-07-24 [email protected] Roll Fuchsia Mac SDK from Xm1-SWnXPhSRxNol-... to hUgYN9tEps515M1lg... (flutter/engine#43941)
2023-07-24 [email protected] [Impeller] Fix typo in help for compiler switches. (flutter/engine#43937)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Xm1-SWnXPhSR to hUgYN9tEps51

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4731580 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from c2c54f6406df to 402bceec81f4 (1 revision) (#… 

    …131174)

flutter/engine@c2c54f6...402bcee

2023-07-24 [email protected] Roll Skia from ce49fc71bc7c to f512e7eedaef (1 revision) (flutter/engine#43944)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e57c0ef View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from 402bceec81f4 to 4734a709cbf2 (2 revisions) (#… 

    …131175)

flutter/engine@402bcee...4734a70

2023-07-24 [email protected] Roll Skia from db314e2867bc to 860f12775838 (1 revision) (flutter/engine#43947)
2023-07-24 [email protected] Roll Skia from f512e7eedaef to db314e2867bc (1 revision) (flutter/engine#43945)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    acdd96b View commit details
    Browse the repository at this point in the history

  6. Use utf8.encode() instead of longer const Utf8Encoder.convert() (#130567 

    )

The change in [0] has propagated now everywhere, so we can use
`utf8.encode()` instead of the longer `const Utf8Encoder.convert()`.

Also it cleans up code like

```
  TypedData bytes;
  bytes.buffer.asByteData();
```

as that is not guaranteed to be correct, the correct version would be

```
  TypedData bytes;
  bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes);
```

a shorter hand for that is:

```
  TypedData bytes;
  ByteData.sublistView(bytes);
```

[0] dart-lang/sdk#52801
    @mkustermann
    mkustermann authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9c10151 View commit details
    Browse the repository at this point in the history

  7. Roll Flutter Engine from 4734a709cbf2 to aa876f6bec69 (2 revisions) (#… 

    …131190)

flutter/engine@4734a70...aa876f6

2023-07-24 [email protected] Roll ANGLE from 430a4f559cbc to e28575f66ae5 (1 revision) (flutter/engine#43951)
2023-07-24 [email protected] Roll Skia from 860f12775838 to a56bc23bfec7 (1 revision) (flutter/engine#43950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d7ed5dc View commit details
    Browse the repository at this point in the history
Loading