-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: a1a33e63b911
head repository: flutter/flutter
compare: c85fa6abf4ff
- 20 commits
- 155 files changed
- 15 contributors
Commits on May 28, 2024
-
[wiki migration] Leftover wiki pages and links (#148989)
This is waiting on - #148777 - #148790 After this PR lands, there will likely be 1-2 more clean up PRs, after which the migration will be done! --- This moves the remaining wiki pages as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing) It also adds the team labels to the label bot for future PRs. Changes to the content were only updating cross links, or links to refer to the main branch rather than master. Remaining links to the wiki will be updated once all other pages have finished moving, they still work in the meantime. Part of #145009
Configuration menu - View commit details
-
Copy full SHA for 1fbcbb7 - Browse repository at this point
Copy the full SHA 1fbcbb7View commit details -
[tool] Use kebabCase directly (#149150)
Drop silly snakeCase(..., '-') bits
Configuration menu - View commit details
-
Copy full SHA for 891432c - Browse repository at this point
Copy the full SHA 891432cView commit details -
Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (#…
…149169) flutter/engine@b175108...d032390 2024-05-28 [email protected] Roll Skia from 312160c7c920 to 848d9498fd68 (1 revision) (flutter/engine#53059) 2024-05-28 [email protected] [Impeller] Use scaled font to determine bounds, match Skia position rounding behavior, add subpixel X/Y/All/None positioning. (flutter/engine#53042) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 87564ce - Browse repository at this point
Copy the full SHA 87564ceView commit details -
Roll Packages from b7bcb4b to a933c30 (1 revision) (#149184)
flutter/packages@b7bcb4b...a933c30 2024-05-27 [email protected] Roll Flutter from 6564471 to 0b31ffc (7 revisions) (flutter/packages#6820) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 6543a21 - Browse repository at this point
Copy the full SHA 6543a21View commit details -
Remove
TextEditingControllerprivate member access (#149042)Fixes #148692 I intend to CP this.
Configuration menu - View commit details
-
Copy full SHA for b1221a9 - Browse repository at this point
Copy the full SHA b1221a9View commit details -
Mouse onEnter and onExit now support hovering stylus (#149006)
Hovering with a stylus will now behave similarly to hovering with a mouse. For example, hovering a button will show the button's hovered styling.
Configuration menu - View commit details
-
Copy full SHA for 980b5a1 - Browse repository at this point
Copy the full SHA 980b5a1View commit details -
Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… (
#143079) It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.
Configuration menu - View commit details
-
Copy full SHA for e2e68c0 - Browse repository at this point
Copy the full SHA e2e68c0View commit details -
fix M2 InputDecorator suffix icon doesn't turn red on error (#149161)
The suffixIcon of a TextField with an error now turns red like it should (on Material 2).
Configuration menu - View commit details
-
Copy full SHA for fdca33c - Browse repository at this point
Copy the full SHA fdca33cView commit details -
Change
android_plugin_new_output_dir_test.darttest description (#1……49198) Changes the test description to what I understand it is testing. Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157. cc @chunfengyao as the original author, as I see you are still active on Github ð���
Configuration menu - View commit details
-
Copy full SHA for df64ca0 - Browse repository at this point
Copy the full SHA df64ca0View commit details -
Introduced by #149006 To repro run: `flutter test /Users/polinach/_/flutter_dev/packages/flutter/test/material/text_button_test.dart --dart-define LEAK_TR` <img width="268" alt="Screenshot 2024-05-28 at 11 50 33�AM" src="https://github.com/flutter/flutter/assets/12115586/c1a1bf5e-4df4-4819-b897-b09021d3a07a">
Configuration menu - View commit details
-
Copy full SHA for c109b3c - Browse repository at this point
Copy the full SHA c109b3cView commit details -
Fix the RenderFlex.computeDryBaseline implementation to match compute…
…DistanceToActualBaseline (#149062) Per Hixie's comment [here](#145739 (comment)), keep the current behavior
Configuration menu - View commit details
-
Copy full SHA for 0214afb - Browse repository at this point
Copy the full SHA 0214afbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65e3007 - Browse repository at this point
Copy the full SHA 65e3007View commit details -
Add link to golden file test docs in the framework gardener guide (#1…
…49207) This also adds a link from the Framework gardener guide.
Configuration menu - View commit details
-
Copy full SHA for 1f4e378 - Browse repository at this point
Copy the full SHA 1f4e378View commit details
Commits on May 29, 2024
-
Fix
SearchAnchorsuggestions not refreshing after long API call (#1…Configuration menu - View commit details
-
Copy full SHA for b154032 - Browse repository at this point
Copy the full SHA b154032View commit details -
sliverGridDelegate mainAxisExtent add assert (#148470)
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use * Fixes #138871
Configuration menu - View commit details
-
Copy full SHA for af5a1a9 - Browse repository at this point
Copy the full SHA af5a1a9View commit details -
Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (#14…
…9224) Reverts: #148470 Initiated by: eyebrowsoffire Reason for reverting: Unit test failures closing the tree. Original PR Author: hello-coder-xu Reviewed By: {QuncCccccc, Piinks} This change reverts the following previous change: * sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use * Fixes #138871
Configuration menu - View commit details
-
Copy full SHA for 886de22 - Browse repository at this point
Copy the full SHA 886de22View commit details -
Change snack bar default hitTestBehavior to deferToChild when SnackBa…
…rThemeData.insetPadding is not null (#148568) The PR changes the default value of hitTestBehavior in snack bars to `HitTestBehavior.deferToChild` when snackBarTheme.insetPadding is not null, so that widgets behind snack bars affected by the value set to insetPadding, remain interactive even while a snack bar is visible. This PR can be considered as an extension to what have been done in PR #127959 which fixes the same problem but for individual snack bars with margin not being null. This PR works on the theme level. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* #148566
Configuration menu - View commit details
-
Copy full SHA for 9ea9726 - Browse repository at this point
Copy the full SHA 9ea9726View commit details -
Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revi…
…sions) (#149220) Manual roll requested by [email protected] flutter/engine@d032390...b26e1b0 2024-05-28 [email protected] Manual revert of #53001 (flutter/engine#53075) 2024-05-28 [email protected] Remove --ios-cpu flag. Only the arm64 variant is supported. (flutter/engine#53044) 2024-05-28 [email protected] Roll Skia from 229d94a8807e to ac454b80130c (1 revision) (flutter/engine#53074) 2024-05-28 [email protected] [Impeller] make strokes slightly lighter. (flutter/engine#53067) 2024-05-28 [email protected] Roll Skia from 23ddbb590e44 to 229d94a8807e (2 revisions) (flutter/engine#53071) 2024-05-28 [email protected] FlutterFragment predictive back (flutter/engine#52302) 2024-05-28 [email protected] Roll Skia from 02c359cf8233 to 23ddbb590e44 (2 revisions) (flutter/engine#53070) 2024-05-28 [email protected] Roll Skia from 4f91b3865441 to 02c359cf8233 (1 revision) (flutter/engine#53069) 2024-05-28 [email protected] [Impeller] shrunk the buffer for the rrect_blur (flutter/engine#53068) 2024-05-28 [email protected] Roll Skia from 91cd2b48377a to 4f91b3865441 (4 revisions) (flutter/engine#53066) 2024-05-28 [email protected] Upgrade all[most] androidx dependencies to latest (flutter/engine#53001) 2024-05-28 [email protected] Roll Skia from 0c2c490021b7 to 91cd2b48377a (3 revisions) (flutter/engine#53065) 2024-05-28 [email protected] Roll Skia from 545203f95d4e to 0c2c490021b7 (2 revisions) (flutter/engine#53063) 2024-05-28 [email protected] Roll Skia from 74b4d97be6ab to 545203f95d4e (1 revision) (flutter/engine#53062) 2024-05-28 [email protected] Roll Skia from 848d9498fd68 to 74b4d97be6ab (1 revision) (flutter/engine#53061) 2024-05-28 [email protected] Remove use of --nnbd-agnostic (flutter/engine#53055) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 35ae519 - Browse repository at this point
Copy the full SHA 35ae519View commit details -
Add tests for animated_switcher.0.dart API example. (#149180)
This PR contributes to #130459 ### Description - Adds tests for `examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart`
Configuration menu - View commit details
-
Copy full SHA for 60d32e4 - Browse repository at this point
Copy the full SHA 60d32e4View commit details -
Clean leak in editable_text_test.dart. (#149223)
Introduced by #149042 <img width="145" alt="Screenshot 2024-05-28 at 6 25 22�PM" src="https://github.com/flutter/flutter/assets/12115586/5eb32012-b1c4-4188-8e9b-a6631483960c">
Configuration menu - View commit details
-
Copy full SHA for c85fa6a - Browse repository at this point
Copy the full SHA c85fa6aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a1a33e63b911...c85fa6abf4ff