Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9d32f07e34c3
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7fa932be5c12
Choose a head ref
  • 19 commits
  • 35 files changed
  • 9 contributors

Commits on Mar 31, 2024

  1. Configuration menu
    Copy the full SHA
    b1cdd0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd8561a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Configuration menu
    Copy the full SHA
    0753f22 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from e9d35f8bfbe2 to 984a78b04671 (2 revisions) (#…

    …146062)
    
    flutter/engine@e9d35f8...984a78b
    
    2024-04-01 [email protected] Roll Skia from b9d078716d40 to 45e4d2cbdd4f (2 revisions) (flutter/engine#51806)
    2024-04-01 [email protected] Roll Fuchsia Linux SDK from TXxMINUq7JduIRX8K... to 5W6KVvHCGwWHBjm2m... (flutter/engine#51805)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from TXxMINUq7Jdu to 5W6KVvHCGwWH
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    984c69a View commit details
    Browse the repository at this point in the history
  3. Add DataColumn.headingRowAlignment for DataTable (#144006)

    fixes [[`DataTable`]  Unable to center the label of a DataColumn without side effects](#143340)
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          debugShowCheckedModeBanner: false,
          home: MaterialApp(
            home: Material(
              child: DataTable(
                columns: <DataColumn>[
                  DataColumn(
                    headingRowAlignment: MainAxisAlignment.center,
                    onSort: (int columnIndex, bool ascending) {},
                    label: const Text('Header'),
                  ),
                ],
                sortColumnIndex: 0,
                rows: const <DataRow>[
                  DataRow(
                    cells: <DataCell>[
                      DataCell(Center(child: Text('Data'))),
                    ],
                  ),
                ],
              ),
            ),
          ),
        );
      }
    }
    ```
    
    </details>
    
    ### Center `DataColumn.mainAxisAlignment` without sort arrow
    ![Screenshot 2024-03-25 at 17 13 05](https://github.com/flutter/flutter/assets/48603081/0c91d279-23e8-40d9-ab86-c08013c73666)
    
    ### Center `DataColumn.mainAxisAlignment` with sort arrow
    
    ![Screenshot 2024-03-25 at 17 11 54](https://github.com/flutter/flutter/assets/48603081/d042d02a-e7be-4f47-a90c-8a1ee0f7f5f3)
    TahaTesser authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    40dda2b View commit details
    Browse the repository at this point in the history
  4. Deprecate ButtonBar, ButtonBarThemeData, and `ThemeData.buttonBar…

    …Theme` (#145523)
    
    fixes [Deprecate `ButtonBar`](#127955)
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          theme: ThemeData(
            buttonBarTheme: const ButtonBarThemeData(
              alignment: MainAxisAlignment.spaceEvenly,
            ),
          ),
          home: Scaffold(
            body: ButtonBar(
              alignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 1'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 2'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 3'),
                ),
              ],
            ),
          ),
        );
      }
    }
    ```
    
    </details>
    
    ## Data driven fix
    
    ### Before executing `dart fix --apply`
    ```dart
      return MaterialApp(
          theme: ThemeData(
            buttonBarTheme: const ButtonBarThemeData(
              alignment: MainAxisAlignment.spaceEvenly,
            ),
          ),
          home: Scaffold(
            body: ButtonBar(
              alignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 1'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 2'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 3'),
                ),
              ],
            ),
          ),
        );
    ```
    
    ### After executing `dart fix --apply`
    ```dart
        return MaterialApp(
          theme: ThemeData(
    
          ),
          home: Scaffold(
            body: OverflowBar(
              alignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 1'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 2'),
                ),
                TextButton(
                  onPressed: () {},
                  child: const Text('Button 3'),
                ),
              ],
            ),
          ),
        );
    ```
    TahaTesser authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e85340e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5537688 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    888cf95 View commit details
    Browse the repository at this point in the history
  7. Flutter Gradle Plugin: add versionName and versionCode to FlutterExte…

    …nsion (#146044)
    
    This PR is a follow-up of a previous PR of mine:
    #141417. It was unfinished, i.e.
    I only implemented it and used it in `examples/hello_world`. No "flutter
    create" templates were modified.
    
    This change is theoretically breaking, but in practice, I am pretty sure
    nobody uses this. It was not accounced anywhere, the only app using it
    is `examples/hello_world`. I did not do that (that=update docs and
    templates) because I wanted a solution that is idiomatic in both Gradle
    and Kotlin, and only now I found time to do this.
    
    ### Without this change
    
    ```groovy
    defaultConfig {
        applicationId = "io.flutter.examples.hello_world"
        minSdk = flutter.minSdkVersion
        targetSdk = flutter.targetSdkVersion
        versionCode = flutter.versionCode()
        versionName = flutter.versionName()
    }
    ```
    
    ### With this change
    
    ```groovy
    defaultConfig {
        applicationId = "io.flutter.examples.hello_world"
        minSdk = flutter.minSdkVersion
        targetSdk = flutter.targetSdkVersion
        versionCode = flutter.versionCode
        versionName = flutter.versionName
    }
    ```
    
    Idiomatic getter - yay! It's consistent between assignment of all four
    props.
    
    ### Issue
    
    fixes #146067
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: Reid Baker <[email protected]>
    bartekpacia and reidbaker authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ec82f0d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a187cc7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    181b69b View commit details
    Browse the repository at this point in the history
  10. Roll Flutter Engine from dd4f5cd5c9d5 to d33666d90916 (3 revisions) (#…

    …146083)
    
    flutter/engine@dd4f5cd...d33666d
    
    2024-04-01 [email protected] Roll Skia from da4cd3390be9 to dacd62255b8d (1 revision) (flutter/engine#51813)
    2024-04-01 [email protected] Roll buildroot to dcd71b5b237e1e58f2ad8a7e51bead0c2a3755a9 (flutter/engine#51812)
    2024-04-01 [email protected] Roll Dart SDK from b735974580e7 to aa6544b48523 (1 revision) (flutter/engine#51810)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    bd90954 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6d7922f View commit details
    Browse the repository at this point in the history
  12. Roll Flutter Engine from d33666d90916 to 8dff6b833fe2 (3 revisions) (#…

    …146087)
    
    flutter/engine@d33666d...8dff6b8
    
    2024-04-01 [email protected] Use the stripped Vulkan validation library in Android engine builds by default (flutter/engine#51628)
    2024-04-01 [email protected] [Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface (flutter/engine#51770)
    2024-04-01 [email protected] Never panic in `finally { ... }`, check output logs on success only. (flutter/engine#51814)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8c3575d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1e20714 View commit details
    Browse the repository at this point in the history
  14. Add test for animated_container.0.dart API example. (#145995)

    This PR contributes to #130459
    
    ### Description
    - Adds test for `examples/api/test/widgets/implicit_animations/animated_container.0_test.dart`
    ksokolovskyi authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    5850651 View commit details
    Browse the repository at this point in the history
  15. Add info strings to code blocks. (#146085)

    In preparation to add the lint
    `missing_code_block_language_in_doc_comment`, added info strings to a
    bunch of fenced code blocks.
    
    Related to issue: https://github.com/dart-lang/linter/issues/4904
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/wiki/Data-driven-Fixes
    kallentu authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    9fd9f04 View commit details
    Browse the repository at this point in the history
  16. Refactor realm_checker (#145905)

    Refactor realm_checker suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing realm_checker tests
    
    Part of #145482
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    sealesj authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f8a06f6 View commit details
    Browse the repository at this point in the history
  17. Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) (#…

    …146100)
    
    flutter/engine@e6f1940...ea93c5d
    
    2024-04-01 [email protected] [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269)
    2024-04-01 [email protected] Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815)
    2024-04-01 [email protected] [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7fa932b View commit details
    Browse the repository at this point in the history
Loading